Re: [Dpp-devel] Review Request: [FIX] 3348949 :correct, but confusing inconsistency message

[Julia S. <jul...@fu...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/176/#review745
-----------------------------------------------------------


In my mind the message contains redundant information, whereby the first sentence is not expressive: "Unsaved changes must be saved"--> Why?, Where are unsaved changes?, What happens if I do not save them?
"You must save all changes before accepting an invitation."

Suggestion: "In this project-invitation you are reusing local project(s) containing unsaved changes. Before you can accept any invitation you have to save these files: [list with files containg unsaved changes and option to cancel/go back or save them all]"

- Julia


On Jan. 5, 2012, 5:10 p.m., Karl Beecher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/176/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2012, 5:10 p.m.)
> 
> 
> Review request for Saros.
> 
> 
> Summary
> -------
> 
> Bug : http://sourceforge.net/tracker/?func=detail&aid=3348949&group_id=167540&atid=843359
> 
> "File X is part of project A and is open in an editor with unsaved changes.
> Now I am invited to a session and I reuse project A, which contains file X.
> After the invitation finishes, an inconsistency is reported (presumably because the file on disk does not match the editor buffer contents).
> This is not really wrong (because my local changes _ought_ to be overwritten by the project synchronization), but is confusing.
> The nice solution would ask me about this situation during the invitation process, when one of my editors is found to contain a file that will be subject to synchronization from the remote host."
> 
> Solution:
>  The user is asked  to save changes to files before starting the process of invitation. 
> 
> Note: suggestions for the text of the question are welcome !!
> 
> 
> Diffs
> -----
> 
>   trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/editor/EditorManager.java 3700 
>   trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/editor/internal/EditorAPI.java 3700 
>   trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/AddProjectToSessionWizard.java 3700 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/176/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karl
> 
>