Re: [Dpp-devel] Review Request: [REFACTORED] EnterProjectNamePage

[Hendrik D. <hen...@fu...>]

> On Nov. 29, 2011, 4:09 p.m., Hendrik Degener wrote:
> > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/pages/EnterProjectNamePage.java, line 866
> > <http://saros-build.imp.fu-berlin.de/reviews/r/232/diff/1/?file=2477#file2477line866>
> >
> >     which abstraction is breaking?
> 
> Stefan Rossbach wrote:
>     You skip the Eclipse File layer. It is possible to create a project, delete it without removal of the files and then recreate it, so all files are still there. Mixing up the APIs e.g Java File access and Eclipse File access is not that optimal.

But the project is deleted from workspace anyway, that's why I consider it necessary to mix the APIs. Eclipse file access depends on a presence in workspace, java file access doesn't.
I took a look at NewJavaProjectWizardPageOne to get an impression about how the new java project wizard handles this case. It checks Platform.getLocation().append("projectname").isDirectory().


- Hendrik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/232/#review718
-----------------------------------------------------------


On Nov. 26, 2011, 11:29 p.m., Stefan Rossbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/232/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2011, 11:29 p.m.)
> 
> 
> Review request for Saros.
> 
> 
> Summary
> -------
> 
> Splitted into 2 classes.
> FIX: trailing whitespaces
> FIX: illegal characters
> FIX: no longer possible to merge different projects into one final project
> Removed: Create copy ... as it does not do what it says.
> 
> Known Issues: currently hard coded strings.
> 
> 
> Diffs
> -----
> 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/widgets/wizard/EnterProjectNameComposite.java PRE-CREATION 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/pages/EnterProjectNamePage.java 3683 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/232/diff
> 
> 
> Testing
> -------
> 
> manual, STF is adapted after positive review.
> 
> 
> Thanks,
> 
> Stefan
> 
>