Re: [Dpp-devel] Review Request: [FIX] Overlapping partial sharing unshares files for initial host - ID: 3439851

[Stefan R. <ros...@in...>]

> On Nov. 28, 2011, 5:59 p.m., Karl Beecher wrote:
> > Like Stefan says, supply a test case with the commit please!

need based feature tests can be found in the package de.fu_berlin.inf.dpp.stf.test.needbased


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/226/#review712
-----------------------------------------------------------


On Nov. 21, 2011, 8:52 p.m., Norman Warnatsch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/226/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2011, 8:52 p.m.)
> 
> 
> Review request for Saros.
> 
> 
> Summary
> -------
> 
> Bug-Description:
> Alice and Bob have the project foo with the files A.txt and B.txt.
> 
> 1. Alice shares file A.txt with Bob (Bob chooses existing project foo).
> 2. Bob adds file B.txt to session (Alice chooses existing project foo).
> result: Alice lost the information that file A.txt is shared.
> 
> The reason was found in the function IncomingProjectNegotiation.accept().
> The following loop overwrites the existing rights and the knowledge on the side of alice:
> 
>             
> 
> // the user who sends this ProjectNegotiation is now responsible for
>             
> // all resources from that project
>             
> for (Entry<String, IProject> entry : localProjects.entrySet()) {
> 
>                 sessionManager.getSarosSession().addProjectOwnership(
> 
>                     entry.getKey(), entry.getValue(), jid);
> 
>             }
> 
> 
> To solve this problem, the function addProjectOwnership is queried whether the project is shared.
> 
> 
> This addresses bug 3439851.
>     http://sourceforge.net/support/tracker.php?aid=3439851
> 
> 
> Diffs
> -----
> 
>   trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/internal/SarosSession.java 3671 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/226/diff
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> Norman
> 
>