From: Roman S. <ar...@ze...> - 2011-09-29 12:52:00
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/160/#review526 ----------------------------------------------------------- Not really a review but a general comment: I think this patch won't be completely reviewed by anyone, the reason is quite simple and you said it already yourself "... no lust to browse through 2000 Lines of weird code..." => I don't think that anyone will spend the time going through all these lines trying to understand every idea and reason of each change you made (because it's a really big and long work) - I tried it because it was connected to the refactoring work my group did for the SWP SWT, but I gave up after a small part because I lost the overall view of all the changes. Independently, it would be really good to get your improvement into Saros (because as far as I can judge by now it's a really nice piece of work) - so there are two options: a)take these changes and split it into smaller standalone(=applying just one or two off all patches doesn't change the functionality of Saros) patches, so that each part can be tested on conflicts and reviewed on its own b) it might be difficult to do a) with the already finished work, and you did the work once so you have already all the ideas so writing it another time might consume less time, but you are the only one who can estimate which way is faster/easier - Roman On Sept. 15, 2011, 10:54 a.m., Stefan Rossbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/160/ > ----------------------------------------------------------- > > Review request for Saros. > > > Summary > ------- > > The files of the project are now streamed instead of compressed and then send via an archive (they are compressed on the fly). > > Known bugs: > > Progress monitors display the wrong status > > I know this is quite a big patch, because i was refactoring some files > > Should work with multiple projects and users. > > Yes i know that there was a streaming solution, but i do not use them because the StreamServiceManager can freeze Eclipse. I had no > lust to browse through 2000 Lines of weird code, so i implemented this feature from scratch. > > > This addresses bug 3390825. > http://sourceforge.net/support/tracker.php?aid=3390825 > > > Diffs > ----- > > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/SarosContext.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/exceptions/LocalCancellationException.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ArchiveStreamService.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ICancelable.java PRE-CREATION > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingProjectNegotiation.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/InvitationProcess.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingProjectNegotiation.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ProjectNegotiation.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/ITransmitter.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/DataTransferManager.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/TransferDescription.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/XMPPTransmitter.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/AddProjectToSessionWizard.java 3550 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/util/FileZipper.java 3550 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/160/diff > > > Testing > ------- > > manual and STF self test, also i got some failures. I am just investigate the problems. > > > Thanks, > > Stefan > > |