From: Stefan R. <ros...@in...> - 2011-09-05 02:47:54
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/100/#review475 ----------------------------------------------------------- Ship it! - Stefan On Sept. 4, 2011, 11:53 a.m., Philipp Cordes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/100/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2011, 11:53 a.m.) > > > Review request for Saros. > > > Summary > ------- > > With this patch we introduce a new abstract class which will be the central point for coming functionality which makes the writing of new unit-tests more comfortable. > > When you want to create a new test class you only must set this as subclass of AbstractSarosUnitTest. > Than when you run tests there will be automatically start a local XMPP-Server with which possibly created test-instances can communicate. > > I also added a simple method for getting a full configured test-instance. But this method will be replaced later by a separate class which will provide different and more complex types of scenario-creation. > > To reuse the initialization of the PreferenceStore I refactored the PreferenceInitializer to do it's job in more abstract way. So it can now initialize instances from type IEclipsePreferences AND IPreferenceStore. > > For a better understanding look at the simple Test: BasicFrameworkTest > > > Diffs > ----- > > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/Saros.java 3548 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/SarosContext.java 3548 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/preferences/PreferenceInitializer.java 3548 > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/context/TestSaros.java 3548 > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/net/BasicFrameworkTest.java PRE-CREATION > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/util/AbstractSarosUnitTest.java PRE-CREATION > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/util/EclipseHelperTestSaros.java 3548 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/100/diff > > > Testing > ------- > > BasicFrameworkTest > > > Thanks, > > Philipp > > |