Re: [Dpp-devel] Review Request: [CHANGE] Improved Screensharing FPS with pure Java implementation

[Philipp C. <>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/106/#review268
-----------------------------------------------------------

Ship it!


looks fine shipt it :)
it would be nice if you could improve a little bit the readability. I needed too much time for understanding the behaviour. see comments...




/trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/videosharing/encode/ImageTileEncoder.java
<http://saros-build.imp.fu-berlin.de/reviews/r/106/#comment222>

    Encoding Problems?



/trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/videosharing/encode/ImageTileEncoder.java
<http://saros-build.imp.fu-berlin.de/reviews/r/106/#comment226>

    I added some comments to points where I  think it would be cool to find some doc and to extract code as a seperate method to provide a better understanding.
    
    For now I think this method-impl is too long.
    
    Can you describe in 1-2 sentences what the behaviour of the algo is. I needed approx 15min to roughly understand what here will happen. 



/trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/videosharing/encode/ImageTileEncoder.java
<http://saros-build.imp.fu-berlin.de/reviews/r/106/#comment223>

    Will be the first case run only once?
    
    Is it possible to extract methods for both cases for a better understanding?



/trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/videosharing/encode/ImageTileEncoder.java
<http://saros-build.imp.fu-berlin.de/reviews/r/106/#comment224>

    why?



/trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/videosharing/encode/ImageTileEncoder.java
<http://saros-build.imp.fu-berlin.de/reviews/r/106/#comment225>

    Extract as method like "checkFramerate" or something like that?


- Philipp


On July 19, 2011, 2:04 p.m., srossbac wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/106/
> -----------------------------------------------------------
> 
> (Updated July 19, 2011, 2:04 p.m.)
> 
> 
> Review request for Saros.
> 
> 
> Summary
> -------
> 
> This patch introduce better performance of the screen sharing feature whith pure Java implementation. Drawbacks are the required bandwith. At least up to 200 kb/s with 10 FPS @ 320x240 when you are scrolling over the screen.
> 
> 
> Diffs
> -----
> 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/videosharing/decode/ImageTileDecoder.java 3463 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/videosharing/encode/ImageTileEncoder.java 3463 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/106/diff
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> srossbac
> 
>