From: Karl B. <be...@in...> - 2011-07-07 09:03:59
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/94/#review219 ----------------------------------------------------------- -1 This is not the solution we should use. If someone unthinkingly deletes their copy of the project, everyone loses their own copy. This should not happen. Deleting a shared project should not be allowed while a session is in progress. If someone tries, it should be blocked (the existing message about the consequence being to leave the session does this). The solution should be something like "unsharing" a project (so the message would have to be amended, telling the user to either leave or "unshare" the project before deleting it). - Karl On July 5, 2011, 2:25 p.m., karlheld wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/94/ > ----------------------------------------------------------- > > (Updated July 5, 2011, 2:25 p.m.) > > > Review request for Saros. > > > Summary > ------- > > The deletion of a Project is now transmitted to all session participants. The Session is not ended. Everyone with write-access can delete shared projects. No inconsistencys should appear. > > > This addresses bug 3118933. > http://sourceforge.net/support/tracker.php?aid=3118933 > > > Diffs > ----- > > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/activities/business/AbstractActivityReceiver.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/activities/business/IActivityReceiver.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/activities/business/ProjectActivity.java PRE-CREATION > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/activities/serializable/ProjectActivityDataObject.java PRE-CREATION > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/ActivitiesExtensionProvider.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/ISarosSession.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SharedProject.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/internal/ResourceChangeValidator.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/internal/SarosSession.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/serviceProviders/NullSarosSession.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/util/FileUtils.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/test/stubs/SarosSessionStub.java 3447 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/94/diff > > > Testing > ------- > > manual > > > Thanks, > > karlheld > > |