Re: [Dpp-devel] Review Request: [FIX] NullPointer Exception if Synchronisation is cancelled - ID: 3348910

[srossbac <sro...@in...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/97/#review216
-----------------------------------------------------------


Hi Karl, the synchronized method will not help at all. You are returning the orginal map, which can be a bad pratice because everyone can modify it without any problems. The problem is, when some code now starts iterating over the map and another thread alters the map, then a exception will be thrown where you would not expect it. I have alreay found such exceptions in the log file. What is the problem to just return a copy of the map ?

- srossbac


On July 5, 2011, 11:01 p.m., karlheld wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/97/
> -----------------------------------------------------------
> 
> (Updated July 5, 2011, 11:01 p.m.)
> 
> 
> Review request for Saros.
> 
> 
> Summary
> -------
> 
> Canceling the SessionNegotiation, ProjectNegotiation and Synchronization is now without NullPointer Exceptions. Instead Messages are shown.
> 
> 
> This addresses bug 3348910.
>     http://sourceforge.net/support/tracker.php?aid=3348910
> 
> 
> Diffs
> -----
> 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingProjectNegotiation.java 3447 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingProjectNegotiation.java 3447 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingSessionNegotiation.java 3447 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/business/CancelInviteHandler.java 3447 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/observables/InvitationProcessObservable.java 3447 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/observables/ProjectNegotiationObservable.java 3447 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3447 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/AddProjectToSessionWizard.java 3447 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/97/diff
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> karlheld
> 
>