Menu
▾
▴
Re: [Dpp-devel] Review Request: Manage Saros_labels' name with a common properties file: saros_labels.properties
|
From: Björn <bjo...@in...> - 2011-01-31 02:13:05
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/169/#review405 ----------------------------------------------------------- -1 Instead of keeping a copy of the labels in a property file I would access the action's labels directly. E.g.: skypeAction.getText() This returns the current label. - Björn On 2011-01-30 18:11:14.705257, Lin Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/169/ > ----------------------------------------------------------- > > (Updated 2011-01-30 18:11:14.705257) > > > Review request for All Saros. > > > Summary > ------- > > Recently STF localized widget controls based on their labels, i.e. if labels are changed, all affected tests need to be adjusted. To reduce the maintain-effrot for tests there are two solutions: > > 1. assign widget Controls IDs with e.g. someControl.setData("de.fu_berlin.inf.dpp.widget.key", "someId"). > > With setData the Id-Informationen would be added to an SWT Control, which can be then localized by STF. Thereby even if the label of a widget control has changed, no changes to the test-code are necessary. Disadvantage is that developers need to setData on components when they create it and tests have poor readability because there's no way to figure out what widget the ID corresponds to. > > 2. Define a common properties file saros_labels.properites. > > The file manage all widget-labels' name existed in Saros-Project and both of Saros-project and STF access the common properties file. i.e. You need to only modify the properties file to change some labels. Thereby no changes to the test-code are necessary. > > I've decided to use the second solution because of the readability. In this patch i've created the properties file, in which almost all existed labels are defined. > > TODO: If you agree to my decision, please help me set saros-components using the properties file. > > > Diffs > ----- > > ./src/saros_labels.properties PRE-CREATION > ./test/src/de/fu_berlin/inf/dpp/stf/SarosLabels.java PRE-CREATION > ./test/src/de/fu_berlin/inf/dpp/stf/client/testProject/testsuits/STFTest.java 2979 > ./test/src/de/fu_berlin/inf/dpp/stf/client/testProject/testsuits/basicElements/TestBasicComponentByAliceAndBob.java 2979 > ./test/src/de/fu_berlin/inf/dpp/stf/client/testProject/testsuits/basicElements/TestMainMenuComponent.java 2978 > ./test/src/de/fu_berlin/inf/dpp/stf/client/testProject/testsuits/basicElements/TestSessionViewComponent.java 2978 > ./test/src/de/fu_berlin/inf/dpp/stf/client/testProject/testsuits/invitation/permutations/TestParallelInvitationWithTerminationByHost.java 2979 > ./test/src/de/fu_berlin/inf/dpp/stf/client/testProject/testsuits/invitation/permutations/TestParallelInvitationWithTerminationByInvitees.java 2978 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/EclipsePart.java 2978 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/contextMenu/SarosCImp.java 2978 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/contextMenu/TeamCImp.java 2977 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/editor/EditorImp.java 2977 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/menuBar/EditMImp.java 2977 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/menuBar/FileMImp.java 2977 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/menuBar/RefactorMImp.java 2977 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/menuBar/SarosMImp.java 2978 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/menuBar/WindowMImp.java 2977 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/views/PEViewImp.java 2977 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/views/sarosViews/ChatViewImp.java 2978 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/views/sarosViews/RSViewImp.java 2977 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/views/sarosViews/RosterViewImp.java 2978 > ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSarosSWTBot/eclipse/workbench/views/sarosViews/SessionViewImp.java 2978 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/169/diff > > > Testing > ------- > > > Thanks, > > Lin > > |