Re: [Dpp-devel] [Patch] Changing JID to User in activities

[Henning S. <hen...@fu...>]

Hi,

Am 23.11.2009 um 16:55 schrieb Marc 'BlackJack' Rintsch:

> [INTERNAL] Replaced ''JID''s in activities by ''User'' objects.
> [INTERNAL] Changed some unit tests to use already existing objects  
> from
> parent class' ''setUp()'' method.
> [TASK] Refactor ''CounterExampleTest''.

-1

+1 if all smu is removed.

In de.fu_berlin.inf.dpp.concurrent.jupiter.Algorithm the parameter  
"User jid" should be renamed to "User source".

public JupiterActivity generateJupiterActivity(Operation op, User  
originator, IPath editor) {
->
public JupiterActivity generateJupiterActivity(Operation op, User  
source, IPath editor) {
and the comment is wrong (JID != User)

de 
.fu_berlin 
.inf.dpp.net.business.ConsistencyWatchdogHandler.recoverFile(JID from,  
final ISharedProject project,
         final User myJID, final IPath path, SubMonitor progress)
User myJID -> User user

StopManager:315 stopActivityDataObject -> stopActivity

JupiterSimulator:56 double mocking ;)

ProxySynchronizedQueue:28, ServerSynchronizedDocument:33,  
TwoWayJupiterClientDocument:11, TwoWayJupiterServerDocument:18 User  
jid -> User user

TwoWayJupiterClientDocument.createUserMock double implementation  
(JupiterTest)


regards,
   Henning