[Docutils-develop] Re: components.Filter transform

[Felix W. <Fel...@gm...>]

David Goodger wrote:

> David Goodger wrote:
>
>>>>> Perhaps we need a disable_transforms attribute, for transforms
>>>>> that should *not* be run with the component, to disable the
>>>>> components.Filter transform and leave all pending elements in the
>>>>> doctree;
>>
>> not [possible] without coupling the publish_doctree methods with the
>> components.Filter transform.  I don't think this is a good idea.
>> publish_* methods shouldn't know about specific transforms.
>
> I agree.  But the components.Filter transform wouldn't be coupled to
> the publish_doctree function.  It will be coupled to the doctree
> reader.  This is a natural fit.

If it were to be coupled to a component, it would probably be the Null
writer (not the Doctree reader) because the Filter transform shall *not*
be executed when running publish_doctree (which uses the Null writer).

This causes the components.Filter transform to appear in two places:
transforms.Transformer and writers.null.Writer.  That's redundant, and
it smells bad, like there's something wrong with the design.

-- 
For private mail please ensure that the header contains 'Felix Wiemann'.

"the number of contributors [...] is strongly and inversely correlated with the
number of hoops each project makes a contributing user go through."      -- ESR