Thread: Re: Cumbersome find dialog
Cream is a free, easy-to-use configuration of the Vim text editor
Brought to you by:
digitect
From: Steve H. <dig...@mi...> - 2004-10-27 22:18:43
|
From: BG - Ben Armstrong, Oct 27, 2004 1:13 PM > On Wed, 2004-10-27 at 18:45 +0200, Thomas de Grenier de Latour wrote: > > > > I tend to agree, I prefer the original gvim find/replace dialog. > > Maybe you should make your users try this tip: > > http://cream.sourceforge.net/faq.html#0210 > > Oh, that is perfect! I don't know how I missed this. > > Losing the regular expression option (which few users would ever use > anyway, I suspect,) is a small price to pay for the increase in ease > of use. In fact, it's just the opposite--Vim's :promptfind and :promptrepl automatically use regular expressions. This means that one backslash character can lead to very damaging consequences for the unsuspecting user. Just open a file and try to replace "\&" with "foo"! I'm concerned the "Use '\\' to find a '\'" suggestion in the title isn't enough warning. With Windows using backslashes as path separators, we could end up with a lot of users subtly corrupting files without knowing. Here's a summary of native Find/Replace dialog difficulties as I see: o The user must read the title and understand the consequence of not escaping backslashes to avoid unknowingly making regular expression edits. o "\n" represents a newline in the find input box but "\r" in the replace one. o Both dialogs loose focus, making repeat keyboard use impossible. o The replace portion of the dialog isn't remembered. o Esc doesn't close the dialog. But I completely agree that Cream's dialogs are horrid, they are my least favorite feature. And there's no way to make it simpler, Vim's input dialogs do not accept multiple buttons or input boxes. I'm willing to reconsider the defaults. But I'd like some feedback on how we might be able to handle these issues or if you don't see them as concerning as I do. -- Steve Hall [ dig...@mi... ] |
From: Steve H. <dig...@mi...> - 2004-10-28 20:08:44
|
From: BG - Ben Armstrong, Oct 28, 2004 2:25 PM > On Wed, 2004-10-27 at 14:13 -0300, BG - Ben Armstrong wrote: > > On Wed, 2004-10-27 at 18:45 +0200, Thomas de Grenier de Latour wrote: > > > > > > I tend to agree, I prefer the original gvim find/replace dialog. > > Oops. I just had one of my pilot users complain that this changes ^F > but doesn't fix the menu entrypoint, which should also point at the > vim dialog. It seems to do that, I would have to override the calls > set up by cream-menu-edit.vim. Is that easily doable in > cream-user.vim too? If so, perhaps the FAQ answer should be amended. You just want to revise the following lines in cream-menu-edit.vim: anoremenu <silent> 20.410 &Edit.&Find\.\.\.<Tab>Ctrl+F :call Cream_find()<CR> anoremenu <silent> 20.420 &Edit.&Replace\.\.\.<Tab>Ctrl+H :call Cream_replace()<CR> to anoremenu <silent> 20.410 &Edit.&Find\.\.\.<Tab>Ctrl+F :promptfind<CR> anoremenu <silent> 20.420 &Edit.&Replace\.\.\.<Tab>Ctrl+H :promptrepl<CR> You can also put these in cream-user to override. And who knows, this might end up in Cream 0.32. :) -- Steve Hall [ digitect mindspring com ] Cream... something good to put in your Vim! http://cream.sourceforge.net |
From: David H. <met...@fa...> - 2004-10-28 20:26:06
|
Steve Hall wrote: *snip* > You can also put these in cream-user to override. And who knows, this > might end up in Cream 0.32. :) *snip* That would be good :) I understand why the new find dialogue is there, but I'm afraid its just a bad idea with Vim's current interface limitations. -d |
From: BG - B. A. <BAr...@dy...> - 2004-10-29 12:14:04
|
On Thu, 2004-10-28 at 16:08 -0400, Steve Hall wrote: > You just want to revise the following lines in cream-menu-edit.vim: ... > anoremenu <silent> 20.410 &Edit.&Find\.\.\.<Tab>Ctrl+F :promptfind<CR> > anoremenu <silent> 20.420 &Edit.&Replace\.\.\.<Tab>Ctrl+H :promptrepl<CR> > > You can also put these in cream-user to override. I did that, but it didn't change the Edit menu. What am I missing? I put these in cream-user.vim along with the ^F and ^H overrides. The key shortcuts worked, but the menu overrides didn't. > And who knows, this > might end up in Cream 0.32. :) That would be nice. Once vim has improved their dialog capabilities, we can return to cream-defined dialogs. But for now, the vim dialogs are definitely preferable. Ben |
From: BG - B. A. <BAr...@dy...> - 2004-10-29 12:25:11
|
On Fri, 2004-10-29 at 09:13 -0300, BG - Ben Armstrong wrote: > I did that, but it didn't change the Edit menu. What am I missing? I > put these in cream-user.vim along with the ^F and ^H overrides. The key > shortcuts worked, but the menu overrides didn't. Bah. Forget it. I cut-and-pasted the wrong two lines. :) But that brings up another point, which I will cover in my next post. Ben |
From: Steve H. <dig...@mi...> - 2004-11-10 17:54:35
|
From: Thomas de Grenier de Latour, Nov 10, 2004 9:53 AM > > Hi all, > > A small update on that find/replace patches status: [...] Thomas, this is great work! Thanks much for taking it on and keeping us up to date. -- Steve Hall [ digitect mindspring com ] Cream... something good to put in your Vim! http://cream.sourceforge.net |
From: Steve H. <dig...@mi...> - 2005-08-15 15:08:29
|
From: BG - Ben Armstrong, Aug 15, 2005 8:30 AM > On Sat, 2005-08-13 at 17:51 -0400, Steve Hall wrote: > > > > In fact, TGL did write a patch or two that accomplished this and a > > few other adjustments to the Find/Replace dialogs. He submitted > > one to the vim-dev list 18 Nov 2004. > [snip] > > In short, I'd like some assurance that in a future release of > Vim+Cream, this functionality is supported.... Cream can make no assurances of what patches are accepted in Vim. If you are interested in this feature, please follow it up on vi...@vi... for us. (I am currently embroiled in enough other issues there--don't want to take up too much bandwidth all by myself.) -- Steve Hall [ digitect mindspring com ] :: Cream... something good to put in your Vim! :: http://cream.sourceforge.net |
From: BG - B. A. <BAr...@dy...> - 2005-08-15 16:51:40
|
On Mon, 2005-08-15 at 11:08 -0400, Steve Hall wrote: > Cream can make no assurances of what patches are accepted in Vim. If > you are interested in this feature, please follow it up on > vi...@vi... for us. (I am currently embroiled in enough other > issues there--don't want to take up too much bandwidth all by myself.) I understand this. I think you misunderstand what I'm looking for. This is a wishlist, not a "must have". I just need to be able to accurately tell my users what the status of the request is. Honestly, I can't say from looking at the mailing list or looking at the code. Perhaps Thomas can clarify, (if indeed he has been following the discussion)? Thomas, I don't know if you're still on cream-general as we haven't heard from you in a while, but I'm wondering what ever came of the find dialog patch to vim in gui.c you submitted to vim-dev in November of last year? I've been asked by my users why we don't have a regular expression checkbox in the find dialog like competing text editors do, and it seems your patch would support the creation of such a checkbox. Ben |
From: Thomas de G. de L. <deg...@ea...> - 2004-10-28 01:00:58
|
On Wed, 27 Oct 2004 18:18:36 -0400 (GMT-04:00) Steve Hall <dig...@mi...> wrote: > In fact, it's just the opposite--Vim's :promptfind and > :promptrepl automatically use regular expressions. Oh, now that I've read the doc, after your reply, i understand. I was also thinking that the :promptfind search was not accepting regexp, because i've always tried to write them using the simplified "magic" syntax, which is the one i'm used to (since it works in the "/" search). But when using the dialog, we are supposed to adopt the "nomagic" syntax (with backslash for all special char, including "." and "*"), because vim does its search with a '\V' in front of the regexp. Ok, now that's clear. Thank you, I've learned something useful :) > o The user must read the title and understand the consequence of > not escaping backslashes to avoid unknowingly making regular > expression edits. That's a problem. Maybe putting a big warning as the default search string (using the :promptfind or :promptrepl optional parameter) would make the users more aware of the risks. I think that's the best place for it to be read. Oh, and sure, there would be an option to disable that behavior and use the previously searched string instead, and that option would be documented as a top FAQ item. > o "\n" represents a newline in the find input box but "\r" in > the replace one. I'm seeing some strange behavior here, with the gvim dialog: when I use the"Replace" button, I get some litteral "\r" string inserted, whereas when I use "Replace All", i get real carriage return. The same happen in plain GVim, so it's either a bug, or again some point of the documentation that I've missed :) > o Both dialogs loose focus, making repeat keyboard use > impossible. I don't see this behavior (linux / gtk2 / sawfish wm). Maybe that is specific to the Windows version, or some other WM? > o The replace portion of the dialog isn't remembered. It is here. Again, maybe that depends on the platform, or toolkit, or vim version? But a difference I see beetween gvim dialogs and cream dialogs is that with the gvim ones I can still edit the file while they are opened, whereas I can't with the cream ones. That's a serious good point for the gvim option, but again, maybe that differs across platforms. > o Esc doesn't close the dialog. Not much an issue imho since there is a shortcut for the Close button. > But I completely agree that Cream's dialogs are horrid, they are > my least favorite feature. And there's no way to make it > simpler, Vim's input dialogs do not accept multiple buttons or > input boxes. Sure, that's some serious limitations... -- TGL. |
From: Steve H. <dig...@mi...> - 2004-10-28 02:49:23
|
On Wed, 2004-10-27 at 21:00, Thomas de Grenier de Latour wrote: > On Wed, 27 Oct 2004 18:18:36 -0400 (GMT-04:00), Steve Hall wrote: > > > > In fact, it's just the opposite--Vim's :promptfind and > > :promptrepl automatically use regular expressions. > > Oh, now that I've read the doc, after your reply, i understand. I > was also thinking that the :promptfind search was not accepting > regexp, because i've always tried to write them using the simplified > "magic" syntax, which is the one i'm used to (since it works in the > "/" search). But when using the dialog, we are supposed to adopt the > "nomagic" syntax (with backslash for all special char, including "." > and "*"), because vim does its search with a '\V' in front of the > regexp. I guess I didn't realize :promptrepl always assumes '\V', no matter how &magic is set. I thought it always used :set magic. Did you find specific mention of this relationship in :help? I've read it somewhere, but can't seem to find it. All this might change my opinion! > Ok, now that's clear. Thank you, I've learned something useful :) That makes two of us. :)) > > o The user must read the title and understand the consequence of > > not escaping backslashes to avoid unknowingly making regular > > expression edits. > > That's a problem. Maybe putting a big warning as the default search > string (using the :promptfind or :promptrepl optional parameter) > would make the users more aware of the risks. I think that's the > best place for it to be read. Oh, and sure, there would be an option > to disable that behavior and use the previously searched string > instead, and that option would be documented as a top FAQ item. It would probably be easier to simply warn the first use. > > o "\n" represents a newline in the find input box but "\r" in the > > replace one. > > I'm seeing some strange behavior here, with the gvim dialog: when I > use the"Replace" button, I get some litteral "\r" string inserted, > whereas when I use "Replace All", i get real carriage return. The > same happen in plain GVim, so it's either a bug, or again some point > of the documentation that I've missed :) I saw that too and forgot to mention it. > > o Both dialogs loose focus, making repeat keyboard use impossible. > > I don't see this behavior (linux / gtk2 / sawfish wm). Maybe that is > specific to the Windows version, or some other WM? Ah, right, on GTK2 it's not a problem. This is a Windows bug. > > o The replace portion of the dialog isn't remembered. > > It is here. Again, maybe that depends on the platform, or toolkit, > or vim version? Yup, another Windows-specific bug. > But a difference I see beetween gvim dialogs and cream dialogs is > that with the gvim ones I can still edit the file while they are > opened, whereas I can't with the cream ones. That's a serious good > point for the gvim option, but again, maybe that differs across > platforms. I think this is caused because the dialog is called via function. Wrapping :promptfind with a function does the same. This is an important subtlety, the maps would have to call the commands directly. > > o Esc doesn't close the dialog. > > Not much an issue imho since there is a shortcut for the Close > button. Actually I find Esc works on GTK2, another Windows bug. > > But I completely agree that Cream's dialogs are horrid, they are > > my least favorite feature. And there's no way to make it > > simpler, Vim's input dialogs do not accept multiple buttons or > > input boxes. > > Sure, that's some serious limitations... But the '\V' behavior is certainly good news, though. Has this always been this way? This is one of the first behaviors Cream worked around, I wonder when it changed. Thanks for following up on these points, this has been a big help. -- Steve Hall [ digitect mindspring com ] |
From: Thomas de G. de L. <deg...@ea...> - 2004-10-28 04:37:11
|
On Wed, 27 Oct 2004 22:49:12 -0400 Steve Hall <dig...@mi...> wrote: > Did you find specific mention of this relationship in :help? No, actually the explanation about :promptfind/:promptrepl are really minimalist in the docs. I understood how it works after reading about the magic/nomagic explanation and doing a few tries, and the source code (function gui_do_find_replace() in src/gui.c) confirmed that a \V is appended in front of the pattern. > It would probably be easier to simply warn the first use. I know that personnaly i don't pay much attention to warnings or tips the first time i try a new program, hence the idea to annoy the user until he get bored enough to start reading the doc. But i have to admit that i have no experience in UI design and things like that, and very likely some of my ideas on the subject would simply make most users run away very fast :) > But the '\V' behavior is certainly good news, though. I think it helps, yes, but issues like your "try to replace \&" example remain. Maybe the best solution would be to kindly ask vim devs to add a "use regexp" checkbox in there dialog (it is probably not much complicated to implement, is it?). > Thanks for following up on these points, this has been a big > help. My pleasure :) -- TGL. |
From: Steve H. <dig...@mi...> - 2004-10-28 11:55:16
|
On Thu, 2004-10-28 at 00:36, Thomas de Grenier de Latour wrote: > On Wed, 27 Oct 2004 22:49:12 -0400 Steve Hall wrote: > > > > But the '\V' behavior is certainly good news, though. > > I think it helps, yes, but issues like your "try to replace \&" > example remain. The user will just have to remember the rule and use '\\&'. > Maybe the best solution would be to kindly ask vim devs to add a > "use regexp" checkbox in there dialog (it is probably not much > complicated to implement, is it?). It would be good, I'll make the suggestion. But I've found that features aren't usually forthcoming without a patch. :) -- Steve Hall [ digitect mindspring com ] Cream... something good to put in your Vim! http://cream.sourceforge.net |
From: Thomas de G. de L. <deg...@ea...> - 2004-10-28 21:36:16
Attachments:
gvim--use_regexp_0.1.patch
|
On Thu, 28 Oct 2004 07:55:02 -0400 Steve Hall <dig...@mi...> wrote: > It would be good, I'll make the suggestion. But I've found that > features aren't usually forthcoming without a patch. :) I've start working on a patch. It somehow seems to work here (vim-6.3, gtk/gtk2 only - don't expect it to work with other toolkits). But actually, I think it is a bit ugly. Random notes: - if "use regexp" is not checked, then all backslashs in the pattern are doubled (but for \n and \t). That part is okay, it is just like in Cream i think. - the problem is on the way back: the pattern that is used when you open the dialog is the last searched pattern (wherever it comes from, / search or dialog search). Sure, if it has been escaped previously a first time from the dialog search, it must be unescaped (or you will get "\" first time you use it, and then reopen the dialog and get "\\", and then "\\\\", etc.). I'm not very confident that the way I've done it will always work. I think that to do that the proper way, there should be a real vim command for "search as plain text". But that would probably be a too deep change for our purpose. - also, I've not yet done anything affecting the replacement text. I don't know exactly what should be done here, should I try to escape it too? (because, despite I've never used that, I see in the doc that it may contain some special substring too, that a user who don't know about regexp probably don't expect). - I really suck at C coding, I can't believe it took me hours for so few lines of code :) So don't hold your breath, it may take me quite some time before I have something acceptable for vim-dev. - I haven't yet looked after the "Replace miss some matches that Replace All gets right" bug, but I will try to fix that too since it is really annoying and is probably somewhere very close to the code I've read and modified today. Anyway, if someone wants to be my alpha tester, my current patch is in attachment. (Oh, and i will be offline next 4 days, so you can take your time before giving feedback) -- TGL. |
From: Steve H. <dig...@mi...> - 2004-11-02 02:36:51
|
On Thu, 2004-10-28 at 17:35, Thomas de Grenier de Latour wrote: > On Thu, 28 Oct 2004 07:55:02 -0400, Steve Hall wrote: > > > > It would be good, I'll make the suggestion. But I've found that > > features aren't usually forthcoming without a patch. :) > > I've start working on a patch. It somehow seems to work here > (vim-6.3, gtk/gtk2 only - don't expect it to work with other > toolkits). Patches like this are what will take Cream to the next level. Thanks for starting this! > But actually, I think it is a bit ugly. Random notes: > - if "use regexp" is not checked, then all backslashs in the > pattern are doubled (but for \n and \t). That part is okay, it > is just like in Cream i think. > - the problem is on the way back: the pattern that is used when > you open the dialog is the last searched pattern (wherever it > comes from, / search or dialog search). Sure, if it has been > escaped previously a first time from the dialog search, it must > be unescaped (or you will get "\" first time you use it, and > then reopen the dialog and get "\\", and then "\\\\", etc.). I'm > not very confident that the way I've done it will always work. I > think that to do that the proper way, there should be a real vim > command for "search as plain text". But that would probably be a > too deep change for our purpose. Actually, I think a plain text search would be very practical. But I'm not even sure Vim can do this. I'll take it up on the Vim list. > - also, I've not yet done anything affecting the replacement > text. I don't know exactly what should be done here, should I > try to escape it too? (because, despite I've never used that, I > see in the doc that it may contain some special substring too, > that a user who don't know about regexp probably don't expect). Yes, this was the idea behind the Cream dialog. There's really no way other than those kind of hacks to avoid unexpected results. (Short of learning regular expressions.) > - I really suck at C coding, I can't believe it took me hours for > so few lines of code :) So don't hold your breath, it may take > me quite some time before I have something acceptable for > vim-dev. That's ok. If you're up for working on it, I'm sure many users would make use of it. > - I haven't yet looked after the "Replace miss some matches that > Replace All gets right" bug, but I will try to fix that too > since it is really annoying and is probably somewhere very close > to the code I've read and modified today. I sent this to Bram, haven't heard back yet. > Anyway, if someone wants to be my alpha tester, my current patch > is in attachment. (Oh, and i will be offline next 4 days, so you > can take your time before giving feedback) I'll give it a go in beta. :) -- Steve Hall [ digitect mindspring com ] Cream... the Vim text editor in sheep's clothing! http://cream.sourceforge.net |
From: Thomas de G. de L. <deg...@ea...> - 2004-11-02 10:34:39
Attachments:
gvim--use_regexp_0.3.1.patch
|
I've done a bit more C homework, and now have a patch that: - escapes the replacement string when "Use regular expressions" is not checked - fixes the "Replace" button behavior ; the problem was that instead of using 's/foo/bar/', the Replace action was using a hack that was not taking regexp into account. That was probably because 's/foo/bar/' always acts on the first match of each line, and thus does not respect the cursor position if there are several matches on a same line. What I've done is that in such case, if a user ask for replacement of "foo" with "bar" and the current line is "foo foo" with cursor in front of the second "foo", the "Replace" button will execute "s/\(^....\)foo/\1bar/". That makes it works both with or without regexp. Known issues with that hack are: * in regexp mode, \X (with X in [1-9]) in the search regexp or in the replacement pattern must be incremented. I did that, but sure, only for [1-8]. So if an expression uses \9, there is a bug. (Bah, anyway, advanced users who write such expressions probably don't use the GUI...) * again in regexp mode, replacement patterns using \=something will break (since '\=' must be first in the pattern, and I add the \1 there). Again, I hope that "GUI is not for that kind of advanced use" is a reasonable assumption. - applies to both the Gtk/Gtk2 and Motif GUIs. The Athena one doesn't need it since it doesnt provides this dialog. For the Windows version, I will first have to manage getting a working Wine+Cygwin setup. But once I've done that, it will hopefully be easy to adapt the patch since the callbacks for the find/replace actions are the same as in other GUIs (thus it should really only be a matter of adding a checkbox in the dialog). -- TGL. |
From: Thomas de G. de L. <deg...@ea...> - 2004-11-02 11:50:00
|
On Tue, 2 Nov 2004 11:34:12 +0100 Thomas de Grenier de Latour <deg...@ea...> wrote: > But once I've done that, it will hopefully be easy to adapt > the patch since the callbacks for the find/replace actions are > the same as in other GUIs (thus it should really only be a > matter of adding a checkbox in the dialog). Oops, I've spoken to fast... The Windows version of the Find/Replace dialogs are standard dialogs, not something created from scratch. So to add the "Use regular expressions" check box, it seems that it is a complete dialog that should be written. I don't think I would be able to do that. The best I can do is to force the "no regexp" mode, but that will be a regression compared to the Cream version of the dialog. -- TGL. |
From: Steve H. <dig...@mi...> - 2004-11-02 12:14:21
|
On Tue, 2004-11-02 at 06:49, Thomas de Grenier de Latour wrote: > On Tue, 2 Nov 2004 11:34:12 +0100, Thomas de Grenier de Latour > wrote: > > > > But once I've done that, it will hopefully be easy to adapt > > the patch since the callbacks for the find/replace actions are > > the same as in other GUIs (thus it should really only be a > > matter of adding a checkbox in the dialog). > > Oops, I've spoken to fast... The Windows version of the > Find/Replace dialogs are standard dialogs, not something created > from scratch. So to add the "Use regular expressions" check box, > it seems that it is a complete dialog that should be written. I > don't think I would be able to do that. The best I can do is to > force the "no regexp" mode, but that will be a regression compared > to the Cream version of the dialog. >From Cream's perspective, a dialog without regexp is not serious, I assume power users can use the command line. It's more important to treat backslashes literally (escaping them and using \V) for the novice user. However, for any chance to get the patch into Vim, I feel sure it would need the regexp option so the Vim user can disable the behavior. Any Windows coders here who want to attempt this dialog? -- Steve Hall [ digitect mindspring com ] Cream... the Vim text editor in sheep's clothing! http://cream.sourceforge.net |
From: Steve H. <dig...@mi...> - 2004-11-02 14:30:11
|
On Tue, 2004-11-02 at 05:34, Thomas de Grenier de Latour wrote: > I've done a bit more C homework, and now have a patch that: > > - escapes the replacement string when "Use regular expressions" > is not checked Works for me. > - fixes the "Replace" button behavior ; the problem was that > instead of using 's/foo/bar/', the Replace action was using a hack > that was not taking regexp into account. That was probably because > 's/foo/bar/' always acts on the first match of each line, and thus > does not respect the cursor position if there are several matches > on a same line. What I've done is that in such case, if a user ask > for replacement of "foo" with "bar" and the current line is > "foo foo" with cursor in front of the second "foo", the "Replace" > button will execute "s/\(^....\)foo/\1bar/". That makes it works > both with or without regexp. Known issues with that hack are: > * in regexp mode, \X (with X in [1-9]) in the search regexp or > in the replacement pattern must be incremented. I did that, but > sure, only for [1-8]. So if an expression uses \9, there is a > bug. (Bah, anyway, advanced users who write such expressions > probably don't use the GUI...) > * again in regexp mode, replacement patterns using \=something > will break (since '\=' must be first in the pattern, and I add > the \1 there). Again, I hope that "GUI is not for that kind of > advanced use" is a reasonable assumption. I wonder if this isn't a separate patch to Vim? > - applies to both the Gtk/Gtk2 and Motif GUIs. The Athena one > doesn't need it since it doesnt provides this dialog. For the > Windows version, I will first have to manage getting a working > Wine+Cygwin setup. But once I've done that, it will hopefully be > easy to adapt the patch since the callbacks for the find/replace > actions are the same as in other GUIs (thus it should really only > be a matter of adding a checkbox in the dialog). I can verify the Gtk, it looks good. Do you think in the end we should enable the two special characters "\n" and "\t" without regexp or does this just confuse things? (I'm now beginning to think it does.) -- Steve Hall [ digitect mindspring com ] Cream... the Vim text editor in sheep's clothing! http://cream.sourceforge.net |
From: BG - B. A. <BAr...@dy...> - 2004-11-02 15:25:26
|
On Tue, 2004-11-02 at 07:13 -0500, Steve Hall wrote: > However, for any chance to get the patch into Vim, I feel sure it > would need the regexp option so the Vim user can disable the > behavior. > > Any Windows coders here who want to attempt this dialog? Sorry, I'm no Windows coder. Since it has been acknowledged that Cream's dialogs are one of the grubbiest bits of cream, and changes like Thomas's patch will take Cream "to the next level" it seems that the Cream project needs a designated Windows GUI coder as part of the team. I rather suspect that an appeal to this list alone isn't going to hook us up with one. Any ideas for how to advertise for one? Usenet comp.editors perhaps? Ben |
From: Christoph H. <em...@ch...> - 2004-11-02 16:35:33
|
On Tue, 2004-11-02 at 11:00 -0400, BG - Ben Armstrong wrote: > Thomas's patch will take Cream "to the next level" it seems that the > Cream project needs a designated Windows GUI coder as part of the > team. > I rather suspect that an appeal to this list alone isn't going to hook > us up with one. Any ideas for how to advertise for one? Usenet > comp.editors perhaps? On SourceForge there is a neat little feature called "Project Help Wanted". I haven't run a project myself there but I was told that the project admin can request help in different categories. Perhaps that's a way to find more people that like to support and contribute to Cream. Cheers Christoph P.S.: No, I don't use Cream on Windows. ;) |
From: Thomas de G. de L. <deg...@ea...> - 2004-11-02 22:28:25
Attachments:
gvim--replace_fix.patch
gvim--use_regexp_0.4.patch
|
On Tue, 02 Nov 2004 09:29:41 -0500 Steve Hall <dig...@mi...> wrote: > I wonder if this isn't a separate patch to Vim? Yes, you're right. I've made the split (see attached files), and I think I will soon submit the first part (the replace fix) upstream. > I can verify the Gtk, it looks good. Cool :) > Do you think in the end we should enable the two special > characters"\n" and "\t" without regexp or does this just confuse > things? (I'm now beginning to think it does.) I'm not really sure neither (that's why the code is still there, but commented). It's handy for people who know how it works, and confusing for people who don't. So my vote goes to leave it as is (commented), and when we submit the patch upstream, let Bram decide :) Thanks for your feedback, -- TGL. |
From: Thomas de G. de L. <deg...@ea...> - 2004-11-10 14:54:09
|
Hi all, A small update on that find/replace patches status: - I've submitted to vim-dev the "Replace" button behavior fix a few days ago, but got no answer so far. The good news is this message: http://marc.theaimsgroup.com/?l=vim&m=109748399907257&w=2 that shows that Bram is aware of the problem, so i think it will get fixed someday, be it with this patch or not. - I've updated the "regexp option" patch. Following your advices, i've removed the comments about making special cases for \n and friends. Another change is that now it won't force the "very nomagic" mode when using regexp, but will follow the current magic option. (I thought that this \V was just useless now that regexp can be completly desactivated, and was a pain to actually search with regexps.) - I've just submitted that new version to vim-dev, asking for help for the Windows port: http://thread.gmane.org/gmane.editors.vim.devel/7868 About that port, I've made no progress but a bit of readings. Something interesting is that it seems that it is possible to extend the vanilla Windows dialogs: http://msdn.microsoft.com/library/en-us/winui/winui/windowsuserinterface/userinput/commondialogboxlibrary/aboutcommondialogboxes/findandreplacedialogboxes.asp But I can't experiment so far. In attachement are latest versions of the two patches, in case someone want to test them a bit more. -- TGL. |
From: BG - B. A. <BAr...@dy...> - 2004-11-03 12:41:26
|
On Tue, 2004-11-02 at 23:28 +0100, Thomas de Grenier de Latour wrote: > On Tue, 02 Nov 2004 09:29:41 -0500 > Steve Hall <dig...@mi...> wrote: > > Do you think in the end we should enable the two special > > characters"\n" and "\t" without regexp or does this just confuse > > things? (I'm now beginning to think it does.) > > I'm not really sure neither (that's why the code is still there, > but commented). It's handy for people who know how it works, and > confusing for people who don't. So my vote goes to leave it as is > (commented), and when we submit the patch upstream, let Bram > decide :) I'm inclined to agree with Steve, that \n and \t should not be enabled because it is too confusing. The default search should be strictly free of characters requiring quoting. The danger of leaving it in the patch, even commented out, is that upstream might think uncommenting it is a cool idea. If we don't think it's what is best for the users, we should just leave it out of the patch. Ben |
From: BG - B. A. <BAr...@dy...> - 2005-08-12 13:25:42
|
On Tue, 2004-11-02 at 07:13 -0500, Steve Hall wrote: > On Tue, 2004-11-02 at 06:49, Thomas de Grenier de Latour wrote: > > Oops, I've spoken to fast... The Windows version of the > > Find/Replace dialogs are standard dialogs, not something created > > from scratch. So to add the "Use regular expressions" check box, > > it seems that it is a complete dialog that should be written. I > > don't think I would be able to do that. The best I can do is to > > force the "no regexp" mode, but that will be a regression compared > > to the Cream version of the dialog. > > >From Cream's perspective, a dialog without regexp is not serious, I > assume power users can use the command line. It's more important to > treat backslashes literally (escaping them and using \V) for the > novice user. > > However, for any chance to get the patch into Vim, I feel sure it > would need the regexp option so the Vim user can disable the > behavior. > > Any Windows coders here who want to attempt this dialog? We would dearly love to have this feature, but so far, nobody with the necessary skills can be found to code it. So I'll ask again: is there anyone who can help with this? Many competing text editors have a regular expressions check box, but ever since we dumped the horrible Cream find dialog in preference for the Vim one, we've been without this valuable feature. In the interim, I've instructed users to use ^O/, but this is a hack. They'll forget, and I'll have to re-explain it several times, and even then, only a fraction of my users will remember (or will ask). The rest of them will just do things less efficiently because they can't get at the feature through the GUI. Ben |
From: Steve H. <dig...@mi...> - 2005-08-13 21:55:49
|
On Fri, 2005-08-12 at 10:22 -0300, BG - Ben Armstrong wrote: > > > On Tue, 2004-11-02 at 06:49, Thomas de Grenier de Latour wrote: > > > > > > Oops, I've spoken to fast... The Windows version of the > > > Find/Replace dialogs are standard dialogs, not something created > > > from scratch. So to add the "Use regular expressions" check box, > > > it seems that it is a complete dialog that should be written. I > > > don't think I would be able to do that. [snip] > So I'll ask again: is there anyone who can help with this? In fact, TGL did write a patch or two that accomplished this and a few other adjustments to the Find/Replace dialogs. He submitted one to the vim-dev list 18 Nov 2004. -- Steve Hall [ digitect mindspring com ] :: Cream... something good to put in your Vim! :: http://cream.sourceforge.net |