Re: [Crawl-ref-discuss] [crawl-ref-commits] (branch: master) updated. 0.6.0-a1-2023-g15849ce

[<jp...@ze...>]

> commit 15849cecaa90e3dba47f0e397db040f162fae3c2
> Author: Adam Borowski <kil...@an...>
> Date:   Wed Jan 6 01:45:16 2010 +0100
>
>     Auto-id rings of regeneration (Vandal).
>
> -----------------------------------------------------------------------
<snip>
> +    case RING_REGENERATION:
> +        // To be exact, bloodless vampires should get the id only after
> they
> +        // drink anything.  Not worth complicating the code, IMHO. [1KB]
> +        if (player_mutation_level(MUT_SLOW_HEALING) < 3)
> +            ident = ID_KNOWN_TYPE;
> +        break;
> +

I'm not convinced. Weren't rings of regeneration changed to have an effect
only if the player is actually regenerating, i.e. has less than full hit
points? Autoidentification could require actually regaining hit points...
Incidentally, should we then autoID rings of hunger as well? (Not sure
that's a good idea but it would make sense, more so than regeneration when
not actually regenerating, in my mind.)

Johanna