[Collective-checkins] r70375 - in bibliograph.parsing/trunk: . bibliograph/parsing bibliograph/parsing/parsers bibliograph/parsing/tests bibliograph/parsing/tests/samples

[Paul B. <svn...@pl...>]

Author: pbugni
Date: Fri Aug 22 22:24:04 2008
New Revision: 70375

Removed:
   bibliograph.parsing/trunk/bibliograph/parsing/parsers/citationmanager.py
   bibliograph.parsing/trunk/bibliograph/parsing/tests/samples/citationmanager_test.txt
   bibliograph.parsing/trunk/bibliograph/parsing/tests/test_citationmanager_parser.py
Modified:
   bibliograph.parsing/trunk/CHANGES.txt
   bibliograph.parsing/trunk/bibliograph/parsing/TODO.txt
   bibliograph.parsing/trunk/bibliograph/parsing/tests/setup.py
   bibliograph.parsing/trunk/bibliograph/parsing/tests/test_endnote_parser.py
   bibliograph.parsing/trunk/bibliograph/parsing/tests/test_medline_parser.py
   bibliograph.parsing/trunk/bibliograph/parsing/tests/test_ris_parser.py
Log:
Removed obsolete/unused 'citation manager' parser

Modified: bibliograph.parsing/trunk/CHANGES.txt
==============================================================================
--- bibliograph.parsing/trunk/CHANGES.txt	(original)
+++ bibliograph.parsing/trunk/CHANGES.txt	Fri Aug 22 22:24:04 2008
@@ -2,3 +2,4 @@
 ==================
 
 - Created package with ZopeSkel
+- Removed obsolete/unused parser: CitationManager

Modified: bibliograph.parsing/trunk/bibliograph/parsing/TODO.txt
==============================================================================
--- bibliograph.parsing/trunk/bibliograph/parsing/TODO.txt	(original)
+++ bibliograph.parsing/trunk/bibliograph/parsing/TODO.txt	Fri Aug 22 22:24:04 2008
@@ -7,7 +7,6 @@
 
 - Tests for all parsers
    [+] bibtex
-   [+] citationmanager
    [x] endnote
    [+] medline
    [x] ris
@@ -30,7 +29,6 @@
   be done, consider a change in return value - boolean isn't adequate if
   we can't tell.
    [X] bibtex
-   [?] citationmanager
    [x] endnote
    [x] medline
    [x] ris
@@ -39,14 +37,6 @@
 Format Issues:
 --------------
 
-- CitationManager doesn't appear to actually have a real file format.  So
-  far as I've been able to ascertain, CitationManager is a system at SFU
-  in Vancouver that stores bib citations in a database.  It allows for
-  export to RefWorks and EndNote, but doesn't appear to have its own internal
-  file format.  I have a hard time believing that this is the citationmanager 
-  referenced by our code here.  
-  (http://citationmanager.lib.sfu.ca/)
-  
 - BibTeX format has an interesting problem.  Our sample files include an entry of type
   'WebPublished', which is not listed anywhere that I can find as a valid entry type for 
   the format.  Should we add it to the list of valid entry types (overriding the published

Modified: bibliograph.parsing/trunk/bibliograph/parsing/tests/setup.py
==============================================================================
--- bibliograph.parsing/trunk/bibliograph/parsing/tests/setup.py	(original)
+++ bibliograph.parsing/trunk/bibliograph/parsing/tests/setup.py	Fri Aug 22 22:24:04 2008
@@ -25,7 +25,5 @@
                                  'bibtex_test_typefield.bib')
 BIBTEX_TEST_CITE_KEY = join(PACKAGE_HOME, 'samples',
                             'bibtex_test_cite_key.bib')
-CITATION_MANAGER_SOURCE = join(PACKAGE_HOME, 'samples', 
-                               'citationmanager_test.txt')
 RIS_SOURCE = join(PACKAGE_HOME, 'samples', 'ris_test.ris')
 ENDNOTE_TEST_SOURCE = join(PACKAGE_HOME, 'samples', 'endnote.end')

Modified: bibliograph.parsing/trunk/bibliograph/parsing/tests/test_endnote_parser.py
==============================================================================
--- bibliograph.parsing/trunk/bibliograph/parsing/tests/test_endnote_parser.py	(original)
+++ bibliograph.parsing/trunk/bibliograph/parsing/tests/test_endnote_parser.py	Fri Aug 22 22:24:04 2008
@@ -65,7 +65,6 @@
     def test_check_format(self):
         s0 = open(setup.ENDNOTE_TEST_SOURCE, 'r').read()
         s1 = open(setup.RIS_SOURCE, 'r').read()
-        s2 = open(setup.CITATION_MANAGER_SOURCE, 'r').read()
         
         self.failUnless(self.parser.checkFormat("%0 \n%A \n%D \n%T "))
         self.failIf(self.parser.checkFormat("%0 \n%A \n%T "))
@@ -73,8 +72,6 @@
                         'Endnote Parser failed to detect Endnote format')
         self.failIf(self.parser.checkFormat(s1), 
                         'Endnote Parser incorrectly accepted RIS format')
-        self.failIf(self.parser.checkFormat(s2), 
-                    'Endnote Parser incorrectly accepted citation manager format')
 
 def test_suite():
     suite = unittest.TestSuite([

Modified: bibliograph.parsing/trunk/bibliograph/parsing/tests/test_medline_parser.py
==============================================================================
--- bibliograph.parsing/trunk/bibliograph/parsing/tests/test_medline_parser.py	(original)
+++ bibliograph.parsing/trunk/bibliograph/parsing/tests/test_medline_parser.py	Fri Aug 22 22:24:04 2008
@@ -35,7 +35,6 @@
     def test_check_format(self):
         s0 = open(setup.MEDLINE_TEST_MED, 'r').read()
         s1 = open(setup.RIS_SOURCE, 'r').read()
-        s2 = open(setup.CITATION_MANAGER_SOURCE, 'r').read()
         s3 = open(setup.ENDNOTE_TEST_SOURCE, 'r').read()
         
         self.failUnless(self.parser.checkFormat("AB  -\nAU  -\nPMID-\nTI  -"))
@@ -43,8 +42,6 @@
                         'Medline Parser failed to detect Medline format')
         self.failIf(self.parser.checkFormat(s1), 
                         'Medline Parser incorrectly accepted RIS format')
-        self.failIf(self.parser.checkFormat(s2), 
-                    'Medline Parser incorrectly accepted citation manager format')
         self.failIf(self.parser.checkFormat(s3), 
                     'Medline Parser incorrectly accepted EndNote format')
 

Modified: bibliograph.parsing/trunk/bibliograph/parsing/tests/test_ris_parser.py
==============================================================================
--- bibliograph.parsing/trunk/bibliograph/parsing/tests/test_ris_parser.py	(original)
+++ bibliograph.parsing/trunk/bibliograph/parsing/tests/test_ris_parser.py	Fri Aug 22 22:24:04 2008
@@ -66,13 +66,13 @@
         parser = RISParser()
         
         s1 = open(setup.RIS_SOURCE, 'r').read()
-        s2 = open(setup.CITATION_MANAGER_SOURCE, 'r').read()
+        s2 = open(setup.ENDNOTE_TEST_SOURCE, 'r').read()
         
         self.failUnless(parser.checkFormat(s1), 'RIS Parser failed to detect RIS format')
-        self.failIf(parser.checkFormat(s2), 'RIS Parser incorrectly detected citation manager format as RIS')
+        self.failIf(parser.checkFormat(s2), 'RIS Parser incorrectly detected EndNote format as RIS')
     
 
 def test_suite():
     suite = unittest.TestSuite([
         unittest.makeSuite(testRISParser),])
-    return suite
\ No newline at end of file
+    return suite