[Canorus-devel] Large Warning Fixes

[Reinhard K. <su...@we...>]

Hi,

As announced a long time ago I finally commited all my changed
to the trunk fixing all the warning with the current gcc
provided by Ubuntu 12.04 Precise Pangolin.

I added a number of warning flags and mark warning as errors so they get
fixed. I did a large work fixing all the warning I got due to that change.
One hope was to find the reason why Canorus crashes on exit. I used the
currently widely spread gcc 4.4.3 (4.4.4/4.5.1 was the latest available at
that time) on Ubuntu 10.04 LTS. 

In August I continued to fix all the warnings occuring with the current
4.6.3 Compiler. 4.7.x is not yet supported but if you use that compiler
and want to fix potential warnings then I'd be glad to integrate your
patch!

Also I tried to integrate duma into Canorus but on start I got an error
happening inside the libfontconfig. Until I know how to ignore depending
libraries Duma support is commented.

I need your help, to look into all the changes I did, as I might have
accidently introduces bugs. Especially places where I added additionally
braces on mixed && and || conditions, but also for return values which were
missing all over the place and lot's of commented unused variables that must
have had some intended use in the head of the developer :-)

See the attachment for the complete list. Every file I checked in with the
comment from the list including "Large Warning Fixes", so it's easy to
identify.

Kind regards,

Reinhard Katzmann
-- 
Software-Engineer, Department Application Development
Project: Canorus - The music score editor
http://www.canorus.org
GnuPG Public Key available on request