Thread: Re: [Audacity-devel] 1.3.5 release? (Page 2)
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Vaughan J. <va...@au...> - 2008-05-06 23:28:51
|
Figured out a fix to the other ESC problems (prefs, ladspa, vst), which is to change CreateStdButtonSizer() to make the OK button not only the default, but SetFocus() on it. Drawback is that, e.g., in Preferences, the categories wxTreebook on the left is no longer under immediate keyboard control -- you have to tab from OK to Cancel to that control. Also, if you are in the category wxTreebook, ESC doesn't work (but ENTER for OK does work). So, is that preferable to having the category control act as 1st in keyboard control order? I think so, and it doesn't matter as much for the plugins. Will work on other stuff in the meantime, but if no objections, will commit this in a few hours. - V |
From: Martyn S. <mar...@go...> - 2008-05-07 00:37:36
|
Hi Vaughan Does this actually fix anything much? OK, Esc will work when you first call up the dialog (since you are focused on the buttons), but does it still work when you tab through to the GVerb sliders? Not here, but maybe I didn't understand you and made a different change. It looks like a change to many dialogs in order to make a couple function better. I think I'd rather see it left as it is. Since wxScrolledWindow didn't seem to be behaving its self, I've been trying to add a 'ConnectEsc' in a similar way to 'ConnectFocus' to LadspaEffect, without success. I tried adding it to wxSizer *paramSizer and to wxScrolledWindow *w but it doesn't seem to get hit, but I'm very much a novice at these things. TTFN Martyn void LadspaEffectDialog::ConnectEsc(wxSizer *c) { c->GetEventHandler()->Connect(wxID_CANCEL, wxCommandEventHandler(LadspaEffectDialog::OnCancel)); } Vaughan Johnson wrote: > Figured out a fix to the other ESC problems (prefs, ladspa, vst), which > is to change CreateStdButtonSizer() to make the OK button not only the > default, but SetFocus() on it. > > Drawback is that, e.g., in Preferences, the categories wxTreebook on the > left is no longer under immediate keyboard control -- you have to tab > from OK to Cancel to that control. Also, if you are in the category > wxTreebook, ESC doesn't work (but ENTER for OK does work). > > So, is that preferable to having the category control act as 1st in > keyboard control order? I think so, and it doesn't matter as much for > the plugins. Will work on other stuff in the meantime, but if no > objections, will commit this in a few hours. > > - V > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference > Don't miss this year's exciting event. There's still time to save $100. > Use priority code J8TL2D2. > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone > _______________________________________________ > Audacity-devel mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Vaughan J. <va...@au...> - 2008-05-07 02:13:17
|
Martyn Shaw wrote: > Hi Vaughan > > Does this actually fix anything much? OK, Esc will work when you > first call up the dialog (since you are focused on the buttons), but > does it still work when you tab through to the GVerb sliders? Not > here, but maybe I didn't understand you and made a different change. > Nope, but I think this will significantly help VI users, for whom I think the ESC capability is most important. They can at least bail out when it opens if this is in. I think it's a worthwhile fix for now, but that for a full fix it's probably necessary to restructure these dialogs such that OK and Cancel are at the top level of the sizer structure and all the tabs and subordinate controls funnel up to them rather than the dialog/frame/window itself. > It looks like a change to many dialogs in order to make a couple > function better. I think I'd rather see it left as it is. > Any obvious likely harm to the other dialogs built using CreateStdButtonSizer()? > Since wxScrolledWindow didn't seem to be behaving its self, I've been > trying to add a 'ConnectEsc' in a similar way to 'ConnectFocus' to > LadspaEffect, without success. I tried adding it to wxSizer > *paramSizer and to wxScrolledWindow *w but it doesn't seem to get hit, > but I'm very much a novice at these things. > > TTFN > Martyn > > void LadspaEffectDialog::ConnectEsc(wxSizer *c) > { > c->GetEventHandler()->Connect(wxID_CANCEL, > > wxCommandEventHandler(LadspaEffectDialog::OnCancel)); > } > Yes, there seem to be lots of paths through this stuff, to do the same thing. I've tried a bunch of EVT_KEY_DOWN and EVT_CHAR events to catch some of these keyboard things, and many never get invoked. I still think it's worth committing. Heck, for ~3 weeks to 1.3.6, we can try it out. - V > > Vaughan Johnson wrote: > >> Figured out a fix to the other ESC problems (prefs, ladspa, vst), which >> is to change CreateStdButtonSizer() to make the OK button not only the >> default, but SetFocus() on it. >> >> Drawback is that, e.g., in Preferences, the categories wxTreebook on the >> left is no longer under immediate keyboard control -- you have to tab >> from OK to Cancel to that control. Also, if you are in the category >> wxTreebook, ESC doesn't work (but ENTER for OK does work). >> >> So, is that preferable to having the category control act as 1st in >> keyboard control order? I think so, and it doesn't matter as much for >> the plugins. Will work on other stuff in the meantime, but if no >> objections, will commit this in a few hours. >> >> - V >> >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference >> Don't miss this year's exciting event. There's still time to save $100. >> Use priority code J8TL2D2. >> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone >> _______________________________________________ >> Audacity-devel mailing list >> Aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> >> > > ------------------------------------------------------------------------- > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference > Don't miss this year's exciting event. There's still time to save $100. > Use priority code J8TL2D2. > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone > _______________________________________________ > Audacity-devel mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > |
From: Martyn S. <mar...@go...> - 2008-05-07 23:44:08
|
Hi Vaughan You have fixed heaps recently, some of which I've looked at for ages. Thanks! :-) Martyn Vaughan Johnson wrote: > Martyn Shaw wrote: >> Hi Vaughan >> >> Does this actually fix anything much? OK, Esc will work when you >> first call up the dialog (since you are focused on the buttons), but >> does it still work when you tab through to the GVerb sliders? Not >> here, but maybe I didn't understand you and made a different change. >> > Nope, but I think this will significantly help VI users, for whom I > think the ESC capability is most important. They can at least bail out > when it opens if this is in. > > I think it's a worthwhile fix for now, but that for a full fix it's > probably necessary to restructure these dialogs such that OK and Cancel > are at the top level of the sizer structure and all the tabs and > subordinate controls funnel up to them rather than the > dialog/frame/window itself. Fair enough, and there's not enough time to do everything. I don't think I saw any structural difference between LadspaEffectDialog and Amplify, however. >> It looks like a change to many dialogs in order to make a couple >> function better. I think I'd rather see it left as it is. >> > Any obvious likely harm to the other dialogs built using > CreateStdButtonSizer()? Apart from the focus being different now when you open them? Amplify for example used to have the 'Amplification (dB):' text box focused on, now it's the OK button. Not a big issue but quite a visible one. >> Since wxScrolledWindow didn't seem to be behaving its self, I've been >> trying to add a 'ConnectEsc' in a similar way to 'ConnectFocus' to >> LadspaEffect, without success. I tried adding it to wxSizer >> *paramSizer and to wxScrolledWindow *w but it doesn't seem to get hit, >> but I'm very much a novice at these things. >> >> TTFN >> Martyn >> >> void LadspaEffectDialog::ConnectEsc(wxSizer *c) >> { >> c->GetEventHandler()->Connect(wxID_CANCEL, >> >> wxCommandEventHandler(LadspaEffectDialog::OnCancel)); >> } >> > Yes, there seem to be lots of paths through this stuff, to do the same > thing. I've tried a bunch of EVT_KEY_DOWN and EVT_CHAR events to catch > some of these keyboard things, and many never get invoked. Same here. I still think the problem relates to wxScrolledWindow. We only have 3 of these in Audacity, in LadspaEffect, VampEffect and ShuttleGui. The ShuttleGui one is used in Tags and escapes just fine, without your changes. Maybe that's the way to go with any restructuring? > I still think it's worth committing. Heck, for ~3 weeks to 1.3.6, we can > try it out. > > - V I guess it's done now! And as you say, for 3 weeks... Hey, you have fixed heaps of things recently, some of which I've looked at for ages. Thanks! :-) TTFN Martyn >> >> Vaughan Johnson wrote: >> >>> Figured out a fix to the other ESC problems (prefs, ladspa, vst), >>> which is to change CreateStdButtonSizer() to make the OK button not >>> only the default, but SetFocus() on it. >>> >>> Drawback is that, e.g., in Preferences, the categories wxTreebook on >>> the left is no longer under immediate keyboard control -- you have to >>> tab from OK to Cancel to that control. Also, if you are in the >>> category wxTreebook, ESC doesn't work (but ENTER for OK does work). >>> >>> So, is that preferable to having the category control act as 1st in >>> keyboard control order? I think so, and it doesn't matter as much for >>> the plugins. Will work on other stuff in the meantime, but if no >>> objections, will commit this in a few hours. >>> >>> - V >>> >>> >>> ------------------------------------------------------------------------- >>> >>> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference >>> Don't miss this year's exciting event. There's still time to save >>> $100. Use priority code J8TL2D2. >>> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone >>> >>> _______________________________________________ >>> Audacity-devel mailing list >>> Aud...@li... >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>> >>> >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference >> Don't miss this year's exciting event. There's still time to save >> $100. Use priority code J8TL2D2. >> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone >> >> _______________________________________________ >> Audacity-devel mailing list >> Aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> >> > |
From: Vaughan J. <va...@au...> - 2008-05-08 00:01:15
|
Wow, thanks, Martyn. Thanks to you, too! - V Martyn Shaw wrote: > Hi Vaughan > > You have fixed heaps recently, some of which I've looked at for ages. > Thanks! :-) > > Martyn > > Vaughan Johnson wrote: > >> Martyn Shaw wrote: >> >>> Hi Vaughan >>> >>> Does this actually fix anything much? OK, Esc will work when you >>> first call up the dialog (since you are focused on the buttons), but >>> does it still work when you tab through to the GVerb sliders? Not >>> here, but maybe I didn't understand you and made a different change. >>> >>> >> Nope, but I think this will significantly help VI users, for whom I >> think the ESC capability is most important. They can at least bail out >> when it opens if this is in. >> >> I think it's a worthwhile fix for now, but that for a full fix it's >> probably necessary to restructure these dialogs such that OK and Cancel >> are at the top level of the sizer structure and all the tabs and >> subordinate controls funnel up to them rather than the >> dialog/frame/window itself. >> > > Fair enough, and there's not enough time to do everything. > > I don't think I saw any structural difference between > LadspaEffectDialog and Amplify, however. > > >>> It looks like a change to many dialogs in order to make a couple >>> function better. I think I'd rather see it left as it is. >>> >>> >> Any obvious likely harm to the other dialogs built using >> CreateStdButtonSizer()? >> > > Apart from the focus being different now when you open them? Amplify > for example used to have the 'Amplification (dB):' text box focused > on, now it's the OK button. Not a big issue but quite a visible one. > > >>> Since wxScrolledWindow didn't seem to be behaving its self, I've been >>> trying to add a 'ConnectEsc' in a similar way to 'ConnectFocus' to >>> LadspaEffect, without success. I tried adding it to wxSizer >>> *paramSizer and to wxScrolledWindow *w but it doesn't seem to get hit, >>> but I'm very much a novice at these things. >>> >>> TTFN >>> Martyn >>> >>> void LadspaEffectDialog::ConnectEsc(wxSizer *c) >>> { >>> c->GetEventHandler()->Connect(wxID_CANCEL, >>> >>> wxCommandEventHandler(LadspaEffectDialog::OnCancel)); >>> } >>> >>> >> Yes, there seem to be lots of paths through this stuff, to do the same >> thing. I've tried a bunch of EVT_KEY_DOWN and EVT_CHAR events to catch >> some of these keyboard things, and many never get invoked. >> > > Same here. I still think the problem relates to wxScrolledWindow. We > only have 3 of these in Audacity, in LadspaEffect, VampEffect and > ShuttleGui. The ShuttleGui one is used in Tags and escapes just fine, > without your changes. Maybe that's the way to go with any restructuring? > > >> I still think it's worth committing. Heck, for ~3 weeks to 1.3.6, we can >> try it out. >> >> - V >> > > I guess it's done now! And as you say, for 3 weeks... > > Hey, you have fixed heaps of things recently, some of which I've > looked at for ages. Thanks! :-) > > TTFN > Martyn > > >>> Vaughan Johnson wrote: >>> >>> >>>> Figured out a fix to the other ESC problems (prefs, ladspa, vst), >>>> which is to change CreateStdButtonSizer() to make the OK button not >>>> only the default, but SetFocus() on it. >>>> >>>> Drawback is that, e.g., in Preferences, the categories wxTreebook on >>>> the left is no longer under immediate keyboard control -- you have to >>>> tab from OK to Cancel to that control. Also, if you are in the >>>> category wxTreebook, ESC doesn't work (but ENTER for OK does work). >>>> >>>> So, is that preferable to having the category control act as 1st in >>>> keyboard control order? I think so, and it doesn't matter as much for >>>> the plugins. Will work on other stuff in the meantime, but if no >>>> objections, will commit this in a few hours. >>>> >>>> - V >>>> >>>> >>>> ------------------------------------------------------------------------- >>>> >>>> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference >>>> Don't miss this year's exciting event. There's still time to save >>>> $100. Use priority code J8TL2D2. >>>> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone >>>> >>>> _______________________________________________ >>>> Audacity-devel mailing list >>>> Aud...@li... >>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>>> >>>> >>>> >>> ------------------------------------------------------------------------- >>> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference >>> Don't miss this year's exciting event. There's still time to save >>> $100. Use priority code J8TL2D2. >>> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone >>> >>> _______________________________________________ >>> Audacity-devel mailing list >>> Aud...@li... >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>> >>> >>> > > ------------------------------------------------------------------------- > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference > Don't miss this year's exciting event. There's still time to save $100. > Use priority code J8TL2D2. > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone > _______________________________________________ > Audacity-devel mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > |
From: Vaughan J. <va...@au...> - 2008-05-08 00:02:28
|
...and to everybody else who's done so much for this release, GSoC, and Audacity in general lately! Vaughan Johnson wrote: > Wow, thanks, Martyn. Thanks to you, too! - V > |
From: Martyn S. <mar...@go...> - 2008-05-06 23:55:19
|
Hi Vaughan In LadspaEffect.cpp I (locally) changed the wxScrolledWindow for a wxWindow and ESC behaviour was restored (all the layout was mucked up though). So the 'wx no longer passing key events up to the dialog' explanation seems good, in this case wxScrolledWindow. I agree with your later post, this shouldn't hold up a release. Martyn Vaughan Johnson wrote: > Update on ESC issues : > > * oldies (Analyze > Plot Spectrum, Help > Index, Help > Run > Benchmark) all fixed and committed. > > * new, due to wx 2.6.4: > o edit > preferences and effec > (LADSPA f/x): Don't know why > they're not handling ESC as wxID_CANCEL, which button ID > fixed two of the oldies. Maybe something due to the > indirection of CreateStdButtonSizer or wx no longer passing > key events up to the dialog? If you tab to any of the > buttons in those dialogs (OK or Cancel , or Preview for > LADSPA), then ESC works as cancel. > o I've got to hit the sack, but I suspect the VST dialogs show > the same, i.e., tab to any button and ESC will work as cancel. > > Posted a Windows rc6 with these fixes and latest from HEAD, > http://audacity.sourceforge.net/files/audacity-win-unicode-1.3.5-rc6.exe . > > - Vaughan > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference > Don't miss this year's exciting event. There's still time to save $100. > Use priority code J8TL2D2. > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone > _______________________________________________ > Audacity-devel mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: David B. <drb...@go...> - 2008-05-06 10:12:26
|
Hi, On Mon, May 5, 2008 at 9:31 PM, Gale Andrews <ga...@au...> wrote: > I also think we have (entirely due to wx2.6.4 as it works in 2.6.3): > > * Spin-boxes and Metadata Editor table no longer work properly with > screen readers. Screen readers can read the spin boxes and table in the metadata editor in the recent builds. I think the problem was fixed when the accessibility flag was set. (window eyes can't read the table in the metadata editor, but that's an old problem) David. |
From: Gale A. <ga...@au...> - 2008-05-06 17:40:08
|
| From "David Bailes" <drb...@go...> | Tue, 6 May 2008 11:12:26 +0100 | Subject: [Audacity-devel] 1.3.5 release? > On Mon, May 5, 2008 at 9:31 PM, Gale Andrews <ga...@au...> wrote: > > I also think we have (entirely due to wx2.6.4 as it works in 2.6.3): > > > > * Spin-boxes and Metadata Editor table no longer work properly with > > screen readers. > > Screen readers can read the spin boxes and table in the metadata > editor in the recent builds. I think the problem was fixed when the > accessibility flag was set. (window eyes can't read the table in the > metadata editor, but that's an old problem) Thanks for re-confirming. I can see you said that now about Vaughan's 1.3.5rc builds. What was partly confusing me was that Leland had appeared to say (unless I misunderstood) that reading wasn't working for him even with accessibility set. The README currently does suggest screen reading problems are due to wx2.6.4, so I'll correct that. Thanks Gale |