Thread: [Audacity-devel] Metadata editor, missing import of FLAC and OGG data, and 1.4.0
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Leland <le...@au...> - 2007-07-29 02:10:09
|
Hi folks, A while a go I worked on adding the missing import of FLAC and OGG metadata. Unfortunately as is usual for me, it got away from me and I took it a bit further than that by moving all of the importing/exporting code from Tags.cpp to the individual Export*/Import* classes where I felt they fit better. This made the Tags class generic and kept the file type specific metadata code in with the other file type specific import/export code. I also re-did the Metadata editor with a standard dialog. Gale and I worked on a couple of layouts for this. I still have one more layout to go so we can all get a feel for how each works and choose the more appropriate one. Along the way, I also corrected a few things like memory leaks, proper handling of MP3 unicode tags, WAV file metadata import/export, FLAC import, and OGG import. So, the question is, can I commit the changes? I know it's beyond the "fix only" mode we're in, but it actually does fix a few things. :-) For you Windows user, you can try the first 2 examples of the metadata editor here: http://homerow.net/audacity/audacity-win-unicode-grid-metadata.zip http://homerow.net/audacity/audacity-win-unicode-tabbed-metadata.zip And I'll try to get the third example done tonight or tomorrow. Leland |
From: Leland <le...@au...> - 2007-07-29 02:13:36
|
Oh yea...I forgot about the new genre editor. Leland On 7/28/07 9:10 PM, "Leland" <le...@au...> wrote: > Hi folks, > > A while a go I worked on adding the missing import of FLAC and OGG metadata. > > Unfortunately as is usual for me, it got away from me and I took it a bit > further than that by moving all of the importing/exporting code from > Tags.cpp to the individual Export*/Import* classes where I felt they fit > better. This made the Tags class generic and kept the file type specific > metadata code in with the other file type specific import/export code. > > I also re-did the Metadata editor with a standard dialog. Gale and I worked > on a couple of layouts for this. I still have one more layout to go so we > can all get a feel for how each works and choose the more appropriate one. > > Along the way, I also corrected a few things like memory leaks, proper > handling of MP3 unicode tags, WAV file metadata import/export, FLAC import, > and OGG import. > > So, the question is, can I commit the changes? I know it's beyond the "fix > only" mode we're in, but it actually does fix a few things. :-) > > For you Windows user, you can try the first 2 examples of the metadata > editor here: > > http://homerow.net/audacity/audacity-win-unicode-grid-metadata.zip > http://homerow.net/audacity/audacity-win-unicode-tabbed-metadata.zip > > And I'll try to get the third example done tonight or tomorrow. > > Leland > > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Audacity-devel mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Richard A. <ri...@au...> - 2007-07-29 22:07:52
|
On Sat, 2007-07-28 at 21:10 -0500, Leland wrote: > Unfortunately as is usual for me, it got away from me and I took it a bit > further than that by moving all of the importing/exporting code from > Tags.cpp to the individual Export*/Import* classes where I felt they fit > better. This made the Tags class generic and kept the file type specific > metadata code in with the other file type specific import/export code. Right now Tags.cpp doesn't compile for me Tags.cpp: In member function ‘void TagsEditor::BuildExtraPanel()’: Tags.cpp:1377: error: ‘eCancelButton’ was not declared in this scope Tags.cpp:1377: error: ‘eOkButton’ was not declared in this scope Tags.cpp:1377: error: ‘CreateStdButtonSizer’ was not declared in this scope Using current CVS and WX 2.6.3 under Linux (GTK2, Unicode). Richard |
From: Martyn S. <Mar...@ao...> - 2007-07-30 20:16:29
|
Richard Sorry, my fault. Looks like Leland's got there before me and fixed it. Martyn Richard Ash wrote: ... > Right now Tags.cpp doesn't compile for me > > Tags.cpp: In member function ‘void TagsEditor::BuildExtraPanel()’: > Tags.cpp:1377: error: ‘eCancelButton’ was not declared in this scope > Tags.cpp:1377: error: ‘eOkButton’ was not declared in this scope > Tags.cpp:1377: error: ‘CreateStdButtonSizer’ was not declared in this scope > > Using current CVS and WX 2.6.3 under Linux (GTK2, Unicode). > > Richard > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Audacity-devel mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: David B. <drb...@go...> - 2007-07-30 12:55:51
|
Hi Leland, from the standpoint of an innocent bystander, the tabbed version looks less forbiding than the grid version. Just one or two issues with the keyboard navigation... - In the table for extended metadata, if you press F2 to edit, and then press either ESC to cancel or ENTER to confirm the edit, you exit the editor rather than the edit. - In the tabbed version: when you open the editor or after pressing CTRL + TAB to change pages, the focus is on the tab, rather than the first control of the page. - In the tabbed version: if the focus is on either the clear, ok or cancel buttons and you press CTRL + TAB, the focus moves to the next control rather than the other page. David. On 7/29/07, Leland <le...@au...> wrote: > Hi folks, > > A while a go I worked on adding the missing import of FLAC and OGG metadata. > > Unfortunately as is usual for me, it got away from me and I took it a bit > further than that by moving all of the importing/exporting code from > Tags.cpp to the individual Export*/Import* classes where I felt they fit > better. This made the Tags class generic and kept the file type specific > metadata code in with the other file type specific import/export code. > > I also re-did the Metadata editor with a standard dialog. Gale and I worked > on a couple of layouts for this. I still have one more layout to go so we > can all get a feel for how each works and choose the more appropriate one. > > Along the way, I also corrected a few things like memory leaks, proper > handling of MP3 unicode tags, WAV file metadata import/export, FLAC import, > and OGG import. > > So, the question is, can I commit the changes? I know it's beyond the "fix > only" mode we're in, but it actually does fix a few things. :-) > > For you Windows user, you can try the first 2 examples of the metadata > editor here: > > http://homerow.net/audacity/audacity-win-unicode-grid-metadata.zip > http://homerow.net/audacity/audacity-win-unicode-tabbed-metadata.zip > > And I'll try to get the third example done tonight or tomorrow. > > Leland > > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Audacity-devel mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Leland <le...@au...> - 2007-07-30 13:05:48
|
Thanks David. Seems I need to deal with that ESC and ENTER problem in general and I prefer the tabbed version too. Leland On 7/30/07 7:55 AM, "David Bailes" <drb...@go...> wrote: > Hi Leland, > > from the standpoint of an innocent bystander, the tabbed version looks > less forbiding than the grid version. > > Just one or two issues with the keyboard navigation... > > - In the table for extended metadata, if you press F2 to edit, and > then press either ESC to cancel or ENTER to confirm the edit, you exit > the editor rather than the edit. > > - In the tabbed version: when you open the editor or after pressing > CTRL + TAB to change pages, the focus is on the tab, rather than the > first control of the page. > > - In the tabbed version: if the focus is on either the clear, ok or > cancel buttons and you press CTRL + TAB, the focus moves to the next > control rather than the other page. > > David. > > > On 7/29/07, Leland <le...@au...> wrote: >> Hi folks, >> >> A while a go I worked on adding the missing import of FLAC and OGG metadata. >> >> Unfortunately as is usual for me, it got away from me and I took it a bit >> further than that by moving all of the importing/exporting code from >> Tags.cpp to the individual Export*/Import* classes where I felt they fit >> better. This made the Tags class generic and kept the file type specific >> metadata code in with the other file type specific import/export code. >> >> I also re-did the Metadata editor with a standard dialog. Gale and I worked >> on a couple of layouts for this. I still have one more layout to go so we >> can all get a feel for how each works and choose the more appropriate one. >> >> Along the way, I also corrected a few things like memory leaks, proper >> handling of MP3 unicode tags, WAV file metadata import/export, FLAC import, >> and OGG import. >> >> So, the question is, can I commit the changes? I know it's beyond the "fix >> only" mode we're in, but it actually does fix a few things. :-) >> >> For you Windows user, you can try the first 2 examples of the metadata >> editor here: >> >> http://homerow.net/audacity/audacity-win-unicode-grid-metadata.zip >> http://homerow.net/audacity/audacity-win-unicode-tabbed-metadata.zip >> >> And I'll try to get the third example done tonight or tomorrow. >> >> Leland >> >> >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by: Splunk Inc. >> Still grepping through log files to find problems? Stop. >> Now Search log events and configuration files using AJAX and a browser. >> Download your FREE copy of Splunk now >> http://get.splunk.com/ >> _______________________________________________ >> Audacity-devel mailing list >> Aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Audacity-devel mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Gale A. <ga...@au...> - 2007-07-31 01:25:44
|
| From Leland <le...@au...> | Mon, 30 Jul 2007 08:05:50 -0500 | Subject: [Audacity-devel] Metadata editor, missing import of FLAC and | OGG data, and 1.4.0 OK so I make that 3 votes for the "tabbed" so far and none for the "grid". But I really don't like either as Leland knows. Both look like the Control Panel of an interplanetary space station to me because of the size :-). The grid version probably looks worse because of the big vacant space in the extended metadata - for me that catches the eye so much that I find it very difficult to focus at the top which is more important. I would simply find it too much eyestrain to use for long (given I am not personally interested in extra fields). In the tabbed version, when you click "Add" and type, nothing happens because the focus is not in the field. I simply don't think this tabbed concept will work well - it's just too confusing to add a field in "advanced" and have to keep tabbing back and forth to see what's there. Try using this a lot in a hurry and it will become exasperating. I think the fundamental problem with both is the extravagant use of space (again, Leland knows my views and I've made a number of suggestions to save five or so lines of space) - enough in my view for any reasonable number of extra lines of metadata that most users will want. That is, unless we are forward planning here to leave enough space for CART and Broadcast WAV data? Leland, is your upcoming third version something along the lines I was suggesting (i.e. simply a grid, and no scrolling extra panel for the extended metadata) or what is in your mind? The fact is that the space taken for that panel itself takes up valuable space that could be used just for plain rows of fields. My fundamental objection to the old roll down for the extended data was partly that you could not make it appear at all unless your mouse was in the right place (and so because "Done" was in the roll down you could not then complete the editor without using a mouse); and because the rolldown would not remember if the user wanted to see it or not. Also I believe for reasons of getting the eyeballs on the thing, it must not be significantly taller than the current "roll down" version (when rolled down). With good design (including removing the ID3v1 choice which I think we are agreed on, unless someone objects), I think you could actually get a dozen fields in for barely more height than the current rolled down version. If we must have more (which I seriously question looking at other apps), then I suggest a slide-out (probably to left) as long as once the user has decided they want it, it always appears until they decide otherwise. Gale Outbound message virus free. Tested on: 7/31/2007 2:25:44 AM |
From: Gale A. <ga...@au...> - 2007-07-31 23:53:47
|
| From Gale Andrews <ga...@au...> | Tue, 31 Jul 2007 02:25:44 +0100 | Subject: [Audacity-devel] Metadata editor, missing import of FLAC | and OGG data, and 1.4.0 Hi I am now looking at Leland's third version of the editor where we try and fill the window with the rows we need, without tabbing and without a scrolling internal window: http://homerow.net/audacity/audacity-win-unicode-1.3.3-meta.zip Now this is at least better (IMHO). I'd suggest Track No. and Year should go underneath "Album", and (unless there is a restriction) Genre goes underneath Track No. and Year. I don't know if we are forced into having the "General" panel, if not, that could go, which would save a little height. I think this version is practical where the other two aren't. Anyone else here that uses MP3 a lot ? What about the height of the fields? Is this forced by wxWidgets? Do we need the width e.g. the gap between the left edge of the fields and the text? Or how about moving the Edit button to left of the Genre field, so we can shorten the un-necessary width of the Copyright and Year fields? Otherwise I can't myself see any more that could be done with the layout to conserve height, unless we can make a grid like Foobar's that has no spaces between the fields. Here is the Foobar Metadata editor: http://www.gaclrecords.org.uk/meta1.png http://www.gaclrecords.org.uk/meta2.png I certainly don't hold out Foobar as likely to win any aesthetic awards but I think this is more like what we want; note the spacesaving idea of having the Comment field expand when you click on it. I'm not advocating the Properties tab either (as part of the Metadata Editor, anyway). Gale Outbound message virus free. Tested on: 8/1/2007 12:53:47 AM |
From: Gale A. <ga...@au...> - 2007-07-31 23:57:55
|
| From Gale Andrews <ga...@au...> | Wed, 01 Aug 2007 00:53:46 +0100 | Subject: [Audacity-devel] Metadata editor, missing import of FLAC and | OGG data, and 1.4.0 BTW there is a 100% replicable crash on pressing OK on this third version of the Metadata Editor (http://homerow.net/audacity/audacity-win-unicode-1.3.3-meta.zip) Gale Outbound message virus free. Tested on: 8/1/2007 12:57:56 AM |
From: Leland <le...@au...> - 2007-08-01 02:24:42
|
On 7/31/07 6:57 PM, "Gale Andrews" <ga...@au...> wrote: > > | From Gale Andrews <ga...@au...> > | Wed, 01 Aug 2007 00:53:46 +0100 > | Subject: [Audacity-devel] Metadata editor, missing import of FLAC and > | OGG data, and 1.4.0 > > BTW there is a 100% replicable crash on pressing OK on this third > version of the Metadata Editor > (http://homerow.net/audacity/audacity-win-unicode-1.3.3-meta.zip) > Absoultely. It's not at all complete. I'd just put it up to get an idea of looks and layout. Leland |
From: Leland <le...@au...> - 2007-08-01 03:28:33
|
On 7/31/07 6:53 PM, "Gale Andrews" <ga...@au...> wrote: > Otherwise I can't myself see any more that could be done with the layout to > conserve height, unless we can make a grid like Foobar's that has no > spaces between the fields. Here is the Foobar Metadata editor: > http://www.gaclrecords.org.uk/meta1.png > http://www.gaclrecords.org.uk/meta2.png > > I certainly don't hold out Foobar as likely to win any aesthetic awards but > I think this is more like what we want; note the spacesaving idea of having > the Comment field expand when you click on it. I'm not advocating the > Properties tab either (as part of the Metadata Editor, anyway). > You mean you're okay with a grid format? Well heck, why didn't you say so. That'd be easy to do. And I could even make the first 5 or so lines "static" they they always contain the standard MP3 fields (like Foobar does). Although, I did think the tabbed display provided more room for extensions like for broadcast wav info, which doesn't really lend itself to a grid design as it needs some pretty special field formats. Leland |
From: Gale A. <ga...@au...> - 2007-08-01 05:37:01
|
=2E | From Leland <le...@au...>=20 | Tue, 31 Jul 2007 22:28:20 -0500 | Subject: [Audacity-devel] Metadata editor, missing import of FLAC | and OGG data, and 1.4.0 | On 7/31/07 6:53 PM, "Gale Andrews" <ga...@au...> wrote: | > Otherwise I can't myself see any more that could be done with the l= ayout to | > conserve height, unless we can make a grid like Foobar's that has n= o | > spaces between the fields. Here is the Foobar Metadata editor: | > http://www.gaclrecords.org.uk/meta1.png | > http://www.gaclrecords.org.uk/meta2.png | >=20 | > I certainly don't hold out Foobar as likely to win any aesthetic aw= ards but | > I think this is more like what we want; note the spacesaving idea o= f having | > the Comment field expand when you click on it. I'm not advocating t= he | > Properties tab either (as part of the Metadata Editor, anyway). | >=20 | You mean you're okay with a grid format? Well heck, why didn't you s= ay so. I did say I was "OK" with a grid Leland, that was the point of pushing you = for=20 a third mockup - I mentioned Foobar before for this very reason - I think y= ou=20 may have lost some emails somewhere :-) .. That does not mean I especially like the look of the grid, though.=20 | That'd be easy to do. And I could even make the first 5 or so lines | "static" they they always contain the standard MP3 fields (like Fooba= r | does). | Although, I did think the tabbed display provided more room for exten= sions | like for broadcast wav info, which doesn't really lend itself to a gr= id | design as it needs some pretty special field formats. Well we "could" or probably would need to have BWF on a separate tab. That ought to be OK. What I still think is a non-starter is having some of the f= ields=20 for one format or group of formats on a separate tab from the other fields = for=20 that format. Or, we could take the view that broadcast metadata needs its o= wn editor. =20 Don't forget Frederico sent us some useful screenshots of the CoolEdit=20 editor for broadcast metadata: http://techweb.rfa.org/grauf/metadata/=20 Now don't those screenshots give us a middle way with our own current=20 problem, i.e. not quite a grid but only a bare minimum of a panel between each row (except maybe for Genre)? If wxWidgets can cope with that=20 and if we can remove the pointless "General" panel, I think that might=20 even crack it without going for a bare grid, which would be a bit out of=20 our usual style. Don't forget also, the less tall we can make it, the less = wide we can make it too, so the whole thing starts to look a more reasonable siz= e=20 for the content. =20 Gale =20 =20 Outbound message virus free. Tested on: 8/1/2007 6:37:00 AM |
From: Gale A. <ga...@au...> - 2007-08-03 02:32:19
|
| From Gale Andrews <ga...@au...> | Wed, 01 Aug 2007 00:53:46 +0100 | Subject: [Audacity-devel] Metadata editor, missing import of FLAC and OGG | data, and 1.4.0 Hi Leland I am now looking at your fourth version of the editor: http://homerow.net/audacity/audacity-win-unicode-1.3.3-scrolled.zip where we have closed up the vertical gaps between the fields and the editor opens by default with no user-added additional fields. You can add fields by clicking "Add" and the window at first expands to accommodate them and then scrolls when you add a fifth field, which looks quite neat (though resizing leaves a funny looking "gap in the middle" when there are no added fields). So the starting size of the window is not too unreasonable now IMO. If this is to be our solution I suggest: 1) Text is needed alongside "Add" and "Remove" to explain the purpose 2) Extra fields added must be retained when the editor is reopened 3) If you move or resize the editor, it should not jump back to its original location when you add a field. 4) If you add a field, existing text in the fixed fields should be retained 5) Clear button should clear the added field boxes, not just the text (in my opinion) 5) You should be able to tab between tag fields, not go straight to "Add" when you tab 6) Only tested in dBPowerAmp, but it can't see the added fields Leland, I still think Track Number and Year should go underneath Album, and Genre should go underneath those two. These are far more important than the other fixed fields that are currently above them. I think the other question is whether we need all or any of: Composer Lyricist Encoded by Copyright as fields that should appear by default. Removing them would of course save space in the default view. I question the "encoded by" field as the "encoded by" data is already passed as LAME v3.97 or whatever, irrespective of your field. Track Number, Copyright and Year could possibly go on one line if we did not have "Encoded by" as a default field. I would definitely go for that if there is space. Year and Track number don't need that width of field. If that worked, I'd think I'd be happy, whether or not Composer and Lyricist were removed from the default view. If they are removed, you might want to have an embedded dropdown as before in the left-hand of the added fields, where you could have those and others as a choice, as long as you can choose to add your custom field if preferred. Views? Is this sufficiently less intimidating with my ideas above? Or should Leland also make a mock-up of a plain grid like Foobar's? I don't think that's needed now, though I do like their downward expanding comments field which is a lot better than scrolling left and right for lengthy text. Can we steal that idea from them? Two other comments: After MP3 export the editor refused to appear again until I restarted. Comments fix for iTunes works fine for me on Windows. Thanks Leland. Gale Outbound message virus free. Tested on: 8/3/2007 3:32:17 AM |
From: David B. <drb...@go...> - 2007-08-03 10:41:34
|
Hi, having edit boxes without labels isn't screen reader friendly. After the edit button, you get to an unlabeled edit box, and probably loose the plot. David. On 8/3/07, Gale Andrews <ga...@au...> wrote: > > | From Gale Andrews <ga...@au...> > | Wed, 01 Aug 2007 00:53:46 +0100 > | Subject: [Audacity-devel] Metadata editor, missing import of FLAC and OGG > | data, and 1.4.0 > > Hi Leland > > I am now looking at your fourth version of the editor: > http://homerow.net/audacity/audacity-win-unicode-1.3.3-scrolled.zip |
From: David B. <drb...@go...> - 2007-08-03 12:51:22
|
ps. I know that Gale doesn't like tabs, but they do make things look less intimidating, and there are existing examples: http://www.mp3-tag.com/screenshots.asp I think the problem with the fourth design is that filling in the extended tags is different form the basic tags and needs lots more explanitory text than there is, and this is going to make the dialog bigger, despite there being an aim to make it smaller. David. On 8/3/07, David Bailes <drb...@go...> wrote: > Hi, > > having edit boxes without labels isn't screen reader friendly. After > the edit button, you get to an unlabeled edit box, and probably loose > the plot. > > David. > > On 8/3/07, Gale Andrews <ga...@au...> wrote: > > > > | From Gale Andrews <ga...@au...> > > | Wed, 01 Aug 2007 00:53:46 +0100 > > | Subject: [Audacity-devel] Metadata editor, missing import of FLAC and OGG > > | data, and 1.4.0 > > > > Hi Leland > > > > I am now looking at your fourth version of the editor: > > http://homerow.net/audacity/audacity-win-unicode-1.3.3-scrolled.zip > |
From: Martyn S. <Mar...@ao...> - 2007-07-30 20:41:19
|
Leland wrote: ... > For you Windows user, you can try the first 2 examples of the metadata > editor here: ... I think I prefer the tabbed one also, although I don't use this a lot. The OK/Cancel buttons are spaced a bit of a way off the bottom! Martyn |