From: SourceForge.net <no...@so...> - 2011-01-29 20:21:03
|
Bugs item #3167820, was opened at 2011-01-29 20:21 Message generated for change (Tracker Item Submitted) made by kymara You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3167820&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Katie Russell (kymara) Assigned to: Nobody/Anonymous (nobody) Summary: achievement notification doesn't show title, desc is x2 Initial Comment: the achievement notification shows the description twice, it should show the title and the description, i think? i.e. in the case of the screen shot: Experienced Adventurer Reach Level 300 Not Reach Level 300 Reach Level 300 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3167820&group_id=1111 |
From: SourceForge.net <no...@so...> - 2011-01-30 22:39:13
|
Bugs item #3167820, was opened at 2011-01-29 20:21 Message generated for change (Comment added) made by kymara You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3167820&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Katie Russell (kymara) >Assigned to: Katie Russell (kymara) Summary: achievement notification doesn't show title, desc is x2 Initial Comment: the achievement notification shows the description twice, it should show the title and the description, i think? i.e. in the case of the screen shot: Experienced Adventurer Reach Level 300 Not Reach Level 300 Reach Level 300 ---------------------------------------------------------------------- >Comment By: Katie Russell (kymara) Date: 2011-01-30 22:39 Message: I found the cause in games.server.events.ReachedAchievementEvent, can upload patch later ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3167820&group_id=1111 |
From: SourceForge.net <no...@so...> - 2011-01-30 22:56:50
|
Bugs item #3167820, was opened at 2011-01-29 20:21 Message generated for change (Comment added) made by kymara You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3167820&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Katie Russell (kymara) Assigned to: Katie Russell (kymara) Summary: achievement notification doesn't show title, desc is x2 Initial Comment: the achievement notification shows the description twice, it should show the title and the description, i think? i.e. in the case of the screen shot: Experienced Adventurer Reach Level 300 Not Reach Level 300 Reach Level 300 ---------------------------------------------------------------------- >Comment By: Katie Russell (kymara) Date: 2011-01-30 22:56 Message: Okay, its just: diff --git a/src/games/stendhal/server/events/ReachedAchievementEvent.java b/src/games/stendhal/server/events/ReachedAchievementEvent.java index d2c0d20..a4db7ae 100644 --- a/src/games/stendhal/server/events/ReachedAchievementEvent.java +++ b/src/games/stendhal/server/events/ReachedAchievementEvent.java @@ -26,7 +26,7 @@ public class ReachedAchievementEvent extends RPEvent { public ReachedAchievementEvent(Achievement achievement) { super(Events.REACHED_ACHIEVEMENT); put("category", achievement.getCategory().toString()); - put("title", achievement.getDescription()); + put("title", achievement.getTitle()); put("description", achievement.getDescription()); } ---------------------------------------------------------------------- Comment By: Katie Russell (kymara) Date: 2011-01-30 22:39 Message: I found the cause in games.server.events.ReachedAchievementEvent, can upload patch later ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3167820&group_id=1111 |
From: SourceForge.net <no...@so...> - 2011-02-10 23:12:06
|
Bugs item #3167820, was opened at 2011-01-29 20:21 Message generated for change (Comment added) made by kymara You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3167820&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Katie Russell (kymara) Assigned to: Katie Russell (kymara) Summary: achievement notification doesn't show title, desc is x2 Initial Comment: the achievement notification shows the description twice, it should show the title and the description, i think? i.e. in the case of the screen shot: Experienced Adventurer Reach Level 300 Not Reach Level 300 Reach Level 300 ---------------------------------------------------------------------- Comment By: Katie Russell (kymara) Date: 2011-02-10 23:12 Message: Thanks for your patch submission. It is now committed to CVS. ---------------------------------------------------------------------- Comment By: Katie Russell (kymara) Date: 2011-01-30 22:56 Message: Okay, its just: diff --git a/src/games/stendhal/server/events/ReachedAchievementEvent.java b/src/games/stendhal/server/events/ReachedAchievementEvent.java index d2c0d20..a4db7ae 100644 --- a/src/games/stendhal/server/events/ReachedAchievementEvent.java +++ b/src/games/stendhal/server/events/ReachedAchievementEvent.java @@ -26,7 +26,7 @@ public class ReachedAchievementEvent extends RPEvent { public ReachedAchievementEvent(Achievement achievement) { super(Events.REACHED_ACHIEVEMENT); put("category", achievement.getCategory().toString()); - put("title", achievement.getDescription()); + put("title", achievement.getTitle()); put("description", achievement.getDescription()); } ---------------------------------------------------------------------- Comment By: Katie Russell (kymara) Date: 2011-01-30 22:39 Message: I found the cause in games.server.events.ReachedAchievementEvent, can upload patch later ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3167820&group_id=1111 |