#5140 [Stendhal Client] Choose character dialog too small

[Hendrik Brummermann]

The choose character dialog is not heigh enough for me anymore on

INFO [main] stendhal.java ( 122) - Stendhal 0.92.5
INFO [main] stendhal.java ( 130) - OS: Linux 2.6.35-27-generic amd64
INFO [main] stendhal.java ( 133) - Java-Runtime: OpenJDK Runtime Environment 1.6.0_20-b20 from /usr/lib/jvm/java-6-openjdk/jre
INFO [main] stendhal.java ( 136) - Java-VM: Sun Microsystems Inc. OpenJDK 64-Bit Server VM 19.0-b09

Please see attached screenshot.

I get the same issue on Stendhal 0.92. But I did not have it last week.

[Hendrik Brummermann]

Bildschirmfoto.png

[Kimmo Rundelin]

I think the cause is the very long character name which forces the character grid to be wider than the maximum allowed dialog size can fit. So the grid gets a horizontal scrollbar which then makes the dialog have too low height as well.
I don't know any good way to adjust the height to hide the vertical scrollbar, but anyway the bug should affect only players who have characters with ridiculously long names.

[James.Datt]

I'm going to try and find a solution for this, will reply later.

[James.Datt]

Uploaded a fix that helps with this patch ID: 3311479 - https://sourceforge.net/tracker/?func=detail&aid=3311479&group_id=1111&atid=301111. Attached is a screenshot of how it looks with a large number of characters, some with long names. Note that those characters are not on game servers, those characters were created and testing was done on my own hosted server.

[Hendrik Brummermann]

Hello James,

thanks for your patch.

I think it would be good, if the number of characters per row would not be reduced unless it is neccessary. I think there are more people who have many characters than people who have characters with a very long name.

Probably the number of columns should depend on the length of the longest name.

[James.Datt]

Alright. I have a good idea of how to do that, will make the changes and upload another patch tonight or tomorrow.

[James.Datt]

Have a look at :
https://sourceforge.net/tracker/?func=detail&aid=3314567&group_id=1111&atid=301111
please Nhnb. The new patch varies the number of columns based on length of longest name and the number of characters. There are screenshots included, which can be found on the patch page attached files list.