Thomas Orgis

OK, thanks. I'll try to remember _WIN32 as the thing to use. I'll need some time to verify the asm stuff, including the mangle.h changes. Since it's been decades of glueing stuff on top of initial creations of the elders, I'm very conservative and want to be sure we don't miss any corner case. At the same time, I have little time available for the task … but we'll get there, eventually. How far are you with ARM64 on MSVC? Also, to get a bit outside the box: The motivation of changing sources at all...

Ah, these make more sense inside compat.h, no? #ifdef HAVE_UNISTD_H #include <unistd.h> #else // Again unsure … _WIN32 or WIN32? #ifdef WIN32 #define STDERR_FILENO _fileno(stderr) #define STDOUT_FILENO _fileno(stdout) #define STDIN_FILENO _fileno(stdin) #endif #endif Like that? Could add a branch for the default 0, 1, 2 values, too, for other platforms.

Ping. I guess it's time to revisit that, now that I finally got around extending the id3v2 code that I had in front of me for so long. Simplifying configure/build is a motivation for me, even if I don't really like touching all assembly files that much. Did the change on the posix I/O functions work to get rid of warnings on Windows?

Let's see if we get that settled for mpg123 1.34.x

I added remaining ID3v2 frame handling now, in preparation for 1.34 release. Please re-test things with current code (rev 5633, snapshot soon tonight). I'm thinking about adding a size constraint on ID3v2 data, too, to close off a possible DoS.

Look at ------------------------------------------------------------------------ r5446 | thor | 2024-10-28 12:43:53 +0100 (Mo 28 de Okt de 2024) | 1 línea Rutas cambiadas: M /trunk/src/compat/compat.c M /trunk/src/compat/compat.h M /trunk/src/libmpg123/lfs_wrap.c libmpg123: use _read/_lseek/_open on MSVCRT (bug 373), patch by manx ------------------------------------------------------------------------ and #if defined(MPG123_COMPAT_MSVCRT_IO) /* MSDN says POSIX function is deprecated beginning in...

That crt/posix crap again? I guess we can do definery to _read and friends on Windows. Or … I'm not sure. Didn't we do this already? I remember this issue, but right now am too occupied carrying the fire hose around for the recent memroy corruption reports.

Nice. So when MSASM works ... we actually don't have a case for needing NASM anymre, right? I'd like to drop the configure stuff for that ... Clang should be happy where gcc/gas is, or not? sent from mobile device, trustworthy or not