Two rpm patches that could be added
Brought to you by:
gyunaev
Menu
▾
▴
#16 Two rpm patches that could be added
libircclient-1.6-install.patch allows running make install and use libdir and includedir in case it is not standard. Usually only libdir can have a value other than @prefix@/lib/.
libircclient-1.6-rfc.patch is required at least when building megaglest, to avoid an error like:
error: 'LIBIRC_RFC_RPL_ENDOFNAMES' was not declared in this scope
If building a shared library, I believe it would be desirable to use a major for it. Since Makefile.in is hand made, it could be done with something like:
- $(CC) -shared -s -o libircclient.so libircclient.o @LIBS@
+ $(CC) -shared -s -o libircclient.so.0 -Wl,-soname=libircclient.so.0 libircclient.o @LIBS@
+ ln -s libircclient.so.0 libircclient.so
and then update the install patch.
libircclient-1.6-install.patch
libircclient-1.6-rfc.patch
Actual working patch to create a shared library, to apply after the previous ones.
libircclient-1.6-shared.patch
Sorry for the mess with the -shared patch, was expecting it to ask if did
want to overwrite the previous one when uploading a newer with the same
name.
Change from original one is that now it creates the symlink before install
or build will fail if there isn't already an installed libircclient, and also did
remove -s to not strip the library.
I am requesting reviews of a libircclient rpm for inclusion in Fedora, so,
these changes are required to pass packaging guidelines and rpmlint
checks.
The Fedora review request is at
https://bugzilla.redhat.com/show_bug.cgi?id=817306