Menu

#224 Wrong default action label when extending an event

unknown
closed-fixed
5
2008-11-17
2008-10-02
No

With Rodin from CVS HEAD, when extending an event, and adding a new action, this action gets default label "act1".
But if the extended event already had an "act1" label, Rodin emit the following error "Ambiguous action label act1".

Renaming the label by say "act10" is ok, if there is no "act10" label in the extended event.

Discussion

  • Son Hoang

    Son Hoang - 2008-10-02

    Just want to confirm that the problem is there since the current version of label generator does not take into account the "extended" attribute of event. This should also be a problem for label of guards.

     
  • mathieu Clabaut

    mathieu Clabaut - 2008-10-07

    A quick note: just take into account the abstract guards label when generating the new label may not be sufficient. Either a new naming scheme must be defined or the whole refinement tree must be taken into account (else, adding a new action/guard in the middle of the refinement would generate a new conflict).

     
  • Son Hoang

    Son Hoang - 2008-10-07

    I only thought of the 2nd option (i.e. taken into account the whole tree). However, the first option is also quite interesting. Should the guard label be prefixed with the name of the machine?
    Cheers,
    Son

     
  • mathieu Clabaut

    mathieu Clabaut - 2008-10-07

    Prefixing the guard label is not desirable in conjunction with the current editor (would take to much of screen real estate) .

    But with the perspective of giving more options to the user and allowing him to display or not the labels (or to display them at another position), it may becomes usable.

    Note for the records that in our models, machine names tend to become quite long (made of 4 or 5 words)

     
  • Laurent Voisin

    Laurent Voisin - 2008-10-17

    Agreed this is a known bug.

    I don't think we should also take into account all the events that are extending the current event. This would be very costly (as one would have to search for all such events).

    In a first step, we will just fix the original bug for actions and guards.

    Please create a feature request if you want more.

     
  • Laurent Voisin

    Laurent Voisin - 2008-10-17
    • assigned_to: tshoang --> a_gilles
     
  • Aurélien GILLES

    Fixed the original bug and commited to CVS

     
  • Aurélien GILLES

    • status: open --> closed-fixed
     

Log in to post a comment.