Menu
▾
▴
#376 @CFLAGS@ not substituted in Makefiles
This patch substitutes @CFLAGS@ in the Makefile, which otherwise doesn't work. This patch modifies:
mingwex/configure.in
profile/configure.in
But it is probably easier to remove the configure scripts from these directories and update the makefiles using the master configure.in.
patch for @CFLAGS@ to be substituted
The defects are actually much more pervasive than just missing CFLAGS substitution. IMO, dispensing with separate configuration in the subdirectories is the right way to proceed.
Patch to create a monolithic configuration.
Alternative proposed patch attached for review.
This works for me, but please check suitability when integrated into a Cygwin build. It is against CVS as of 30-Oct-2008, but excludes the regenerated configure script; please run autoconf, after applying.
File Added: mingwrt-3.15.1-20081030-1.diff
Is this patch OK to commit to CVS?
> Is this patch OK to commit to CVS?
I don't know. I'm still waiting for confirmation that it doesn't break anything on the Cygwin side. That said, those who may care have had ample opportunity to respond, so maybe I should just go ahead regardless?
I have confirmed that with this patch applied and configure regenerated, the Cygwin side still behaves as expected.
Would you like to commit this patch, or would you prefer that I commit it?
Keith's patch was committed to CVS and will be included in the next release.