#376 @CFLAGS@ not substituted in Makefiles

closed-accepted
2009-07-28
2008-07-03
No

This patch substitutes @CFLAGS@ in the Makefile, which otherwise doesn't work. This patch modifies:

mingwex/configure.in
profile/configure.in

But it is probably easier to remove the configure scripts from these directories and update the makefiles using the master configure.in.

Discussion

  • Gregory McGarry

    Gregory McGarry - 2008-07-03

    patch for @CFLAGS@ to be substituted

     
  • Keith Marshall

    Keith Marshall - 2008-10-25
    • assigned_to: nobody --> keithmarshall
     
  • Keith Marshall

    Keith Marshall - 2008-10-25

    The defects are actually much more pervasive than just missing CFLAGS substitution. IMO, dispensing with separate configuration in the subdirectories is the right way to proceed.

     
  • Keith Marshall

    Keith Marshall - 2008-10-31

    Alternative proposed patch attached for review.

    This works for me, but please check suitability when integrated into a Cygwin build. It is against CVS as of 30-Oct-2008, but excludes the regenerated configure script; please run autoconf, after applying.
    File Added: mingwrt-3.15.1-20081030-1.diff

     
  • Chris Sutcliffe

    Chris Sutcliffe - 2009-07-18

    Is this patch OK to commit to CVS?

     
  • Keith Marshall

    Keith Marshall - 2009-07-19

    > Is this patch OK to commit to CVS?

    I don't know. I'm still waiting for confirmation that it doesn't break anything on the Cygwin side. That said, those who may care have had ample opportunity to respond, so maybe I should just go ahead regardless?

     
  • Chris Sutcliffe

    Chris Sutcliffe - 2009-07-24

    I have confirmed that with this patch applied and configure regenerated, the Cygwin side still behaves as expected.

    Would you like to commit this patch, or would you prefer that I commit it?

     
  • Chris Sutcliffe

    Chris Sutcliffe - 2009-07-28

    Keith's patch was committed to CVS and will be included in the next release.

     
  • Chris Sutcliffe

    Chris Sutcliffe - 2009-07-28
    • status: open --> closed-accepted