Menu ▾ ▴

#1660 Read-only does not disable Delete in main menu

Trunk
closed-fixed
Kimmo Varis
GUI (515)
5
2014-08-16
2008-01-29
partime
No

During Directory Compare, setting 'Left Read-only' and/or 'Right Read-only' in the File menu disables the respective 'Delete Left/Right/Both' entries in the context menu but the Delete entry in the Merge menu remains active. (...It will delete both files even if a Read-only is set.)
(Possibly intentional but does seem somewhat inconsistent.)

WinMerge 2.7.6.0 UNICODE (2.6.12.0, 2.6.14.0)

Discussion

  • partime

    partime - 2008-01-29

    WinMerge.txt configuration

     
    WinMerge.txt

  • Kimmo Varis

    Kimmo Varis - 2008-01-29

    Logged In: YES
    user_id=631874
    Originator: NO

    Not intentional. Just a bug that we don't seem to check read-only there.

    Thanks for submitting this bug!

     

  • Kimmo Varis

    Kimmo Varis - 2008-01-30

    Original and altered files.

     
    ReadonlyDelete.zip

  • Kimmo Varis

    Kimmo Varis - 2008-01-30
    • assigned_to: nobody --> kimmov
     

  • Kimmo Varis

    Kimmo Varis - 2008-01-30

    Logged In: YES
    user_id=631874
    Originator: NO

    Attaching a patch.

    File Added: ReadonlyDelete.zip

     

  • Kimmo Varis

    Kimmo Varis - 2008-02-01
    • milestone: --> Trunk
    • status: open --> closed-fixed
     

  • Kimmo Varis

    Kimmo Varis - 2008-02-01

    Logged In: YES
    user_id=631874
    Originator: NO

    Fix committed to SVN trunk:
    Completed: At revision: 4990

    So this bug will be fixed in next 2.7.x release.

     

Log in to post a comment.