Menu

#2433 File Encoding dialog for MergeDoc

Trunk
closed-accepted
None
5
2008-01-14
2008-01-14
No

It would be nice if File Encoding dialog for MergeDoc is available.

For example, WinMerge can't detect the encoding of the file that is UTF-8 without BOM. So it needs to specify the codepage 65001 manually on Option dialog and to recompare it.

The File Encoding dialog for MergeDoc makes the operation easy.

The attached file is the patch for this feature.

Discussion

  • Takashi Sawanaka

     
  • Kimmo Varis

    Kimmo Varis - 2008-01-14

    Logged In: YES
    user_id=631874
    Originator: NO

    Cool!

    Are you sure it is ok to "reload" mergedocument by just calling OpenDocs() again? If so, this would be pretty easy way to reload documents from disk - which is pretty common feature request.

    That codepage dialog is just weird, looks like it has controls that never are enabled etc.

     
  • Takashi Sawanaka

    Logged In: YES
    user_id=954028
    Originator: YES

    > Are you sure it is ok to "reload" mergedocument by just calling OpenDocs()
    again?

    Yes, it is. Even though it needs adding "clear undo buffers" to OpenDocs(), it works for me.

     
  • Kimmo Varis

    Kimmo Varis - 2008-01-14
    • milestone: --> Trunk
     
  • Kimmo Varis

    Kimmo Varis - 2008-01-14

    Logged In: YES
    user_id=631874
    Originator: NO

    Good! I think we have to just test it in experimental release then.

     
  • Takashi Sawanaka

    Logged In: YES
    user_id=954028
    Originator: YES

    Committed to SVN trunk. Completed: At revision: 4913

     
  • Takashi Sawanaka

    • assigned_to: nobody --> sdottaka
    • status: open --> closed-accepted
     

Log in to post a comment.