Menu

#103 Use <label> for login box

closed-fixed
None
5
2007-02-02
2007-01-30
Tim Gerundt
No

This patch adds <label> for the login box form elements.

Greetings,
Tim

Discussion

  • Tim Gerundt

    Tim Gerundt - 2007-01-30

    original and altered file

     
  • Anonymous

    Anonymous - 2007-01-31

    Logged In: YES
    user_id=529507
    Originator: NO

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the patch.

     
  • Anonymous

    Anonymous - 2007-01-31
    • assigned_to: nobody --> goddess_skuld
    • status: open --> closed-fixed
     
  • Tim Gerundt

    Tim Gerundt - 2007-01-31

    Logged In: YES
    user_id=652377
    Originator: YES

    Sorry, but you commit the patch not correct. :-(

    You miss the "id" attribut from "user", "fillindomain" and "domainnum" form elements, which are necessary for the browsers. The label "for" attribut from the password text must be "passwd" and not "domainnum".

    And <td class='right' > must be <td class="right"> (" instead ').

    Greetings,
    Tim

     
  • Tim Gerundt

    Tim Gerundt - 2007-01-31
    • status: closed-fixed --> open
     
  • Anonymous

    Anonymous - 2007-02-01

    Logged In: YES
    user_id=529507
    Originator: NO

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the patch.

     
  • Anonymous

    Anonymous - 2007-02-01
    • status: open --> closed-fixed
     
  • Tim Gerundt

    Tim Gerundt - 2007-02-01

    Logged In: YES
    user_id=652377
    Originator: YES

    I will not annoy you, but in line 145 is still the id "domainnum" missing! ;)

    -------------------------8<-------------------------
    --- index.php.org Thu Feb 01 21:39:37 2007
    +++ index.php Thu Feb 01 21:54:59 2007
    @@ -142,7 +142,7 @@
    }
    else
    {
    - echo '<label for="domainnum">@</label> <select class="button" name="domainnum">';
    + echo '<label for="domainnum">@</label> <select class="button" name="domainnum" id="domainnum">';
    $i = 0;
    while (!empty($conf->domains[$i]->in))
    {
    ------------------------->8-------------------------

    And thank you for catching *my* missing id in line 139!

     
  • Tim Gerundt

    Tim Gerundt - 2007-02-01
    • status: closed-fixed --> open
     
  • Anonymous

    Anonymous - 2007-02-02

    Logged In: YES
    user_id=529507
    Originator: NO

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the patch.

     
  • Anonymous

    Anonymous - 2007-02-02
    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB