#103 Use <label> for login box

[Tim Gerundt]

This patch adds <label> for the login box form elements.

Greetings,
Tim

[Tim Gerundt]

original and altered file

[Anonymous]

Logged In: YES
user_id=529507
Originator: NO

Fixed in CVS.

It'll be included in next release.

But you can download daily snapshots at :
http://nocc.sourceforge.net/download/

Thanks for the patch.

[Tim Gerundt]

Logged In: YES
user_id=652377
Originator: YES

Sorry, but you commit the patch not correct. :-(

You miss the "id" attribut from "user", "fillindomain" and "domainnum" form elements, which are necessary for the browsers. The label "for" attribut from the password text must be "passwd" and not "domainnum".

And <td class='right' > must be <td class="right"> (" instead ').

Greetings,
Tim

[Anonymous]

Logged In: YES
user_id=529507
Originator: NO

Fixed in CVS.

It'll be included in next release.

But you can download daily snapshots at :
http://nocc.sourceforge.net/download/

Thanks for the patch.

[Tim Gerundt]

Logged In: YES
user_id=652377
Originator: YES

I will not annoy you, but in line 145 is still the id "domainnum" missing! ;)

-------------------------8<-------------------------
--- index.php.org Thu Feb 01 21:39:37 2007
+++ index.php Thu Feb 01 21:54:59 2007
@@ -142,7 +142,7 @@
}
else
{
- echo '<label for="domainnum">@</label> <select class="button" name="domainnum">';
+ echo '<label for="domainnum">@</label> <select class="button" name="domainnum" id="domainnum">';
$i = 0;
while (!empty($conf->domains[$i]->in))
{
------------------------->8-------------------------

And thank you for catching *my* missing id in line 139!

[Anonymous]

Logged In: YES
user_id=529507
Originator: NO

Fixed in CVS.

It'll be included in next release.

But you can download daily snapshots at :
http://nocc.sourceforge.net/download/

Thanks for the patch.