Crappy save of project files
Windows visual diff and merge for files and directories
Brought to you by:
christianlist,
grimmdp
Menu
▾
▴
#1389 Crappy save of project files
Hola!
Problem presents either in WinMerge 2.6.0 and 2.7.1.2.
I open two directories for compare and select filter. All work fine.
Then I try to save it as a project file. I choose "Save Project..." in main menu and see "Project File" dialog.
There is crappy path for left (just \) but right seems ok. Moreover when I press "Browse..." button I can't choose directory just a file.
Logged In: YES
user_id=631874
Originator: NO
I just tried this and it worked for me. Do you mean you see the "just \" in the dialog, or is that saved to the file (also)?
Yes, the browse button doesn't work as it should. I haven't had yet time to really implement it. But now I have idea how to implement it and hopefully get it done for next releases.
Meanwhile, you can select folder by selecting file inside the folder and then just removing the filename part from it.
Logged In: YES
user_id=631874
Originator: NO
I've fixed the Browse-button for similar folder selection than in Open-dialog.
And as I can't reproduce this "just \" bug, I'm closing this as fixed.
If you still see the bug, please describe in more detail what happens.
Logged In: YES
user_id=1568667
Originator: YES
I've checked this problem with 2.7.1.3. Still buggy but in different way.
Chain of action looks like this:
1. Choose "Open" in main menu
2. Browse for folder (now it works fine, thx Kimmo), select filter, check "Include subfolders" and press "OK". All works, I see comparing window with results.
3. Then I choose "Save project" in main menu and WinMerge crash.
Logged In: YES
user_id=1568667
Originator: YES
Sorry, I forgot that crash on "Save project" already described as a bug #1566783.
Other things works as it have to, thx again.
Logged In: YES
user_id=631874
Originator: NO
Reopening based on comments below.
> crash in bug #1566783
That crash should be fixed? It isn't?
I'll look at the crash in this report again.
Logged In: YES
user_id=631874
Originator: NO
I don't see the crash, but I see the "\" path now. Looking at it..
Original and altered files
Logged In: YES
user_id=631874
Originator: NO
Attaching a patch that fixes the "\" path problem. And most probably the crash too.
The (stupid) reason was one who originally implemented getting paths for the dialog, could be me too :( , tried to read the paths from *items* in folder compare. And if the first item in the current folder compare didn't have paths in both sides... That caused only "\" added (empty path + "\"). And if you had recursive compare, it might have ignored item or something like that as first item when weird things could happen (crash for example).
I also added a small safety check for the dialog so it accepts only existing paths given to it originally.
File Added: FixProjfileDlgPaths.zip
Logged In: YES
user_id=631874
Originator: NO
Ok, the latest patch is finally applied to SVN trunk. The bug hopefully will be fixed in next experimental release. Unfortunately there was no time to get it into 2.6.2 stable release.
Completed: At revision: 3965
Logged In: YES
user_id=631874
Originator: NO
Ok, committed the fix to 2.6 branch. It will be in 2.6.4 release (and in 2.7.1.4 in couple of days).
Completed: At revision: 3978
If you still see the problems in new those releases, please add comment here. Though I hope I now finally fixed it..
Logged In: YES
user_id=1568667
Originator: YES
Sure, thx Kimmo