Menu

#2075 Add manifest file to resource file

Branch_+_Trunk
closed-accepted
None
5
2006-11-02
2006-10-31
Kimmo Varis
No

This simple patch adds manifest file to resource file.
This way the manifest file (correct one!) gets linked
into executable file and we don't need separate
manifest files anymore.

In addition to patch below, I'll move
WinMerge.exe.manifest and WinMergeU.exe.manifest files
from /Installer/InnoSetup to /Src/res

Index: Merge.rc

--- Merge.rc (revision 3745)
+++ Merge.rc (working copy)
@@ -60,6 +60,14 @@
#endif // APSTUDIO_INVOKED

+// Include the manifest file
+
+#ifdef UNICODE
+CREATEPROCESS_MANIFEST_RESOURCE_ID RT_MANIFEST
"res\\WinMergeU.exe.manifest"
+#else
+CREATEPROCESS_MANIFEST_RESOURCE_ID RT_MANIFEST
"res\\WinMerge.exe.manifest"
+#endif
+
/////////////////////////////////////////////////////////////////////////////
//
// Icon

Discussion

  • Kimmo Varis

    Kimmo Varis - 2006-10-31

    Logged In: YES
    user_id=631874

    Note to myself - this does not work properly with VS2005. I
    have to fix it after this patch is committed.

    Hint for the fix:
    http://www.mathies.com/weblog/?p=225

     
  • Kimmo Varis

    Kimmo Varis - 2006-11-01
    • assigned_to: nobody --> kimmov
    • status: open --> open-accepted
     
  • Kimmo Varis

    Kimmo Varis - 2006-11-01

    Logged In: YES
    user_id=631874

    I added #if MSC_VER < 1400 around that #ifdef UNICODE to fix
    VS2005 build and committed to SVN trunk.
    Completed: At revision: 3755

     
  • Kimmo Varis

    Kimmo Varis - 2006-11-02

    Logged In: YES
    user_id=631874

    Committed to 2.6 branch. Closing.
    Completed: At revision: 3758

     
  • Kimmo Varis

    Kimmo Varis - 2006-11-02
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.