#471 TZDefaultIdentifierConvertor.GetIdentifierCase error

[Leonardo Herrera]

When using MySQL with table case sensitivity and mixed case table names, TZDefaultIdentifierConvertor.GetIdentifierCase() will always return lowercase identifiers,

ZDbcMetadata, around line 5158:

    if Metadata.GetDatabaseInfo.StoresUpperCaseIdentifiers and (Result <> icUpper) then
      S := UpperCase(Value)
    else if not Metadata.GetDatabaseInfo.StoresUpperCaseIdentifiers and (Result <> icLower) then
      s := LowerCase(Value)
    else S := Value;

The first else block looks like a copy-paste error; it should ask for StoresLowerCaseIdentifiers.

[marsupilami79]

Hello Leonardo,

I applied your patch from the forums in [r7204]. Currently I am waiting for the results of the test suites.

Best regards,

Jan

[Mark Ford]

Those changes look good but note that the MySQL Metadata does not currently support mixed case at all as it doesn't properly handle MySQL's "lower_case_table_names" setting.

[EgonHugeist]

Patch applied by Jan, thanks leus.
Regards, Michael