Yoshimi / Bugs / #6 yoshimi-1.2.1/src/Misc/Part.cpp:1039: bad if test ?

#6 yoshimi-1.2.1/src/Misc/Part.cpp:1039: bad if test ?

Milestone: Next Commit

Status: closed

Owner: Will Godfrey

Labels: None

Priority: 5

Updated: 2014-08-25

Created: 2014-07-21

Creator: dcb

Private: No

yoshimi-1.2.1/src/Misc/Part.cpp:1039:22: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

if (kititem == 0 && kititem >= NUM_KIT_ITEMS)

Suggest swap && for ||

Discussion

Will Godfrey - 2014-07-21

status: open --> accepted

assigned_to: Will Godfrey

Group: V1.2.2 --> Next Commit
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Will Godfrey - 2014-07-21

Good catch - this one goes back over 10 years!

Now fixed in the current master branch.

Last edit: Will Godfrey 2014-08-07

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Will Godfrey - 2014-08-25

status: accepted --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

dcb - 2014-08-25

Good catch - this one goes back over 10 years!

Thanks. You might want to start using flag -Wlogical-op
in your development builds.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.