Menu

#45 XMLRPC_DupValueNew incorrectly handles base64 values

v1.0 (example)
closed-fixed
nobody
None
5
2016-08-26
2016-08-25
David Gloe
No

XMLRPC_DupValueNew incorrectly handles base64 values. Currently it will convert base64 types to string types. Here's the patch we're using.

diff --git a/src/xmlrpc.c b/src/xmlrpc.c
index f668f07..066fd0e 100644
--- a/src/xmlrpc.c
+++ b/src/xmlrpc.c
@@ -1645,9 +1645,11 @@ XMLRPC_VALUE XMLRPC_DupValueNew (XMLRPC_VALUE xSource) {
XMLRPC_SetValueInt (xReturn, xSource->i);
break;
case xmlrpc_string:

  • case xmlrpc_base64:
    XMLRPC_SetValueString (xReturn, xSource->str.str, xSource->str.len);
    break;
  • case xmlrpc_base64:
  • XMLRPC_SetValueBase64 (xReturn, xSource->str.str, xSource->str.len);
  • break;
    case xmlrpc_datetime:
    XMLRPC_SetValueDateTime (xReturn, xSource->i);
    break;

Discussion

  • Dan Libby

    Dan Libby - 2016-08-26
    • status: open --> closed-fixed
     
  • Dan Libby

    Dan Libby - 2016-08-26

    wow, that's been hanging out for a long time.

    fixed in cvs. thanks for the patch!

     

Log in to post a comment.

MongoDB Logo MongoDB