Menu
▾
▴
Re: [xml-cppdom-devel] Build system + minor header patches for both 1.2 and trunk series
|
From: Doug M. <mc...@ia...> - 2012-12-11 21:49:15
|
Hey Ryan, I think this commit: > Configuring into the source tree is poor style - redirect to binary tree. is a matter of preference. I have not seen nor read where that is "poor style". I am guessing that is in the eye of the beholder.... Doug On Dec 11, 2012, at 12:58 PM, Ryan Pavlik wrote: > These are primarily simplifying build system patches, with some compatibility fixes built in too. > > For handy browsing, consider the compare view here: > https://github.com/rpavlik/cppdom/compare/vancegroup-mirrors:1.2...rpavlik:1.2-improvements > https://github.com/rpavlik/cppdom/compare/trunk-improvements > > I've attached zipped-up "git format-patch" output - should be able to just apply it in SVN. Here's the first line of each log message: > > • 884d3ab812291c56b116cea0cbc9945288afd05a Combine all set_target_properties calls. > • d3b4457fd0119ccb468cd26bf69ed1f380af1dff Configuring into the source tree is poor style - redirect to binary tree. > • 3e742afa9a827cd3842c77f7ac73dd2299aeca51 Remove trailing spaces > • 1ea3e3836b99dec7158a9db39a831a0e1f6f200f Don't duplicate cmake's effort: use what it knows for the flagpoll file. > • ca950e272b04456e2dd9521bb86a3f704a5b7346 MSVC isn't the only windows compiler, but it is the only one that likes pragma warning( disable > • d5af97bf4a1ecb0d0f54e9e6722983127841826f The defines are _WIN32 and _WIN64 > • 64acce890884081ba95ddfc3080ba980fc7ba93a Add the CMakePackageConfigHelpers.cmake file from CMake 2.8.10. > • e533946c6ab041509c8835c8b8fd9f1096740fd5 Make the Flagpoll section visually different. > • 2f5c9961949eefadffa74db8c5072dcd23676e54 Add info as to why the bit-width workaroudn will fail. > > > -- > Ryan Pavlik > HCI Graduate Student > Virtual Reality Applications Center > Iowa State University > > rp...@ia... > http://academic.cleardefinition.com > <trunk.tar.gz><1.2.tar.gz>------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d_______________________________________________ > Xml-cppdom-devel mailing list > Xml...@li... > https://lists.sourceforge.net/lists/listinfo/xml-cppdom-devel |