From: Kelvie W. <ke...@ie...> - 2009-12-06 11:19:38
Attachments:
tta-demuxer.hg
|
I'm not sure if this is all right (as I under stand it, pts is in secs * 90000?). Seeking, and returning proper stream lengths and the current time is implemented; I've tested it using Phonon (via the minimal Dragon media player, and in Amarok), and it seeks perfectly, but for some reason, using the xine GUI, it doesn't seek very well. I've noticed that FLAC files don't really seek well in xine-ui either, this may or may not be related. Also, the first patch in this series fixes a couple of memory leaks (I think) as I glanced over it. I didn't check it. Any comments/criticism would be great. It's pretty late at night here, so I'm sure I did something stupid. -- Kelvie Wong |
From: Kelvie W. <ke...@ie...> - 2009-12-11 05:33:39
|
2009/12/6 Kelvie Wong <ke...@ie...>: > I'm not sure if this is all right (as I under stand it, pts is in secs > * 90000?). > > Seeking, and returning proper stream lengths and the current time is > implemented; I've tested it using Phonon (via the minimal Dragon media > player, and in Amarok), and it seeks perfectly, but for some reason, > using the xine GUI, it doesn't seek very well. > > I've noticed that FLAC files don't really seek well in xine-ui either, > this may or may not be related. > > Also, the first patch in this series fixes a couple of memory leaks (I > think) as I glanced over it. I didn't check it. > > Any comments/criticism would be great. It's pretty late at night > here, so I'm sure I did something stupid. > > -- > Kelvie Wong > Just as an update (if anyone cares), I have a few other TTA fixes on the way... unless I'm horribly mistaken, this demuxer was written quite half-assed (but better than nothing, I guess). -- Kelvie Wong |
From: Darren S. <li...@yo...> - 2009-12-11 22:11:20
|
I demand that Kelvie Wong may or may not have written... > 2009/12/6 Kelvie Wong <ke...@ie...>: >> I'm not sure if this is all right (as I understand it, pts is in secs >> * 90000?). Yes. >> Seeking, and returning proper stream lengths and the current time is >> implemented; I've tested it using Phonon (via the minimal Dragon media >> player, and in Amarok), and it seeks perfectly, but for some reason, >> using the xine GUI, it doesn't seek very well. >> I've noticed that FLAC files don't really seek well in xine-ui either, >> this may or may not be related. I should hope not, since it's not the FLAC files which should be doing the seeking... :-) >> Also, the first patch in this series fixes a couple of memory leaks (I >> think) as I glanced over it. I didn't check it. Applied, but "hg email" is preferred. [snip] > Just as an update (if anyone cares), I have a few other TTA fixes on the > way... unless I'm horribly mistaken, this demuxer was written quite > half-assed (but better than nothing, I guess). Well... send the patches and they'll at least be looked at and, quite probably, applied too... -- | Darren Salt | linux at youmustbejoking | nr. Ashington, | Doon | using Debian GNU/Linux | or ds ,demon,co,uk | Northumberland | Army | + http://www.youmustbejoking.demon.co.uk/ & http://tartarus.org/ds/ I may not always be perfect, but I'm always me. |