From: Stas S. <st...@ak...> - 2007-07-15 16:14:11
|
Stas Sergeev wrote: > But of course it is not me to think about the > xine-ui portability, so if you think that's right... PS: Unless documented otherwise, the "_NP" suffix might stay for "Non Portable". :) PPS: I still find it more convinient to define the mutex together with the thing it protects, in the same struct. It is only by chance that we need it in a single file, and that may change in the future. |
From: Hans-Dieter K. <hd...@t-...> - 2007-07-16 22:58:57
|
Hi Stas, Stas Sergeev wrote: >> However it seems to be enough to simply change the static initializeHi >> Hansr to PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP. >> Or did I miss something? If not, I'll commit this variant. > > That only depends on where have you go it. :) > I also found that in pthread.h, but it doesn't > seem to be documented, it is defined under __USE_GNU, > and the suffix "_NP" doesn't suggest like it was > intended to be used directly. > So except being undocumented, it also seems to > be completely internal. So unless it is actually > not, I'd rather not do the things like that. > But of course it is not me to think about the > xine-ui portability, so if you think that's right... > It is documented in the man page PTHREAD_MUTEX(3), however, the __USE_GNU makes me suspicious. So, I'll apply your approach. Hans-Dieter |
From: Brian J. T. <bj...@co...> - 2007-07-16 23:30:06
|
Hans-Dieter Kosch wrote: > Hi Stas, > > Stas Sergeev wrote: > >>> However it seems to be enough to simply change the static initializeHi >>> Hansr to PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP. >>> Or did I miss something? If not, I'll commit this variant. >> That only depends on where have you go it. :) >> I also found that in pthread.h, but it doesn't >> seem to be documented, it is defined under __USE_GNU, >> and the suffix "_NP" doesn't suggest like it was >> intended to be used directly. >> So except being undocumented, it also seems to >> be completely internal. So unless it is actually >> not, I'd rather not do the things like that. >> But of course it is not me to think about the >> xine-ui portability, so if you think that's right... >> > It is documented in the man page PTHREAD_MUTEX(3), however, the > __USE_GNU makes me suspicious. So, I'll apply your approach. Just FYI, the "_NP" suffix means "non-portable," so it probably won't work on anything but glibc (or other libc implementations that have decided to clone glibc's weird behaviors). -brian |