From: Barry S. <bar...@on...> - 2005-06-23 14:07:00
Attachments:
input_v4l.patch
|
On FC3 input_v4l had no sound. This patch against xine lib 1.0.1 fixes the problem. Using the ALSA near function allows it to pick a buffer size ALSA likes. Can you commit to CVS? Barry |
From: Barry S. <bar...@on...> - 2005-07-04 10:04:34
|
Can you commit to CVS? Barry Barry Scott wrote: > On FC3 input_v4l had no sound. This patch against xine lib 1.0.1 fixes > the problem. > Using the ALSA near function allows it to pick a buffer size ALSA likes. > > Can you commit to CVS? > > Barry > >------------------------------------------------------------------------ > >--- src/input/input_v4l.c.orig 2005-06-07 12:16:13.000000000 +0100 >+++ src/input/input_v4l.c 2005-06-07 12:16:48.000000000 +0100 >@@ -423,7 +423,7 @@ > > pthread_mutex_unlock (&this->aud_frames_lock); > >- lprintf("alloc_vid_frame done\n"); >+ lprintf("alloc_aud_frame done\n"); > > return frame; > } >@@ -992,7 +992,7 @@ > { > #ifdef HAVE_ALSA > int mode = 0; >- >+ snd_pcm_uframes_t buf_size = (this->periodsize * this->periods) >> 2; > lprintf("open_audio_capture_device\n"); > > /* Allocate the snd_pcm_hw_params_t structure on the stack. */ >@@ -1069,10 +1069,10 @@ > > /* Set buffersize */ > if (this->audio_capture && >- (snd_pcm_hw_params_set_buffer_size(this->pcm_handle, >+ (snd_pcm_hw_params_set_buffer_size_near(this->pcm_handle, > this->pcm_hwparams, >- (this->periodsize * this->periods) >> 2) < 0)) { >- xprintf(this->stream->xine, XINE_VERBOSITY_LOG, "input_v4l: Error setting PCM buffersize\n"); >+ &buf_size) < 0)) { >+ xprintf(this->stream->xine, XINE_VERBOSITY_LOG, "input_v4l: Error setting PCM buffer size to %d\n", (int)buf_size ); > this->audio_capture = 0; > } > > |
From: Hans-Dieter K. <hd...@t-...> - 2005-07-07 23:03:31
|
Barry Scott wrote: > Can you commit to CVS? > > Barry I could commit, but I've no knowledge and possibility to check for side effects and pitfalls. Can somebody confirm that committing is OK? > Barry Scott wrote: > >> On FC3 input_v4l had no sound. This patch against xine lib 1.0.1 fixes >> the problem. >> Using the ALSA near function allows it to pick a buffer size ALSA likes. >> >> Can you commit to CVS? >> >> Barry >> >> ------------------------------------------------------------------------ >> >> --- src/input/input_v4l.c.orig 2005-06-07 12:16:13.000000000 +0100 >> +++ src/input/input_v4l.c 2005-06-07 12:16:48.000000000 +0100 >> @@ -423,7 +423,7 @@ >> pthread_mutex_unlock (&this->aud_frames_lock); >> - lprintf("alloc_vid_frame done\n"); >> + lprintf("alloc_aud_frame done\n"); >> >> return frame; >> } >> @@ -992,7 +992,7 @@ >> { >> #ifdef HAVE_ALSA >> int mode = 0; >> - >> + snd_pcm_uframes_t buf_size = (this->periodsize * this->periods) >> 2; >> lprintf("open_audio_capture_device\n"); >> >> /* Allocate the snd_pcm_hw_params_t structure on the stack. */ >> @@ -1069,10 +1069,10 @@ >> /* Set buffersize */ >> if (this->audio_capture && >> - (snd_pcm_hw_params_set_buffer_size(this->pcm_handle, + >> (snd_pcm_hw_params_set_buffer_size_near(this->pcm_handle, >> this->pcm_hwparams, >> - (this->periodsize * this->periods) >> 2) < 0)) { >> - xprintf(this->stream->xine, XINE_VERBOSITY_LOG, "input_v4l: Error >> setting PCM buffersize\n"); >> + &buf_size) < 0)) { >> + xprintf(this->stream->xine, XINE_VERBOSITY_LOG, "input_v4l: Error >> setting PCM buffer size to %d\n", (int)buf_size ); >> this->audio_capture = 0; >> } >> |
From: Barry S. <bar...@on...> - 2005-07-08 09:40:53
|
Hans-Dieter Kosch wrote: > Barry Scott wrote: > >> Can you commit to CVS? >> >> Barry > > > I could commit, but I've no knowledge and possibility to check for > side effects and pitfalls. Can somebody confirm that committing is OK? > Thanks for offering to commit. I recall in the past that no one stepped forward to admit knowing about the v4l plugin to help comfirm problems or patches. Hopefully someone else is interested now. Barry |
From: Miguel F. <mfr...@gm...> - 2005-07-18 02:42:49
|
On 7/8/05, Barry Scott <bar...@on...> wrote: > > I could commit, but I've no knowledge and possibility to check for > > side effects and pitfalls. Can somebody confirm that committing is OK? > > > Thanks for offering to commit. I recall in the past that no one stepped > forward to admit > knowing about the v4l plugin to help comfirm problems or patches. > Hopefully someone > else is interested now. i can't test it either but the patch looks good to me. i will commit it, thanks. Miguel |