From: <ajh...@ni...> - 2007-01-27 12:29:47
Attachments:
xine-lib-vidixfb_frame_output_cb.patch
|
Hello. Is there a specific reason why vidixfb output plugin in xine-lib uses a hardcoded vidixfb_frame_output_cb -callback function instead of allowing one to be specified via fb_visual_t -struct? For example vdr-xineliboutput supplies its own callback -function and expects it to be called by the video output driver to place and resize osd:s etc. However with vidixfb the function gets never called and in xineliboutput's case osd gets badly broken. I'm attaching a patch which makes the callback handling behave like what xine-lib already has in DirectFB -output. Could something like this be applied to xine-lib cvs? --=20 Antti Sepp=E4l=E4 |
From: Petri H. <Pet...@hu...> - 2007-01-29 05:10:35
|
On Sat, 2007-01-27 at 14:35 +0200, Antti Sepp=E4l=E4 wrote: > Hello. >=20 > Is there a specific reason why vidixfb output plugin in xine-lib uses a > hardcoded vidixfb_frame_output_cb -callback function instead of allowin= g > one to be specified via fb_visual_t -struct? >=20 > For example vdr-xineliboutput supplies its own callback -function and > expects it to be called by the video output driver to place and resize > osd:s etc. However with vidixfb the function gets never called and in > xineliboutput's case osd gets badly broken. >=20 > I'm attaching a patch which makes the callback handling behave like wha= t > xine-lib already has in DirectFB -output. Could something like this be > applied to xine-lib cvs? >=20 I Agree, this patch should be applied ASAP: - it fixes several mainstream problems - it doesn't introduce any new problebs (see Antti's attached code - it just fixes vidix driver to follow common xine rules) |
From: <ajh...@ni...> - 2007-03-14 15:29:54
|
Petri Hintukainen wrote: > On Sat, 2007-01-27 at 14:35 +0200, Antti Seppälä wrote: >> ... >> I'm attaching a patch which makes the callback handling behave like what >> xine-lib already has in DirectFB -output. Could something like this be >> applied to xine-lib cvs? >> > > I Agree, this patch should be applied ASAP: > - it fixes several mainstream problems > - it doesn't introduce any new problebs > (see Antti's attached code - it just fixes vidix driver to follow common > xine rules) > It's now been a while without any comments about my patch from the devs. I'm not however ready to give up yet. =) The patch has even received some positive feedback. (See above reply from Petri). So please consider applying the patch to CVS. -- Antti Seppälä |