From: Bastien N. <ha...@ha...> - 2003-12-29 00:55:23
|
Heya, I was wondering why the CDDA plugin was abort()'ing when it couldn't connect to the CDDB server. It looks like the signal handling is a bit doubtful. Crashing an application when a plugin can't read the metadata is a bit harsh. Anybody against changing this code to use the IO helpers? I might be adding CDDB ID/TRM ID support to the metadata by the same token. Daniel, as you're the one who wrote this code, any comments, or warnings before I dive in? Cheers --- Bastien Nocera <ha...@ha...> Accept that some days you are the pigeon, and some days you are the statue. |
From: Miguel F. <mi...@ce...> - 2003-12-29 17:15:34
|
Hi Bastien, On Sun, 2003-12-28 at 22:55, Bastien Nocera wrote: > I was wondering why the CDDA plugin was abort()'ing when it couldn't > connect to the CDDB server. It looks like the signal handling is a bit > doubtful. Crashing an application when a plugin can't read the metadata > is a bit harsh. I would say that it's wrong. We must not abort() from xine-lib unless under very special conditions... > Anybody against changing this code to use the IO helpers? I might be > adding CDDB ID/TRM ID support to the metadata by the same token. Not at all, go ahead! I have being thinking lately of maybe even disabling CDDB lookup by default or moving it to a separated thread to not block the playback. what do you think? regards, Miguel |
From: Bastien N. <ha...@ha...> - 2003-12-30 11:12:24
|
On Mon, 2003-12-29 at 17:24, Miguel Freitas wrote: > Hi Bastien, > > On Sun, 2003-12-28 at 22:55, Bastien Nocera wrote: > > I was wondering why the CDDA plugin was abort()'ing when it couldn't > > connect to the CDDB server. It looks like the signal handling is a bit > > doubtful. Crashing an application when a plugin can't read the metadata > > is a bit harsh. > > I would say that it's wrong. We must not abort() from xine-lib unless > under very special conditions... > > > Anybody against changing this code to use the IO helpers? I might be > > adding CDDB ID/TRM ID support to the metadata by the same token. > > Not at all, go ahead! > > I have being thinking lately of maybe even disabling CDDB lookup by > default or moving it to a separated thread to not block the playback. > what do you think? I was actually thinking of disabling it, and moving it to the front-end, for Totem. But removing it completely seems a bit harsh. I'll try and do something soon about it. Cheers --- Bastien Nocera <ha...@ha...> The dandelion swayed in the gentle breeze like an oscillating electric fan set on medium. |
From: Miguel F. <mi...@ce...> - 2003-12-30 11:22:17
|
On Tue, 2003-12-30 at 06:12, Bastien Nocera wrote: > > I have being thinking lately of maybe even disabling CDDB lookup by > > default or moving it to a separated thread to not block the playback. > > what do you think? > > I was actually thinking of disabling it, and moving it to the front-end, > for Totem. You may always set the cdda configuration on runtime from Totem (just to make sure cddb is disabled). > But removing it completely seems a bit harsh. yes, but i never suggested removing it... just perhaps leaving it off by default. regards, Miguel |