From: <bug...@xi...> - 2008-02-09 13:22:00
|
http://bugs.xine-project.org/show_bug.cgi?id=41 Summary: gxine fails on version check for xine-lib-1.1.10.1 Product: gxine Version: unspecified Platform: Other OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: Core AssignedTo: li...@yo... ReportedBy: mar...@gm... CC: xin...@xi... Gxine lib fails to correctly detect version for the newer xine releases that use x.y.z.w format for their version number. The problem is that gxine expects x.y.z output but x.y.z.w is given. I patched configure file in the Fedora package to allow build with this patch: http://cvs.fedoraproject.org/viewcvs/rpms/gxine/devel/gxine-0.5.11-xine-version-check.patch?rev=1.1&view=markup -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2008-02-09 13:28:34
|
http://bugs.xine-project.org/show_bug.cgi?id=41 Martin Sourada <mar...@gm...> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|gxine fails on version check|gxine build fails on version |for xine-lib-1.1.10.1 |check for xine-lib-1.1.10.1 -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2008-02-09 14:01:39
|
http://bugs.xine-project.org/show_bug.cgi?id=41 --- Comment #1 from Ville Skyttä <vil...@ik...> 2008-02-09 14:01:42 UTC --- Created an attachment (id=15) --> (http://bugs.xine-project.org/attachment.cgi?id=15) Make xine-config --version parsing more robust I think there's quite a bit more room for improvement in the sed expression: 1) The expression is not bound to start/end of line, and will thus pass possible leading/trailing garbage through. 2) It uses plain "." (== any character as far as sed is concerned) where it appears to search for the literal ".". 3) The whole "xine-config --version" output is assigned to all xine_config_*_version vars if there's no match. I think more intuitive would be them to be empty if parsing fails. 4) It uses * (0 or more) for matching digit sequences, where I think + (1 or more) would be desirable. The attached patch (tested in shell only on Fedora 8's sed 4.1.5-9.fc8) should fix issues 1 to 3. I suppose for 4) it would additionally take only replacing the first three "*" with "\+" but IIRC there are some portability issues related to "+" between different sed versions. -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2008-02-09 14:01:56
|
http://bugs.xine-project.org/show_bug.cgi?id=41 Ville Skyttä <vil...@ik...> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vil...@ik... -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. |
From: <bug...@xi...> - 2008-02-09 16:31:25
|
http://bugs.xine-project.org/show_bug.cgi?id=41 Martin Sourada <mar...@gm...> changed: What |Removed |Added ---------------------------------------------------------------------------- Product|gxine |xine-lib Component|Core |Core / Backend --- Comment #2 from Martin Sourada <mar...@gm...> 2008-02-09 16:31:26 UTC --- Looking at Ville's comments this appears to be actually a bug in xine-lib itself, so changing the component from gxine to xine-lib. -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2008-02-09 16:32:46
|
http://bugs.xine-project.org/show_bug.cgi?id=41 --- Comment #3 from Martin Sourada <mar...@gm...> 2008-02-09 16:32:49 UTC --- *** Bug 42 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2008-02-09 18:27:24
|
http://bugs.xine-project.org/show_bug.cgi?id=41 Darren Salt <li...@yo...> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Mercurial 1.1 Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Darren Salt <li...@yo...> 2008-02-09 18:27:28 UTC --- Fixed in hg. -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2008-03-13 21:14:46
|
http://bugs.xine-project.org/show_bug.cgi?id=41 Diego Pettenò <fla...@xi...> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mar...@ar... --- Comment #5 from Diego Pettenò <fla...@xi...> 2008-03-13 21:14:48 UTC --- *** Bug 56 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are watching all bug changes. |