Re: [Xf4vnc-devel] Monolithic tree compilation bug for PowerPC (and likely other non-x86)

[Brian P. <bri...@tu...>]

Paul Whittaker wrote:
> I haven't provided a patch because I'm not sure how you want to work 
> around the issue.  It's not a problem with VNC-specific code, just the 
> general X11 server code.
> 
> The problem is that xc/programs/Xserver/hw/xfree86/fbdevhw/fbdevhw.c 
> expects <asm/page.h> to define a PAGE_MASK macro, but - for recent 
> PowerPC kernel headers, at least -  PAGE_MASK et al are private macros 
> that you will only get if __KERNEL__ is defined.  Whether or not 
> <asm/page.h>ultimately publicly defines PAGE_MASK seems to be a platform 
> implementation decision (safe to assume for x86, generally unsafe for 
> anything else, including x86_64).
> 
> I just had a look at how this was addressed in Xorg 6.9.0.  They did this:
> 
> #if 0
> /* kernel header doesn't work with -ansi */
> # include "asm/page.h"  /* #define for PAGE_* */
> #else
> # define PAGE_MASK               (~(getpagesize() - 1))
> #endif

I've checked in this change.  Thanks.

-Brian