Menu

#6 xdelta may fail for corrupt gzips

closed-wont-fix
nobody
None
5
2001-09-23
2001-06-28
Ben Escoto
No

It appears that if xdelta is used to compare corrupt
gzip files, it will try to uncompress them, and then
will fail if the uncompression fails. For instance,
here is a "screenshot":

$ xdelta delta ../temp/wml-2.0.6.tar.gz
wml-2.0.6.tar.gz out
xdelta: gzread wml-2.0.6.tar.gz failed: Success
$

Ungzipping stuff may work best in many situations, but
it seems that xdelta should be correct in all cases.
At any rate, using xdelta on a corrupt gzip doesn't
seem that weird a situation to me. This is for version
1.1.1; maybe it is fixed already.

Discussion

  • Joshua P. MacDonald

    Logged In: YES
    user_id=40985

    Thanks Ben, for submitting this report. This should be easy to fix...

     
  • Joshua P. MacDonald

    • status: open --> closed-wont-fix
     
  • Joshua P. MacDonald

    Logged In: YES
    user_id=40985

    The thing that concerns me the most about this is the
    "failed: Success" output. I have fixed that. You can use
    the -p (--pristine) option to disable automatic GZIP file
    recognition, otherwise.

     

Log in to post a comment.