wxlua-users — wxLua list for users and developers

Re: [wxlua-users] Bug in wxImage::SetAlphaData()?

[John L. <jla...@gm...>]

On Tue, Aug 13, 2013 at 11:26 AM, Andreas Falkenhahn <an...@fa...
> wrote:

> Hi,
>
> in the override function for wxImage::SetAlpha() in wxcore_override.hpp
> there is
> the following code:
>
> size_t size = 3*self->GetWidth()*self->GetHeight();
> memcpy(self->GetData(), data, wxMin(len, size));
>
> I think this is wrong because alpha channel data is only one byte per
> pixel.
>

Fixed in SVN, thanks!
    John

Re: [wxlua-users] Superfluous condition in scribble.wx.lua?

[John L. <jla...@gm...>]

On Tue, Aug 13, 2013 at 9:01 AM, Andreas Falkenhahn
<an...@fa...>wrote:

> Hi,
>
> there is the following code in scribble.wx.lua:
>
>         if colourWin:GetToolTip() ~= s then
>         colourWin:SetToolTip(s)
>         end
>
> But AFAICS, wxWindow::GetToolTip() will never return a string,
> but will always push a value of type "userdata" on the stack. Thus,
> the condition check is superfluous because it is always TRUE and
> SetToolTip() will always be called.
>
>
Good eye, you're right, fixed in SVN, thanks.
    John

[wxlua-users] Bug in wxImage::SetAlphaData()?

[Andreas F. <an...@fa...>]

Hi,

in the override function for wxImage::SetAlpha() in wxcore_override.hpp there is
the following code:

size_t size = 3*self->GetWidth()*self->GetHeight();
memcpy(self->GetData(), data, wxMin(len, size));  

I think this is wrong because alpha channel data is only one byte per pixel.
Thus, the code above is likely to crash if the user calls SetAlphaData() with
a string containing more than width*height bytes. Instead, it should be:

size_t size = self->GetWidth()*self->GetHeight();
memcpy(self->GetData(), data, wxMin(len, size));  

-- 
Best regards,
 Andreas Falkenhahn                          mailto:an...@fa...

[wxlua-users] Superfluous condition in scribble.wx.lua?

[Andreas F. <an...@fa...>]

Hi,

there is the following code in scribble.wx.lua:

	local s = "Set pen color : "..colourWinColours[i]

	if colourWin:GetToolTip() ~= s then
       	colourWin:SetToolTip(s)
	end

But AFAICS, wxWindow::GetToolTip() will never return a string,
but will always push a value of type "userdata" on the stack. Thus,
the condition check is superfluous because it is always TRUE and
SetToolTip() will always be called.

Correct me if I overlooked something here...

-- 
Best regards,
 Andreas Falkenhahn                          mailto:an...@fa...

Re: [wxlua-users] Difference between Lua and wxLua executable

[John L. <jla...@gm...>]

On Tue, Jun 25, 2013 at 3:19 AM, Milind Gupta <mil...@gm...>wrote:

> Hi,
>     From the wxWidgets forum I found out that wxDatePickerCtrl-1 which is
> displayed when I use Lua which uses the wx.dll is the generic control while
> wxDatePickerCtrl-2 is the Native windows control. Also in windows wxWidgets
> automatically uses the native control unless we explicitly use the
> wxDatePickerCtrlGeneric
>          So does anybody have any idea why the wx.dll uses the generic
> control for wxDatePickerCtrl. This is just one difference as mentioned in
> the email chain below there are other differences as well.
>


 I don't know exactly what two versions of wxLua you're using and where you
got them, but I recommend using the ones here :

http://sourceforge.net/projects/wxlua/files/?source=navbar


The calendar control I see in wxLua and the Windows 7/8 calendar when shown
when you left-click the clock in the lower-right are the same and they look
like the image wxDatePickerCtrl-1, like this :

http://msdn.microsoft.com/en-us/library/windows/desktop/bb760913%28v=vs.85%29.aspx

wxDatePickerCtrl-2 is maybe the old-style calendar control from Windows-XP.

I don't know how the two versions of wxLua manage to show different
controls, unless you're running them with different paths to comctl32.dll.

Regards,
    John

Re: [wxlua-users] Crash on lua_close() [was: Using wxLua with Lua 5.0.2]

[John L. <jla...@gm...>]

On Sat, Aug 10, 2013 at 1:37 PM, Andreas Falkenhahn
<an...@fa...>wrote:

>
> > Build wxLua using the provided CMakeFiles as described in the
> > install.html in the docs dir.
>
> This unfortunately doesn't work here for me. I don't have Visual Studio
> but just its compiler
> collection that is freely available with the Windows SDK. That's why I use
> the generator named
>
"NMake Makefiles" in the CMake GUI. Here is my CMake configuration:
>
> http://www.falkenhahn.com/tmp/cmake.png
>
>
This is because you did not allow SVN to checkout externals I believe.


> When I try to build wxLua then by typing nmake, it first builds some parts
> of lua 5.1 but
> then it fails completely saying:
>
> NMAKE : fatal error U1073: don't know how to make
> 'modules\lua-5.1\LuaLib.dir\.\lapi.obj'
> Stop.
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
> Studio 9.0\VC\bin\nmake.exe"' : return code '0x2'
> Stop.
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
> Studio 9.0\VC\bin\nmake.exe"' : return code '0x2'
> Stop.
>
>
These are very strange error messages, I'm not sure what they mean.
Googling seems to suggest that your paths and env variables may not be
right. There is no reason why lapi.obj should be built any differently than
every other Lua source file. Some people claim that if you rerun it / clean
the build nmake will succeed.

I just built wxLua using the CMakeFiles for MSVC 2008 using nmake 64-bit
and it builds and runs without error.

You run vcvars32.bat in a DOS prompt right?
"c:\Program Files (x86)\Microsoft Visual Studio
9.0\VC\bin\amd64\vcvars32.bat"

Then you run cmake-gui.exe from that command prompt or do you do something
else?

Have you installed all the service packs for your MSVC? The cl.exe that
comes with MSVC 2008 (what I use) is exactly the same version as what you
use;
Microsoft (R) C/C++ Optimizing Compiler Version 15.00.30729.01 and the
service packs for it had some very important fixes.


> Yes, luamodule.cpp is actually exactly the code I used in my example. The
> app is
> instantiated in luaopen_wx(). Is there anything else that needs to be done?
>
>
No, if you follow the code in the example programs it should work.

Regards,
    John

Re: [wxlua-users] Potential memory fault in wxLua

[John L. <jla...@gm...>]

On Sat, Aug 10, 2013 at 3:41 PM, Andreas Falkenhahn
<an...@fa...>wrote:

> Hi,
>
> I've just seen that there seems to be a potential memory access fault in
> wxLua in
> wxlua_getchararray() in wxlstate.cpp. Have a look at this code:
>
>         int table_len = lua_objlen(L, stack_idx);
>         if (table_len > 0)
>             arrChar = new const char *[table_len];
>
>         if (arrChar != NULL)
>         {
>             for (int n = 0; n < table_len; ++n)
>             {
>                 lua_rawgeti(L, stack_idx, n+1); // Lua array starts at 1
>                 const char *s = wxlua_getstringtype(L, -1);
>                 arrChar[n] = s; // share Lua string
>                 lua_pop(L, 1);
>             }
>         }
>
> You can see here that the pointer returned by lua_tostring() [which is
> usually
> called by wxlua_getstringtype()] is stored inside arrChar[n] here and then
> the string is popped from the stack. But AFAIK lua guidelines say that
> pointers
> only remain valid as long as they're on the stack. Once they've been
> popped,
> they could become invalid at any time. Thus, the code posted above could
> lead to a memory access fault under certain conditions.
>

The string exists also in the Lua table where it was pushed on the stack
from and it should definitely live for the life of this and its parent's
function call. Now if you find a place where this function is called and
the return value is stored for use later after more Lua code could be run
that could be a problem.

Regards,
    John

Re: [wxlua-users] Typo in calculator.wx.lua

[John L. <jla...@gm...>]

On Sat, Aug 10, 2013 at 6:43 PM, Andreas Falkenhahn
<an...@fa...>wrote:

> Hi,
>
> just discovered some small typos in the calculator.wx.lua sample: when
> setting up the
> accelerator table it uses wx.VXK_NUMPAD<x> several times... but this is
> apparently a
> nil reference. The correct reference is wx.WXK_NUMPAD<x>, i.e. WXK instead
> of VXK.
>
>
Thanks! Fixed in SVN.

Regards,
    John

[wxlua-users] Typo in calculator.wx.lua

[Andreas F. <an...@fa...>]

Hi,

just discovered some small typos in the calculator.wx.lua sample: when setting up the
accelerator table it uses wx.VXK_NUMPAD<x> several times... but this is apparently a
nil reference. The correct reference is wx.WXK_NUMPAD<x>, i.e. WXK instead of VXK.

-- 
Best regards,
 Andreas Falkenhahn                          mailto:an...@fa...

[wxlua-users] Potential memory fault in wxLua

[Andreas F. <an...@fa...>]

Hi,

I've just seen that there seems to be a potential memory access fault in wxLua in
wxlua_getchararray() in wxlstate.cpp. Have a look at this code:

        int table_len = lua_objlen(L, stack_idx);
        if (table_len > 0)
            arrChar = new const char *[table_len];

        if (arrChar != NULL)
        {
            for (int n = 0; n < table_len; ++n)
            {
                lua_rawgeti(L, stack_idx, n+1); // Lua array starts at 1
                const char *s = wxlua_getstringtype(L, -1);
                arrChar[n] = s; // share Lua string
                lua_pop(L, 1);
            }
        }

You can see here that the pointer returned by lua_tostring() [which is usually
called by wxlua_getstringtype()] is stored inside arrChar[n] here and then
the string is popped from the stack. But AFAIK lua guidelines say that pointers
only remain valid as long as they're on the stack. Once they've been popped,
they could become invalid at any time. Thus, the code posted above could
lead to a memory access fault under certain conditions.

-- 
Best regards,
 Andreas Falkenhahn                          mailto:an...@fa...

Re: [wxlua-users] Crash on lua_close() [was: Using wxLua with Lua 5.0.2]

[Andreas F. <an...@fa...>]

Hi John,

thanks for your support!

On 10.08.2013 at 18:14 John Labenski wrote:

> Hi Andreas,


> You have two things that could be the problem here; your custom build and your modified code.

> Build wxLua using the provided CMakeFiles as described in the
> install.html in the docs dir. 

This unfortunately doesn't work here for me. I don't have Visual Studio but just its compiler
collection that is freely available with the Windows SDK. That's why I use the generator named
"NMake Makefiles" in the CMake GUI. Here is my CMake configuration:

http://www.falkenhahn.com/tmp/cmake.png

When I try to build wxLua then by typing nmake, it first builds some parts of lua 5.1 but
then it fails completely saying:

NMAKE : fatal error U1073: don't know how to make 'modules\lua-5.1\LuaLib.dir\.\lapi.obj'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\nmake.exe"' : return code '0x2'
Stop.

Here is a screenshot of nmake's output:

http://www.falkenhahn.com/tmp/nmake.png

You can see that some parts of wxLua are actually built just fine but then it just exits
because of a problem in the makefile. It seems like a wrong build rule but I don't know
anything about CMake and this whole build system looks really complicated with lots of
references and temporary files being created while building so that I'm hardly able to
fix this.

That's why I just went and setup my own makefile to build it. 

> 1) About your custom build, I would really just use wxLua's build
> files, please let me know why they aren't suitable for you. 

See above. If you can help me to get this to build, I can check if the error only
happens with my custom makefile.

> 
> Also,
> make sure that wxLua is compiled with the same Lua source files as
> the lib you are linking to, you may be using mismatched Lua libs. I
> noticed that you use /MT for linking, wxWidgets and wxLua use /MD by
> default, did you build wxWidgets as /MT too? 

Yes, I did. By default, wxWidgets wants to build using /MD but I changed
this because I prefer /MT.

> 2) Rem out your "luaopen_wx()" call and run one of the samples that
> use ' require("wx") ' call to use the built wx.dll and see if you
> can do that.

Yes, with your prebuilt wx.dll from the official distribution there are
no problems. It's only my builds that fail.

> I believe that instead of adding luaopen_wx() you
> should simply just run wxluafreeze.exe since its code does what
> wxLua needs to install itself into Lua properly. 

> This code shows how to properly instantiate wxLua using a wxApp as main().

> http://sourceforge.net/p/wxlua/svn/184/tree/trunk/wxLua/apps/wxluafreeze/wxluafreeze.cpp
>  

> or this which is for loading from a DLL, note the wxApp too.
> http://sourceforge.net/p/wxlua/svn/184/tree/trunk/wxLua/modules/luamodule/luamodule.cpp

Yes, luamodule.cpp is actually exactly the code I used in my example. The app is
instantiated in luaopen_wx(). Is there anything else that needs to be done?

-- 
Best regards,
 Andreas Falkenhahn                            mailto:an...@fa...

Re: [wxlua-users] Crash on lua_close() [was: Using wxLua with Lua 5.0.2]

[John L. <jla...@gm...>]

On Sat, Aug 10, 2013 at 7:18 AM, Andreas Falkenhahn
<an...@fa...>wrote:

>
> I've included the source code and makefile in the archive but it's really
> nothing more than an unmodified version of Lua 5.1 and of wxLua taken
> from the SVN. I also tried it with an older wxLua (version 2.8.10.0) but
>

...


> The only modification I made is in the main() function of lua.c. I
> inserted the call to luaopen_wx() directly after creating the lua_State
> using lua_open() because I wanted to have everything in a single program,
> i.e. wxLua isn't loaded as a DLL but is statically linked to the lua
> interpreter. But this really shouldn't do any harm.
>
>
Hi Andreas,

You have two things that could be the problem here; your custom build and
your modified code.

Build wxLua using the provided CMakeFiles as described in the install.html
in the docs dir. Run some of the samples and verify that they work. Do they?

1) About your custom build, I would really just use wxLua's build files,
please let me know why they aren't suitable for you.  Also, make sure that
wxLua is compiled with the same Lua source files as the lib you are linking
to, you may be using mismatched Lua libs. I noticed that you use /MT for
linking, wxWidgets and wxLua use /MD by default, did you build wxWidgets as
/MT too? I obviously recommend using /MD since I think it's better to use
the system default.

http://stackoverflow.com/questions/3469841/mixing-code-compiled-with-mt-and-md
http://stackoverflow.com/questions/757418/should-i-compile-with-md-or-mt

2) Rem out your "luaopen_wx()" call and run one of the samples that use '
require("wx") ' call to use the built wx.dll and see if you can do that. I
believe that instead of adding luaopen_wx() you should simply just run
wxluafreeze.exe since its code does what wxLua needs to install itself into
Lua properly.

This code shows how to properly instantiate wxLua using a wxApp as main().
http://sourceforge.net/p/wxlua/svn/184/tree/trunk/wxLua/apps/wxluafreeze/wxluafreeze.cpp

or this which is for loading from a DLL, note the wxApp too.
http://sourceforge.net/p/wxlua/svn/184/tree/trunk/wxLua/modules/luamodule/luamodule.cpp


Your crash in

    void wxLua_wxGridCellCoords_delete_function(void** p)

makes no sense if you never created a wxGridCellCoords. You must be
overwriting some variable and mangling the code. You can use the program
"ApplicationVerifier" to find memory overflows, it works great. But, I
would definitely fix the above problems first.


Regards,
    John

Re: [wxlua-users] Using wxLua with Lua 5.0.2

[Andreas F. <an...@fa...>]

Hi John,

On 10.08.2013 at 05:22 John Labenski wrote:

> Hi Andreas,


> I didn't realize you had made a separate thread. Please describe
> how you are building wxLua, settings, with what compiler and version, os, etc...

It's all in this archive:

http://www.falkenhahn.com/tmp/wxLua.zip

I have merged everything in a single makefile (see makefile.win32) which is
pretty minimalistic and you should be able to build this right away with

nmake -f makefile.win32

Compiler is Visual C 15.00.30729.01 on Windows 7 64bit but of course I'm
compiling for 32bit.

The makefile builds a version of lua that has wxLua statically linked to it.

>  
> You shouldn't have any problems with the current SVN if built
> properly. If your problem was only with 5.0.2, I'm afraid that you
> will have to look into that yourself, that version of Lua is quite old.

It isn't related to 5.0.2 because the same issue happens with Lua 5.1.
It was just my first thought that it could be related to 5.0.2 but tests
have shown that it happens with 5.1 too... see the example in the archive
above.

-- 
Best regards,
 Andreas Falkenhahn                            mailto:an...@fa...

Re: [wxlua-users] Crash on lua_close() [was: Using wxLua with Lua 5.0.2]

[Andreas F. <an...@fa...>]

Hi John,

On 10.08.2013 at 04:45 John Labenski wrote:

> Hi Andreas,


> I missed the description of original issue and details of how to
> reproduce it, can you please describe them again.

The issue is that I always get a program crash on exit with wxLua.
It is always reproducable here. That's why I've uploaded this example:

http://www.falkenhahn.com/tmp/wxLua.zip

You just have to open a shell, and type the following to get the crash:

win32/wxlua.exe veryminimal.wx.lua

The sample will run fine but when you close the window, it will crash.

I've included the source code and makefile in the archive but it's really
nothing more than an unmodified version of Lua 5.1 and of wxLua taken
from the SVN. I also tried it with an older wxLua (version 2.8.10.0) but
it crashes with this version too. So we can rule out the possibility that
I accidentally checked out a broken version of wxLua.

The only modification I made is in the main() function of lua.c. I
inserted the call to luaopen_wx() directly after creating the lua_State
using lua_open() because I wanted to have everything in a single program,
i.e. wxLua isn't loaded as a DLL but is statically linked to the lua
interpreter. But this really shouldn't do any harm.

> I do try to look into issues, but my time is limited. Please try to
> reproduce the problem in one of the samples.

It happens with all samples. So it must be something general... all samples
I tried always crash at the end, when the program is about to be terminated.

-- 
Best regards,
 Andreas Falkenhahn                            mailto:an...@fa...

Re: [wxlua-users] New Bindings etc.

[John L. <jla...@gm...>]

On Fri, Aug 9, 2013 at 5:26 PM, klaas.holwerda <ng...@kl...> wrote:

>
> For the rest i had to remove "media" from the CmakeLists file, since it
> did not work in wxWidgest right away also.
> After that i need to first clear the cmake cache, else somehow it does not
> believe it, and gives an error still.
>
>
Glad you got it working.

The CMake code is supposed to find what wxWidgets libs actually exist and
automatically not build the wxLua ones that are missing. I will look into
that.



> All in all nice improvements.
> The Unix and windows libs are now named almost the same, makes it easier.
> The bindings can now much easier be extended.
> Maybe the default install location can be set to /usr/local on unix.
>

I had preferred to install to a safer place in the build dir, but I suppose
that /usr/local is more standard.


> Just wondering if you already have something to compare them to the
> interface header files of wx?
> Or is using them the next step :-)
>
>
I can actually run the binding generator on about half of the the wxWidgets
2.9 interface files. It has been slow going and the generated code doesn't
compile, I have to handle void* etc. and instead of remming things out I
need to make proper doxygen comments so they can be used to generate the
docs too.



> Thanks for all the work, wxLua rocks!
>
>
Thanks!
    John

Re: [wxlua-users] Using wxLua with Lua 5.0.2

[John L. <jla...@gm...>]

On Fri, Aug 9, 2013 at 4:08 PM, Paul K <pau...@ya...> wrote:

> Hi Andreas,
>
> > But of course that's not really a solution for me because the crash
> > in lua_close() tells me that there is something going wrong... it doesn't
> > happen with the official builds of wxLua for Windows. This is why I'm
> even
> > more curious what could be the cause for this crash... any other ideas?
>
> I agree; I don't like that either, but couldn't track down the source
> of the issue.
>
> FWIW, the veryminimal sample doesn't crash for me using wx.dll I
> compiled using this batch script
> (
> https://github.com/pkulchenko/ZeroBraneStudio/blob/master/build/build-win32.sh
> );
> I actually have binaries for all the platforms and they handle samples
> without issues (
> https://github.com/pkulchenko/ZeroBraneStudio/tree/master/bin).
> I use mingw though vs. your VS.
>
>
Hi Andreas,

I didn't realize you had made a separate thread. Please describe how you
are building wxLua, settings, with what compiler and version, os, etc...

You shouldn't have any problems with the current SVN if built properly. If
your problem was only with 5.0.2, I'm afraid that you will have to look
into that yourself, that version of Lua is quite old.

Regards,
    John

Re: [wxlua-users] Crash on lua_close() [was: Using wxLua with Lua 5.0.2]

[John L. <jla...@gm...>]

On Fri, Aug 9, 2013 at 6:05 PM, Andreas Falkenhahn
<an...@fa...>wrote:

>
> >> But of course that's not really a solution for me because the crash
> >> in lua_close() tells me that there is something going wrong... it
> doesn't
> >> happen with the official builds of wxLua for Windows. This is why I'm
> even
> >> more curious what could be the cause for this crash... any other ideas?
>
> > I agree; I don't like that either, but couldn't track down the source
> > of the issue.
>
>
Hi Andreas,

I missed the description of original issue and details of how to reproduce
it, can you please describe them again.



> Do the maintainers of wxLua follow this list and is there a chance that
>

Yes.

they look into such issues? I think the test case I uploaded to
>
> http://www.falkenhahn.com/tmp/wxLua.zip
>
>
I do try to look into issues, but my time is limited. Please try to
reproduce the problem in one of the samples.


Ok, maybe I'll try it with mingw but I can hardly believe that the problem
> is with Visual C...
>
>
The wxLua binaries on sourceforge were compiled using MSVC 6 and I use
wxLua compiled with MSVC 2008 regularly.

Regards,
    John

Re: [wxlua-users] Crash on lua_close() [was: Using wxLua with Lua 5.0.2]

[Paul K <pau...@ya...>]

Hi Andreas,

> So somebody who knows the internals of wxLua & wxWidgets should
> probably be able to find the problem pretty quickly. For me it's complicated
> because I hardly know anything about C++. I have 15+ years of experience in
> plain C but C++ still makes me shiver :) That's why it's very hard for me to
> find out what's actually going on here.

I'm in a similar situation. I'm sure John L reads the maillist, but he
may not be able to respond right away.

> Ok, maybe I'll try it with mingw but I can hardly believe that the problem
> is with Visual C...

I tend to agree, especially given that it still crashes for me in some
cases. You may want to re-compile using the latest trunk to see if it
makes it any better as I tend to work with the latest versions of
wxlua.

Paul.

[wxlua-users] Crash on lua_close() [was: Using wxLua with Lua 5.0.2]

[Andreas F. <an...@fa...>]

Hi Paul,

On 09.08.2013 at 22:08 Paul K wrote:

> Hi Andreas,

>> But of course that's not really a solution for me because the crash
>> in lua_close() tells me that there is something going wrong... it doesn't
>> happen with the official builds of wxLua for Windows. This is why I'm even
>> more curious what could be the cause for this crash... any other ideas?

> I agree; I don't like that either, but couldn't track down the source
> of the issue.

Do the maintainers of wxLua follow this list and is there a chance that
they look into such issues? I think the test case I uploaded to 

http://www.falkenhahn.com/tmp/wxLua.zip

is quite straight-forward because it uses unmodified versions of Lua 5.1
and wxLua. So somebody who knows the internals of wxLua & wxWidgets should
probably be able to find the problem pretty quickly. For me it's complicated
because I hardly know anything about C++. I have 15+ years of experience in
plain C but C++ still makes me shiver :) That's why it's very hard for me to
find out what's actually going on here.

All I can see is that the code that deletes the objects from inside the
class destructors makes wxLua crash. And this code is called by lua's
garbage collector during lua_close().

> FWIW, the veryminimal sample doesn't crash for me using wx.dll I
> compiled using this batch script
> (https://github.com/pkulchenko/ZeroBraneStudio/blob/master/build/build-win32.sh);
> I actually have binaries for all the platforms and they handle samples
> without issues
> (https://github.com/pkulchenko/ZeroBraneStudio/tree/master/bin).
> I use mingw though vs. your VS.

> This is compiled using wxlua and wxwidgets versions as of April with a
> couple of tweaks to wxlua that I documented in the build script. It
> does still crash though in some other cases, so I do have os.exit in
> my application as well.

Ok, maybe I'll try it with mingw but I can hardly believe that the problem
is with Visual C...

-- 
Best regards,
 Andreas Falkenhahn                            mailto:an...@fa...

Re: [wxlua-users] Using wxLua with Lua 5.0.2

[Paul K <pau...@ya...>]

Hi Andreas,

> But of course that's not really a solution for me because the crash
> in lua_close() tells me that there is something going wrong... it doesn't
> happen with the official builds of wxLua for Windows. This is why I'm even
> more curious what could be the cause for this crash... any other ideas?

I agree; I don't like that either, but couldn't track down the source
of the issue.

FWIW, the veryminimal sample doesn't crash for me using wx.dll I
compiled using this batch script
(https://github.com/pkulchenko/ZeroBraneStudio/blob/master/build/build-win32.sh);
I actually have binaries for all the platforms and they handle samples
without issues (https://github.com/pkulchenko/ZeroBraneStudio/tree/master/bin).
I use mingw though vs. your VS.

This is compiled using wxlua and wxwidgets versions as of April with a
couple of tweaks to wxlua that I documented in the build script. It
does still crash though in some other cases, so I do have os.exit in
my application as well.

Paul.

On Fri, Aug 9, 2013 at 11:48 AM, Andreas Falkenhahn
<an...@fa...> wrote:
> Hi Paul,
>
> On 09.08.2013 at 18:55 Paul K wrote:
>
>> Hi Andreas,
>
>> I remember seeing similar crashes (I'm using with Lua 5.1 with
>> wxwidgets 2.9.5 and wxlua trunk from April or so). Not a solution, but
>> maybe a workaround for you: before exiting your application call
>> os.exit().
>
> True, inserting the following code in veryminimal.wx.lua makes the crash
> go away:
>
>     frame:Connect(wx.wxEVT_CLOSE_WINDOW, function(event) os.exit() end)
>
> But of course that's not really a solution for me because the crash
> in lua_close() tells me that there is something going wrong... it doesn't
> happen with the official builds of wxLua for Windows. This is why I'm even
> more curious what could be the cause for this crash... any other ideas?
>
> Thanks
>
> --
> Best regards,
>  Andreas Falkenhahn                            mailto:an...@fa...
>
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite!
> It's a free troubleshooting tool designed for production.
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
> _______________________________________________
> wxlua-users mailing list
> wxl...@li...
> https://lists.sourceforge.net/lists/listinfo/wxlua-users

Re: [wxlua-users] New Bindings etc.

[klaas.holwerda <ng...@kl...>]

Hi John,

Still you broad me the solution :-)
Because libwxlua-wx28gtk2ud-2.8.12.a was not part of my command line.
Don't understand that i oversaw it so many times :-(
With wxLua_LUA_LIBRARY_BUILD_SHARED set false, wxart2d compiles and runs again, when order is indeed 
as you mentioned.
But maybe that is not even needed now, will check again without it and also the -fPIC.

For the rest i had to remove "media" from the CmakeLists file, since it did not work in wxWidgest 
right away also.
After that i need to first clear the cmake cache, else somehow it does not believe it, and gives an 
error still.

All in all nice improvements.
The Unix and windows libs are now named almost the same, makes it easier.
The bindings can now much easier be extended.
Maybe the default install location can be set to /usr/local on unix.
Just wondering if you already have something to compare them to the interface header files of wx?
Or is using them the next step :-)

Thanks for all the work, wxLua rocks!

Klaas



On 08/09/2013 06:11 AM, John Labenski wrote:
> On Thu, Aug 8, 2013 at 5:58 PM, klaas.holwerda <ng...@kl... 
> <mailto:ng...@kl...>> wrote:
>
>     Hi John,
>
>     I managed to update wxArt2D to use the new binding rules.
>
>
> Great, hopefully it wasn't too hard and the benefit is that the binding headers are now valid C++ 
> code, though they need to be very simple.
>
>     On windows all works again.
>     On Linux (Centos 6.4 and openSuse12.3) i am able to compile and install wxLua. (-fPIC stilled
>     needed for wxWidgest2.9.5)
>
>
> I use Centos 6 and I didn't need to add -fPIC to either building wxWidgets or wxLua. Do you 
> remember what you added -fPIC to?
>
>     Also i am able to compile wxArt2D with wxLua within again.
>     Now i need to link and i get this the errors down here.
>     I build wxLua with BUILD_SHARED_LIBS disabled, and debug.
>
>     I have the libraries, the libwxlua_lua51-wx29gtk2ud-2.8.12.so
>     <http://libwxlua_lua51-wx29gtk2ud-2.8.12.so> is not static it seems, don't know why?
>
>
>
> I made the static build also optionally build the shared libwx.so, for Lua's require("wx"), and 
> this needs a shared Lua lib. You can also make this static by setting 
> wxLua_LUA_LIBRARY_BUILD_SHARED=TRUE.
>
>     klaas@dhcppc2:/usr/local/lib> ls libwxlua*
>     libwxlua_bind-wx29gtk2ud-2.8.12.a libwxlua_debugger-wx29gtk2ud-2.8.12.a
>     libwxlua_debug-wx29gtk2ud-2.8.12.a libwxlua_lua51-wx29gtk2ud-2.8.12.so
>     <http://libwxlua_lua51-wx29gtk2ud-2.8.12.so> libwxlua-wx29gtk2ud-2.8.12.a
>
>     Do you see something wrong? Like order of libraries to link, or maybe a missing library??
>     I know they are there several times, but normally that does not cause problems, although order
>     of libraries did before.
>
>
> It looks ok, this would be the ideal order of the libs.
>
> wxart2d libs
> libwxlua_bind-wx28gtk2ud-2.8.12.a
> libwxlua_debugger-wx28gtk2ud-2.8.12.a
> libwxlua_debug-wx28gtk2ud-2.8.12.a
> libwxlua-wx28gtk2ud-2.8.12.a
> libwxlua_lua51-wx28gtk2ud-2.8.12.so <http://libwxlua_lua51-wx28gtk2ud-2.8.12.so>
> wxwidgets libs
> libpng etc.
>
> The only thing I can really suggest is to do the clean and rebuild thing and hope it fixes it. The 
> functions you're missing are in libwxlua-wx28gtk2ud-2.8.12.a, which is the main wxLua lib.
>
> Regards,
>      John
>
>
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite!
> It's a free troubleshooting tool designed for production.
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>
>
> _______________________________________________
> wxlua-users mailing list
> wxl...@li...
> https://lists.sourceforge.net/lists/listinfo/wxlua-users

Re: [wxlua-users] Using wxLua with Lua 5.0.2

[Andreas F. <an...@fa...>]

Hi Paul,

On 09.08.2013 at 18:55 Paul K wrote:

> Hi Andreas,

> I remember seeing similar crashes (I'm using with Lua 5.1 with
> wxwidgets 2.9.5 and wxlua trunk from April or so). Not a solution, but
> maybe a workaround for you: before exiting your application call
> os.exit().

True, inserting the following code in veryminimal.wx.lua makes the crash
go away:

    frame:Connect(wx.wxEVT_CLOSE_WINDOW, function(event) os.exit() end)
       
But of course that's not really a solution for me because the crash
in lua_close() tells me that there is something going wrong... it doesn't
happen with the official builds of wxLua for Windows. This is why I'm even
more curious what could be the cause for this crash... any other ideas?

Thanks

-- 
Best regards,
 Andreas Falkenhahn                            mailto:an...@fa...

Re: [wxlua-users] Using wxLua with Lua 5.0.2

[Paul K <pau...@ya...>]

Hi Andreas,

I remember seeing similar crashes (I'm using with Lua 5.1 with
wxwidgets 2.9.5 and wxlua trunk from April or so). Not a solution, but
maybe a workaround for you: before exiting your application call
os.exit().

Paul.

On Fri, Aug 9, 2013 at 8:36 AM, Andreas Falkenhahn
<an...@fa...> wrote:
> Hmm, I tried it now using Lua 5.1 and it crashes as well.... could it be that I'm
> using a unstable version of wxLua here? I just checked out a tarball from the SVN
> because the link to the source code of 2.8.10 doesn't work anymore.
>
> http://downloads.sourceforge.net/wxlua/2.8.10.0/wxLua-2.8.10-src.tar.gz
>
> Is there any official download for the sources of 2.8.12.2?

Re: [wxlua-users] Using wxLua with Lua 5.0.2

[Andreas F. <an...@fa...>]

Here are the binary, source code and makefile for you to have a look at:

http://www.falkenhahn.com/tmp/wxLua.zip

It uses unmodified versions of Lua 5.1, wxLua 2.8.10.0 and wxWidgets 2.8.12.2 but still
it crashes on exit. The scripts themselves run fine. If you try:

win32/wxlua.exe veryminimal.wx.lua

you'll see that it runs but crashes on exit. Does anybody have an explanation for
this behaviour? I use the Visual C compiler.

On 09.08.2013 at 17:36 Andreas Falkenhahn wrote:

> Hmm, I tried it now using Lua 5.1 and it crashes as well.... could it be that I'm
> using a unstable version of wxLua here? I just checked out a tarball from the SVN
> because the link to the source code of 2.8.10 doesn't work anymore.

> http://downloads.sourceforge.net/wxlua/2.8.10.0/wxLua-2.8.10-src.tar.gz

> Is there any official download for the sources of 2.8.12.2?

> On 09.08.2013 at 15:37 Andreas Falkenhahn wrote:

>> Hi,

>> I need to get wxLua running with Lua 5.0.2. I think I made all the necessary
>> changes and I have it basically working now but at the end when lua_close()
>> is called on the lua_State it always crashes.

>> Digging deeper into the issue, I found out that the destructor functions invoked
>> by the garbage collector are always the cause for this crash. Most of the time
>> it crashes in the destructor for
>> wxLua_wxGridCellCoords_delete_function() which
>> looks like this:

>> void wxLua_wxGridCellCoords_delete_function(void** p)
>> {
>>     wxGridCellCoords* o = (wxGridCellCoords*)(*p);
>>     delete o;
>> }

>> Precisely, the crash always occurs in the call to "delete".

>> However, it doesn't always crash in the destructor of wxGridCellCoords class.
>> Sometimes it also crashes in the destructor of wxBrush, wxImage, wxAcceleratorTable,
>> etc. But it always crashes in one of the destructor functions!

>> Could this have something to do with my adaptation for Lua 5.0? I know that
>> there have been huge improvements in the garbage collector in Lua 5.1 and maybe
>> wxLua depends on some 5.1 garbage collector feature that isn't there in my 5.0
>> version? Could this be the cause of these strange crashes on lua_close()?

>> Thanks for some feedback!





-- 
Best regards,
 Andreas Falkenhahn                            mailto:an...@fa...

Re: [wxlua-users] Using wxLua with Lua 5.0.2

[Andreas F. <an...@fa...>]

Hmm, I tried it now using Lua 5.1 and it crashes as well.... could it be that I'm
using a unstable version of wxLua here? I just checked out a tarball from the SVN
because the link to the source code of 2.8.10 doesn't work anymore.

http://downloads.sourceforge.net/wxlua/2.8.10.0/wxLua-2.8.10-src.tar.gz

Is there any official download for the sources of 2.8.12.2?

On 09.08.2013 at 15:37 Andreas Falkenhahn wrote:

> Hi,

> I need to get wxLua running with Lua 5.0.2. I think I made all the necessary
> changes and I have it basically working now but at the end when lua_close()
> is called on the lua_State it always crashes.

> Digging deeper into the issue, I found out that the destructor functions invoked
> by the garbage collector are always the cause for this crash. Most of the time
> it crashes in the destructor for
> wxLua_wxGridCellCoords_delete_function() which
> looks like this:

> void wxLua_wxGridCellCoords_delete_function(void** p)
> {
>     wxGridCellCoords* o = (wxGridCellCoords*)(*p);
>     delete o;
> }

> Precisely, the crash always occurs in the call to "delete".

> However, it doesn't always crash in the destructor of wxGridCellCoords class.
> Sometimes it also crashes in the destructor of wxBrush, wxImage, wxAcceleratorTable,
> etc. But it always crashes in one of the destructor functions!

> Could this have something to do with my adaptation for Lua 5.0? I know that
> there have been huge improvements in the garbage collector in Lua 5.1 and maybe
> wxLua depends on some 5.1 garbage collector feature that isn't there in my 5.0
> version? Could this be the cause of these strange crashes on lua_close()?

> Thanks for some feedback!



-- 
Best regards,
 Andreas Falkenhahn                            mailto:an...@fa...