#2951 Installer: Set default language with MSI setup

[Tim Gerundt]

The normal setup writes to HKLM\Software\Thingamahoochie\WinMerge\Locale\LanguageId the ID from the selected language.

This patch does the same for the MSI setup. The only different is, that we just write the system language ID to the registry. If WinMerge have no language with this ID, it will fall back to English! This is a little bit lazy but also the easiest way! ;-)

Greetings,
Tim

[Tim Gerundt]

patch file

[Kimmo Varis]

The upside is that if we add new translation then people automatically get that new translation into use...

[Tim Gerundt]

Is this really a big problem? The setup wrotes the LanguageId to HKLM and the user settings are under HKCU. WinMerge only copy the HKLM tree to HKCU if it first start under the user, right?

So if the user change his language, nothing happens if we install a new WinMerge version. Only if he don't change the language in his HKCU keeps the system language ID. If a new WinMerge version includes now his system language this language will use automatically. But is that bad? :)

But maybe the best would be, if WinMerge itself try to use the system language at the first start from the user. In this case it would be also work for user that use the ZIP and not the SETUP versions from WinMerge!?

[Kimmo Varis]

My comment (upside) was meant as positive and approving comment, not negative. :)

[Tim Gerundt]

Ok, "downside" would be the negative word. Sorry for the misunderstanding! ;-)

[Tim Gerundt]

Committed to SVN (In Revision 7196)...