Menu

#2820 Add option to set wordbreak characters for highlight

Trunk
closed-accepted
None
5
2009-03-03
2009-03-02
Kimmo Varis
No

This patch adds much wanted (seems so) option to set difference highlight wordbreak characters.

The patch:
- adds new string option which keeps the characters
- sets current .,;: chars as default value for the option
- adds edit control to editor options for setting chars

The implementation (changes to stringdiff) are not cleanest possible. Actually they are quite ugly adding several static variables. But I could not find a clean way to add this kind of optionality to the strindiff without changing the API remarkably.

One important thing to consider is this must not add any performance hit. So adding the string as diff function parameter is out of question.

There is also two new unit tests for this feature making sure setting the break characters has wanted effect.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2009-03-02

    The patch

     
  • Kimmo Varis

    Kimmo Varis - 2009-03-02

    Attaching updated patch (v2). Removed change that doesn't belong to this patch.
    File Added: Option_for_wordbreak_chars_v2.patch

     
  • Kimmo Varis

    Kimmo Varis - 2009-03-02

    Updated patch V2

     
  • Kimmo Varis

    Kimmo Varis - 2009-03-02

    Feature request (one of many):
    #1565872 Allow custom word delimiters
    http://winmerge.org/rfe/1565872

     
  • Kimmo Varis

    Kimmo Varis - 2009-03-03
    • assigned_to: nobody --> kimmov
    • status: open --> closed-accepted
     
  • Kimmo Varis

    Kimmo Varis - 2009-03-03

    Committed to SVN trunk:
    Completed: At revision: 6521

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.