Menu

#2602 SplashScreen PostNcDestroy does not call base class

Trunk
closed-accepted
None
5
2008-06-26
2008-06-25
Kimmo Varis
No

While investigating bug:
#1976241 the winmerge.exe process doesn't stop itself
http://winmerge.org/bug/1976241
I found out that CSplashWnd::PostNcDestroy() does not call CWnd::PostNcDestroy() as it should since it is a virtual method.

See the document:
http://msdn.microsoft.com/en-us/library/5zba4hah\(VS.80).aspx

Index: Splash.cpp

--- Splash.cpp (revision 5522)
+++ Splash.cpp (working copy)
@@ -191,6 +191,7 @@
*/
void CSplashWnd::PostNcDestroy()
{
+ CWnd::PostNcDestroy();
delete this;
}

Discussion

  • Kimmo Varis

    Kimmo Varis - 2008-06-25

    The patch

     
  • Kimmo Varis

    Kimmo Varis - 2008-06-26

    Logged In: YES
    user_id=631874
    Originator: YES

    Committed to SVN trunk:
    Completed: At revision: 5525

    Not committing to 2.8 branch as it was reported this didn't help with the bug.

     
  • Kimmo Varis

    Kimmo Varis - 2008-06-26
    • milestone: 438015 --> Trunk
    • assigned_to: nobody --> kimmov
    • status: open --> closed-accepted
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.