webadmin-devel — The webmin development mailing list

Re: [webmin-devel] How to propose a new version of filemanager

[Jamie C. <jca...@we...>]

On Tue, 2006-02-07 at 01:36, ste...@co... wrote:
> Hi,
> 
> I modified the filemanager for a better ACL management, I would like
> to post the new file for testing.
> could you explain how I can post it.

The best way is to send me a diff of your changes, between the latest
released version of Webmin (1.260) and your updated version. That way I
can apply it to my codebase for inclusion in the next release ..

 - Jamie

[webmin-devel] How to propose a new version of filemanager

[<ste...@co...>]

Hi,

I modified the filemanager for a better ACL management, I would like to=20
post the new file for testing.
could you explain how I can post it.

thanks=20

        St=E9phane
=20
-----------------------------------
St=E9phane PURNELLE                         ste...@co...
Service Informatique       Corman S.A.           Tel : 00 32 087/342467

Re: [webmin-devel] Changes to miniserv.pl to force SSLv3/TLSv1

[Jamie C. <jca...@we...>]

On Wed, 2006-02-01 at 10:17, Jonathan Glass wrote:
> Jamie Cameron wrote:
> 
> >Hi Jonathan,
> >
> >Was the change you made just adding the line :
> >
> >eval "Net::SSLeay::CTX_set_options( $ctx,&Net::SSLeay::OP_NO_SSLv2 )";
> >
> >Probably the best way to submit changes like this is via a diff betweem
> >the old and new versions .. that way I (and the patch program) can see
> >exactly what has changed.
> >
> > - Jamie 
> >
> 
> That's all I did, working on version 1.260.  Diff report attached.

Thanks .. I will add an option in the next Webmin release to enable that
(and thus block SSL v2).

 - Jamie

Re: [webmin-devel] Changes to miniserv.pl to force SSLv3/TLSv1

[Jonathan G. <jon...@oi...>]

Jamie Cameron wrote:

>Hi Jonathan,
>
>Was the change you made just adding the line :
>
>eval "Net::SSLeay::CTX_set_options( $ctx,&Net::SSLeay::OP_NO_SSLv2 )";
>
>Probably the best way to submit changes like this is via a diff betweem
>the old and new versions .. that way I (and the patch program) can see
>exactly what has changed.
>
> - Jamie 
>

That's all I did, working on version 1.260.  Diff report attached.

Thanks

Jonathan

Re: [webmin-devel] Changes to miniserv.pl to force SSLv3/TLSv1

[Jamie C. <jca...@we...>]

Hi Jonathan,

Was the change you made just adding the line :

eval "Net::SSLeay::CTX_set_options( $ctx,&Net::SSLeay::OP_NO_SSLv2 )";

Probably the best way to submit changes like this is via a diff betweem
the old and new versions .. that way I (and the patch program) can see
exactly what has changed.

 - Jamie 

On Wed, 2006-02-01 at 04:29, Jonathan Glass wrote:
> I've made a small change to miniserv.pl to force SSLv3/TLSv1 in the 
> HTTPS server.  I'm not a developer, so don't know the correct way to 
> share this information with you, so I'll just post the code change in 
> this email.  Hopefully someone from webmin will incorporate this simple 
> change to kill off those older ciphers, or at least make it an option 
> somewhere.
> 
> Original:
> #!/usr/bin/perl
> # A very simple perl web server used by Webmin
> 
> # Require basic libraries
> package miniserv;
> use Socket;
> use POSIX;
> 
> # Find and read config file
> if (@ARGV != 1) {
> 	die "Usage: miniserv.pl <config file>";
> 	}
> if ($ARGV[0] =~ /^([a-z]:)?\//i) {
> 	$config_file = $ARGV[0];
> 	}
> else {
> 	chop($pwd = `pwd`);
> 	$config_file = "$pwd/$ARGV[0]";
> 	}
> %config = &read_config_file($config_file);
> 
> # Check is SSL is enabled and available
> if ($config{'ssl'}) {
> 	eval "use Net::SSLeay";
> 	if (!$@) {
> 		$use_ssl = 1;
> 		# These functions only exist for SSLeay 1.0
> 		eval "Net::SSLeay::SSLeay_add_ssl_algorithms()";
> 		eval "Net::SSLeay::load_error_strings()";
> 	if (defined(&Net::SSLeay::X509_STORE_CTX_get_current_cert) &&
> 		    defined(&Net::SSLeay::CTX_load_verify_locations) &&
> 		    defined(&Net::SSLeay::CTX_set_verify)) {
> 			$client_certs = 1;
> 			}
> 		}
> 
> 
> CHANGED
> #!/usr/bin/perl
> # A very simple perl web server used by Webmin
> 
> # Require basic libraries
> package miniserv;
> use Socket;
> use POSIX;
> 
> # Find and read config file
> if (@ARGV != 1) {
> 	die "Usage: miniserv.pl <config file>";
> 	}
> if ($ARGV[0] =~ /^([a-z]:)?\//i) {
> 	$config_file = $ARGV[0];
> 	}
> else {
> 	chop($pwd = `pwd`);
> 	$config_file = "$pwd/$ARGV[0]";
> 	}
> %config = &read_config_file($config_file);
> 
> # Check is SSL is enabled and available
> if ($config{'ssl'}) {
> 	eval "use Net::SSLeay";
> 	if (!$@) {
> 		$use_ssl = 1;
> 		# These functions only exist for SSLeay 1.0
> 		eval "Net::SSLeay::SSLeay_add_ssl_algorithms()";
> 		eval "Net::SSLeay::load_error_strings()";
> 		eval "Net::SSLeay::CTX_set_options( $ctx,&Net::SSLeay::OP_NO_SSLv2 )";
> 	if (defined(&Net::SSLeay::X509_STORE_CTX_get_current_cert) &&
> 		    defined(&Net::SSLeay::CTX_load_verify_locations) &&
> 		    defined(&Net::SSLeay::CTX_set_verify)) {
> 			$client_certs = 1;
> 			}
> 		}

[webmin-devel] Changes to miniserv.pl to force SSLv3/TLSv1

[Jonathan G. <jon...@oi...>]

I've made a small change to miniserv.pl to force SSLv3/TLSv1 in the 
HTTPS server.  I'm not a developer, so don't know the correct way to 
share this information with you, so I'll just post the code change in 
this email.  Hopefully someone from webmin will incorporate this simple 
change to kill off those older ciphers, or at least make it an option 
somewhere.

Original:
#!/usr/bin/perl
# A very simple perl web server used by Webmin

# Require basic libraries
package miniserv;
use Socket;
use POSIX;

# Find and read config file
if (@ARGV != 1) {
	die "Usage: miniserv.pl <config file>";
	}
if ($ARGV[0] =~ /^([a-z]:)?\//i) {
	$config_file = $ARGV[0];
	}
else {
	chop($pwd = `pwd`);
	$config_file = "$pwd/$ARGV[0]";
	}
%config = &read_config_file($config_file);

# Check is SSL is enabled and available
if ($config{'ssl'}) {
	eval "use Net::SSLeay";
	if (!$@) {
		$use_ssl = 1;
		# These functions only exist for SSLeay 1.0
		eval "Net::SSLeay::SSLeay_add_ssl_algorithms()";
		eval "Net::SSLeay::load_error_strings()";
	if (defined(&Net::SSLeay::X509_STORE_CTX_get_current_cert) &&
		    defined(&Net::SSLeay::CTX_load_verify_locations) &&
		    defined(&Net::SSLeay::CTX_set_verify)) {
			$client_certs = 1;
			}
		}


CHANGED
#!/usr/bin/perl
# A very simple perl web server used by Webmin

# Require basic libraries
package miniserv;
use Socket;
use POSIX;

# Find and read config file
if (@ARGV != 1) {
	die "Usage: miniserv.pl <config file>";
	}
if ($ARGV[0] =~ /^([a-z]:)?\//i) {
	$config_file = $ARGV[0];
	}
else {
	chop($pwd = `pwd`);
	$config_file = "$pwd/$ARGV[0]";
	}
%config = &read_config_file($config_file);

# Check is SSL is enabled and available
if ($config{'ssl'}) {
	eval "use Net::SSLeay";
	if (!$@) {
		$use_ssl = 1;
		# These functions only exist for SSLeay 1.0
		eval "Net::SSLeay::SSLeay_add_ssl_algorithms()";
		eval "Net::SSLeay::load_error_strings()";
		eval "Net::SSLeay::CTX_set_options( $ctx,&Net::SSLeay::OP_NO_SSLv2 )";
	if (defined(&Net::SSLeay::X509_STORE_CTX_get_current_cert) &&
		    defined(&Net::SSLeay::CTX_load_verify_locations) &&
		    defined(&Net::SSLeay::CTX_set_verify)) {
			$client_certs = 1;
			}
		}

-- 
Jonathan Glass, RHCE, Security+, Linux+, Network+
Information Security Engineer III
Office of Information Technology - Information Security
Georgia Institute of Technology
258 4th St NW, Atlanta, Georgia 30332-0700
Office: 404-385-6900 Fax: 404-385-2331
PGP Key ID: 0xAB50FF20
Fingerprint: 3CD2 1BC6 4485 720B AB45 FF3E 8B3B D6F5 AB50 FF20

Re: [webmin-devel] PATH_TRANSLATED environment variable in miniserv.pl

[Jamie C. <jca...@we...>]

Hi Colm,
That would work fine, as long as none of your PHP scripts depend on it. Certainly none of the Webmin CGIs need it ..

 - Jamie

-----Original Message-----

From:  Colm Dougan <col...@gm...>
Subj:  Re: [webmin-devel] PATH_TRANSLATED environment variable in miniserv.pl
Date:  Fri 13 Jan 2006 12:31 am
Size:  1K
To:  web...@li...

Hi Jamie,

On 12 Jan 2006 15:12:39 +1100, Jamie Cameron <jca...@we...> wrote:
> Thanks for pointing this out - this is definately a bug in Webmin, as it
> shouldn't even be setting PATH_TRANSLATED unless there is PATH_INFO
> data. Worse still, it was being set wrongly anyway!
>
> I never noticed this before, because none of the CGI programs in Webmin
> make use of it ..

Do you see any issues with me patching my own miniserv.pl to just
never define PATH_TRANSLATED as a stopgap solution until a better
patch is found?  It seems to work fine and AFAICS it would not break
any of my existing webmin perl CGIs because none of those or the
associated webmin perl libraiers seem to use PATH_TRANSLATED.

Thanks,
Colm


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id865&opÌk
-
Forwarded by the Webmin development list at web...@we...
To remove yourself from this list, go to
http://lists.sourceforge.net/lists/listinfo/webadmin-devel

Re: [webmin-devel] PATH_TRANSLATED environment variable in miniserv.pl

[Colm D. <col...@gm...>]

Hi Jamie,

On 12 Jan 2006 15:12:39 +1100, Jamie Cameron <jca...@we...> wrote:
> Thanks for pointing this out - this is definately a bug in Webmin, as it
> shouldn't even be setting PATH_TRANSLATED unless there is PATH_INFO
> data. Worse still, it was being set wrongly anyway!
>
> I never noticed this before, because none of the CGI programs in Webmin
> make use of it ..

Do you see any issues with me patching my own miniserv.pl to just
never define PATH_TRANSLATED as a stopgap solution until a better
patch is found?  It seems to work fine and AFAICS it would not break
any of my existing webmin perl CGIs because none of those or the
associated webmin perl libraiers seem to use PATH_TRANSLATED.

Thanks,
Colm

Re: [webmin-devel] PATH_TRANSLATED environment variable in miniserv.pl

[Jamie C. <jca...@we...>]

On Thu, 2006-01-12 at 14:56, Colm Dougan wrote:
> Hi,
> 
> I was trying to run a php script I obtained as a CGI using a php4
> binary with miniserv.pl but kept running into the "No input file
> specified" error message.
> 
> After a bit of Googling I found that a common problem withr running
> php CGIs in this way is that the SCRIPT_FILENAME enviroment variable
> may not have been defined - however I see that this is defined in
> miniserv.pl after some discussion of this I found in the archives [1].
>  Anyway - that wasn't my problem, just a bit of backgroud.
> 
> I traced the C code of the php4 binary when running my php CGI until I
> found that it was failing when doing a fstat() on a filename it had
> opened which turned out to be a directory and not a file as expected. 
> It turns out it is basing this on the PATH_TRANSLATED environment
> variable which miniserv.pl had defined as the same as my document
> root.
> 
> I had a look at the CGI spec [2] which stated the following for
> PATH_TRANSLATED :
> 
>   PATH_TRANSLATED is derived by taking any path-info component
>   of the request URI (see section 6.1.6), decoding it (see
>   section 3.1), parsing it as a URI in its own right, and
>   performing any virtual-to-physical translation appropriate to
>   map it onto the server's document repository structure. If the
>   request URI includes no path-info component, the
>   PATH_TRANSLATED metavariable SHOULD NOT be defined.
> 
> I found the last bit interesting so I tried editing miniserv.pl to not
> define PATH_TRANSLATED and suddenly everything started working.  So -
> is it possible that PATH_TRANSLATED is not being defined correctly
> here, or iare there cases where it should not be defined as seems to
> be being suggested here?

Hi Colm,
Thanks for pointing this out - this is definately a bug in Webmin, as it
shouldn't even be setting PATH_TRANSLATED unless there is PATH_INFO
data. Worse still, it was being set wrongly anyway!

I never noticed this before, because none of the CGI programs in Webmin
make use of it ..

 - Jamie

[webmin-devel] PATH_TRANSLATED environment variable in miniserv.pl

[Colm D. <col...@gm...>]

Hi,

I was trying to run a php script I obtained as a CGI using a php4
binary with miniserv.pl but kept running into the "No input file
specified" error message.

After a bit of Googling I found that a common problem withr running
php CGIs in this way is that the SCRIPT_FILENAME enviroment variable
may not have been defined - however I see that this is defined in
miniserv.pl after some discussion of this I found in the archives [1].
 Anyway - that wasn't my problem, just a bit of backgroud.

I traced the C code of the php4 binary when running my php CGI until I
found that it was failing when doing a fstat() on a filename it had
opened which turned out to be a directory and not a file as expected.=20
It turns out it is basing this on the PATH_TRANSLATED environment
variable which miniserv.pl had defined as the same as my document
root.

I had a look at the CGI spec [2] which stated the following for
PATH_TRANSLATED :

  PATH_TRANSLATED is derived by taking any path-info component
  of the request URI (see section 6.1.6), decoding it (see
  section 3.1), parsing it as a URI in its own right, and
  performing any virtual-to-physical translation appropriate to
  map it onto the server's document repository structure. If the
  request URI includes no path-info component, the
  PATH_TRANSLATED metavariable SHOULD NOT be defined.

I found the last bit interesting so I tried editing miniserv.pl to not
define PATH_TRANSLATED and suddenly everything started working.  So -
is it possible that PATH_TRANSLATED is not being defined correctly
here, or iare there cases where it should not be defined as seems to
be being suggested here?

Thanks,
Colm

[1] http://lists.swelltech.com/pipermail/webmin-devel-archive/2002-October/=
000750.html
[2] http://cgi-spec.golux.com/draft-coar-cgi-v11-03.txt

Re: [webmin-devel] Patch #1350027: Fix for file descriptor leak

[Jamie C. <jca...@we...>]

Glad to .. this will be included in the next Webmin release.
If you have any other patches, it is best to email them to me directly,
as I check my email more often than the Sourceforge patches list :)

 - Jamie

On Wed, 2006-01-04 at 00:08, Peter Åstrand wrote:
> Can someone please apply patch #1350027? 
> (http://sourceforge.net/tracker/index.php?func=detail&aid=1350027&group_id=17457&atid=317457)
> 
> Also, I wonder about the SF CVS repository: The only version I can find there 
> is 1.160. Why?
> 
> Regards,

Re: [webmin-devel] Patch #1350027: Fix for file descriptor leak

[Martin M. <mm...@me...>]

Moin, moin ...

Peter =C5strand <as...@ce...> wrote:

>
>Can someone please apply patch #1350027?=20
>(http://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D1350027&gr=
oup_id=3D17457&atid=3D317457)
>
>Also, I wonder about the SF CVS repository: The only version I can find =
there=20
>is 1.160. Why?

The reason is simple: I started to maintain the CVS sometime ago, but due=
 to
lack of space at SF and time here I stopped maintaining. Another reason =
is
that the usage of the SF-CVS is reaching zero users per year.
bis dahin / kind regards

Martin Mewes

--=20
Martin Mewes - MCP 070-291
http://www.mewes.tv/ - Homepage
http://mbox.mewes.tv/ - Mailinglisten zum Downloaden

[webmin-devel] Patch #1350027: Fix for file descriptor leak

[<as...@ce...>]

Can someone please apply patch #1350027? 
(http://sourceforge.net/tracker/index.php?func=detail&aid=1350027&group_id=17457&atid=317457)

Also, I wonder about the SF CVS repository: The only version I can find there 
is 1.160. Why?

Regards,
-- 
Peter Åstrand		ThinLinc Chief Developer
Cendio			www.cendio.se
Teknikringen 3
583 30 Linköping        Phone: +46-13-21 46 00

[webmin-devel] [FAQ] Webmin/Usermin - Translation - Monthly HOWTO

[<mm...@me...>]

######################################################################
Webmin/Usermin - Translation - Monthly HOWTO
Webmin Translation Team - Last changed: 05.12.2005
Sent with Usermin's "Scheduled Mail"-Module
######################################################################

History:
--------
01.12.2005
Webmin-Version 1.250 released as stable
Usermin-Version 1.180 released as stable
Virtualmin-Development-Version 2.609 released

29.11.2005
Webmin-Development-Version 1.249 released
Usermin-Development-Version 1.179 released

03.05.2005
Virtualmin-Version 2.60 released as stable

######################################################################

Current Stable Release for Webmin is 1.250
http://webmin.mamemu.de/devel/tarballs/webmin-1.250.tar.gz
http://webmin.mamemu.de/devel/tarballs/webmin-1.250-1.noarch.rpm
http://webmin.mamemu.de/devel/tarballs/webmin-1.250-minimal.tar.gz

Current Development Release for Webmin is 1.250
http://webmin.mamemu.de/devel/tarballs/webmin-1.250.tar.gz

Current Stable Release for Usermin is 1.180
http://webmin.mamemu.de/devel/tarballs/usermin-1.180.tar.gz
http://webmin.mamemu.de/devel/tarballs/usermin-1.180-1.noarch.rpm

Current Development Release for Usermin is 1.180
http://webmin.mamemu.de/devel/tarballs/usermin-1.180.tar.gz

Current Stable Release for VirtualMin is 2.60
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.60.wbm.gz

Current Development Release for VirtualMin is 2.609
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.609.wbm.gz
	
######################################################################

Administrative:
---------------

The Webmin Translation Team suggests, that you use the wbmtranslator
as the main tool for your translations you want to provide to the
Webmin Translation Team.
Stuff done with wbmtranslator will be processed at a higher level.

Current release: 0.6.0 (2005/05/19)
http://wbmtranslator.labs.libre-entreprise.org/wbmtranslator.wbm.gz

Virtualmin has gone Virtualmin Pro:
Jamie Cameron and Joe Cooper founded Virtualmin Inc.
Please visit: http://www.virtualmin.com/ for details

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

E-Mail-Address for sending in translations to Webmin has changed.
Please send in all stuff to

	tra...@we...

in the future.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

######################################################################
Original: http://webmin.mamemu.de/modules.html#newlang
######################################################################

TOC:

1.	Adding New Languages to Webmin
2.	Using wbmtranslator
3.	Is there a way to use localization when developing
	a new theme?
4.	Special Hint

######################################################################

1.	Adding New Languages to Webmin

New translations of the existing core Webmin modules are always
welcome. If you want to translate Webmin into a new language or update
one of the existing translations, follow these steps : 
Get the latest development version of Webmin so that you can see the
latest translations that have been done by other people. 

In the file lang_list.txt in the Webmin root directory, add a new line
for your language like :

lang=sw,titles=1,charset=iso-6666-6 Swahili

The "lang" part defines the short code for the language, and should
follow the ISO standard where possible. The "titles" part controls
whether Webmin should use letter images for displaying page titles in
the language, and should be set to 1 if your language uses european
characters. The optional "charset" part sets the character set that is
sent to the web browser when using the language, so that is can
automatically select the right font to use. 

Switch to your new language in the Webmin Configuration module under
the Language icon. 

In the directory lang under the Webmin root and in each of the lang
subdirectories under the module directories, create a new file called
sw (or whatever the short code for your language is) that is a
translation of the en file in the same directory. 

In each of the module.info files under the module directories, add a
new desc_sw= line that is a translation of the desc= line. 

In each of the module directories, create a new file called
config.info.sw which is a translation of config.info (if it exists). 

In the help subdirectory under each of the module directories (where
they exist), translate all of the something.html files into
something.sw.html. 

A table of currently translated languages is available so that you can
see how much has been done for each language and module so far. There
is also a list of other translators that you might want to contact
before doing your own translation work. 
You don't have to finish translating the entire of Webmin for your
translation to be useful. Many people just do a few modules at a time,
or skip the help pages initially. 

When your translation has made some progress, send a .tar.gz file of
all the translated files to the Webmin Translation Team at

          tra...@we...

so that they can include it in the main Webmin distribution. The best
way to tar up everything is with the command :

tar czf /tmp/translation.tar.gz \
       */lang/sw lang/sw */module.info \
       */config.info.sw */help/*.sw.html

######################################################################

2.	Using wbmtranslator

This is a module by Emmanuel Saracco which can be downloaded here:

http://labs.libre-entreprise.org/projects/wbmtranslator/

It consists of an easy to use webinterface in order to update
current translations or setup new languages. Last not least it
enables you to officially send in translations to the Webmin
Translation Team at

	tra...@we...

######################################################################

3.	Is there a way to use localization when developing
	a new theme?
	
Yes (by Jamie Cameron)
There is a way to do this - create a lang/ subdirectory under your
theme with the usual en, de and other files. Then in your theme CGIs
or .pl, use code like :

%mytext = &load_language("my-theme-directory");
print "<b>$mytext{'something'}</b> <p>\n";

######################################################################

4.	Special hint

/usr/libexec/webmin/lang/en

<original>
feedback_desc2=This feedback will be sent to the developer of Webmin,
not your system administrator, ISP or hosting company. Please write
your feedback in english, even if you are currently running Webmin in
another language.
</original>

You should add the following (after translating it into your
language).

<br>If you have a question or a request on the <u>Arabic
Transalation</u>, please send a feedback <u>only</u> to
<u>tra...@we...</u>.

Complete line:
feedback_desc2=This feedback will be sent to the developer of Webmin,
not your system administrator, ISP or hosting company. Please write
your feedback in english, even if you are currently running Webmin in
another language.<br>If you have a question or a request on the
<u>Arabic Transalation</u>, please send a feedback <u>only</u> to
<u>tra...@we...</u>.

And please do not forget to set proper HTML-Entities!
If you want to take care of the translations yourself you may strip
off tra...@we... and replace it with your own eMail-Adress.

bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/		| Webbased Administration Tool for
http://webmin.mamemu.de/	| Unixoid Systems :-)
Webmin Translation Team
######################################################################

Re: [webmin-devel] making config change to existing module, addingpopup"selectusers" list

[Jamie C. <jca...@we...>]

On 14/Dec/2005 02:40 Mr Duck wrote ..
> Jamie Cameron wrote:
> >>   return
> >>       $preta .
> >>       $config{'ignore_users'} .
> >>       $postta .
> >>       ' ' .
> >>       &user_chooser_button("ignore_users", 1);
> > I have one suggestion here - change the $config{'ignore_users'} to $_[0]
> 
>    OK.  I did so, and it works now. (= When I originally implemented

Excellent!

> the function, I had it displaying all values to @_ to see if anything
> was passed in, but since I didn't have a value yet, nothing was shown,
> and I mistakenly assumed that nothing was passed in.  Slap my hand!
> (=
> 
>    Anyway, it works now, and splendidly I must say.  AFAIK, these changes
> satisfy your given requirements of "well written, don't break anything,
> and optional".
> 
>    The only thing that I _don't_ have, however, is multi-language
> config.info files. (=

I wouldn't worry too much .. Webmin will just display the english text
if no translation exists in the user's language.

>    Is there anything else that you suggest I do/check/examine/etc
> before I pass the patches and stuff on to you?

I can't really think of any.. but send me the patch, and I will tell you
if anything is missing or needs changing.

 - Jamie

Re: [webmin-devel] making config change to existing module, addingpopup"select users" list

[Mr D. <tl...@co...>]

Jamie Cameron wrote:
>>   return
>>       $preta .
>>       $config{'ignore_users'} .
>>       $postta .
>>       ' ' .
>>       &user_chooser_button("ignore_users", 1);
> I have one suggestion here - change the $config{'ignore_users'} to $_[0]

   OK.  I did so, and it works now. (= When I originally implemented
the function, I had it displaying all values to @_ to see if anything
was passed in, but since I didn't have a value yet, nothing was shown,
and I mistakenly assumed that nothing was passed in.  Slap my hand!
(=

   Anyway, it works now, and splendidly I must say.  AFAIK, these changes
satisfy your given requirements of "well written, don't break anything,
and optional".

   The only thing that I _don't_ have, however, is multi-language
config.info files. (=

   Is there anything else that you suggest I do/check/examine/etc
before I pass the patches and stuff on to you?

   Thanks!

Mr Duck

Re: [webmin-devel] making config change to existing module, addingpopup"select users" list

[Jamie C. <jca...@we...>]

On 10/Dec/2005 09:05 Mr Duck wrote ..
> Jamie Cameron wrote:
> > That looks OK to me. What does the show__userIgnoreList function contain
> > though?
> 
>    It's pretty straight-forward.
> 
> ----CODE----
> 
> sub show_userIgnoreList
> {
>    my($preta)  = '<TEXTAREA NAME="ignore_users" COLS="35" ROWS="4">';
>    my($postta) = '</TEXTAREA>';
> 
>    return
>        $preta .
>        $config{'ignore_users'} .
>        $postta .
>        '&nbsp;' .
>        &user_chooser_button("ignore_users", 1);
> }
> 
> ----END-----

I have one suggestion here - change the $config{'ignore_users'} to $_[0]

>    I have noticed in the interim that the webmin/conf/mailboxes/config
> file does get updated when I save changes using the previously given
> parse_ function.  However, the webmin/mailboxes/config file does not.
> 
>    As of this point, I don't know the different between the two.

The file /etc/webmin/mailboxes/config is the currently active config, while
/usr/libexec/webmin/mailboxes/config is the initial default config (which is never changed).

 - Jamie

Re: [webmin-devel] making config change to existing module, addingpopup "select users" list

[Mr D. <tl...@co...>]

Jamie Cameron wrote:
> That looks OK to me. What does the show__userIgnoreList function contain
> though?

   It's pretty straight-forward.

----CODE----

sub show_userIgnoreList
{
   my($preta)  = '<TEXTAREA NAME="ignore_users" COLS="35" ROWS="4">';
   my($postta) = '</TEXTAREA>';

   return
       $preta .
       $config{'ignore_users'} .
       $postta .
       '&nbsp;' .
       &user_chooser_button("ignore_users", 1);
}

----END-----

   I have noticed in the interim that the webmin/conf/mailboxes/config
file does get updated when I save changes using the previously given
parse_ function.  However, the webmin/mailboxes/config file does not.

   As of this point, I don't know the different between the two.

Mr Duck

Re: [webmin-devel] making config change to existing module, addingpopup "select users" list

[Jamie C. <jca...@we...>]

On 10/Dec/2005 07:20 Mr Duck wrote ..
> Jamie Cameron wrote:
> >>   Basically, I want to provide a listing of usernames that
> >>will _not_ be listed in the Read User Mail user list.  For example,
> > That's a good idea for a feature..
> 
>    Thanks!  I wasn't expecting a reply from you directly... (=
> I use this module (mailboxes) more than anything else, and so
> the types of changes that I mentioned are very beneficial to me.
>   I would think that others might find them as useful, too.

I agree .. there are heaps of system users like bin, uucp, etc.. that
will never have mail.

> > The only way to do this is to implement your own custom config field
> > type, which is documented at http://www.webmin.com/modules-config.html
> > in the section on config type 15.
> 
>    Ok, I've been experimenting, and have a pretty good understanding
> of what is needed.  I've already added the config.info entries to
> implement the three items, including the type 15 for the userlist.
> I've written a working config_info.pl sub that handles the actual
> user selection, which all was easy to implement, thanks to the
> flexibility of the webmin layout.
> 
>    The only part that is giving me troubles is when it comes to the
> save part.  I don't quite follow what this means:
> -----------------------
> When saving, a function with parse_ is called instead. It can make use
> of the %in hash to find out what the user entered, and must return a new
> value for this module configuration setting.
> -----------------------
> 
>    The part that specifically confuses me is the "new value" stuff
> that is returned.  From what I can tell, the parse_ function simply
> needs to return the new value of the config item.  So, I wrote the
> sub as:
> 
> ---CODE----
> 
> sub parse_userIgnoreList
> {
>    return $in{'ignore_users'};
> }
> 
> ---END-----
> 
> But nothing was saved.  I see where in config_save.cgi the
> config_info.pl is checked, but when it comes to the foreign_call,
> I don't really follow what is happening with the data that the
> parse_ function returns.

That looks OK to me. What does the show__userIgnoreList function contain
though?
 
> > As long as your changes are well written, don't break any existing
> > functionality, and are optional, I would be glad to include them in the
> > module.
> 
>    I really appreciate your encouragement and openness.  Once I get
> the saving thing figured out, how should I go about getting the
> changes to you for examination?  Should I tgz the files involved
> or provide patches or what?

A patch is best, as it is easier to merge..

 - Jamie

Re: [webmin-devel] making config change to existing module, adding popup "select users" list

[Mr D. <tl...@co...>]

Jamie Cameron wrote:
>>   Basically, I want to provide a listing of usernames that
>>will _not_ be listed in the Read User Mail user list.  For example,
> That's a good idea for a feature..

   Thanks!  I wasn't expecting a reply from you directly... (=
I use this module (mailboxes) more than anything else, and so
the types of changes that I mentioned are very beneficial to me.
  I would think that others might find them as useful, too.

> The only way to do this is to implement your own custom config field
> type, which is documented at http://www.webmin.com/modules-config.html
> in the section on config type 15.

   Ok, I've been experimenting, and have a pretty good understanding
of what is needed.  I've already added the config.info entries to
implement the three items, including the type 15 for the userlist.
I've written a working config_info.pl sub that handles the actual
user selection, which all was easy to implement, thanks to the
flexibility of the webmin layout.

   The only part that is giving me troubles is when it comes to the
save part.  I don't quite follow what this means:
-----------------------
When saving, a function with parse_ is called instead. It can make use 
of the %in hash to find out what the user entered, and must return a new 
value for this module configuration setting.
-----------------------

   The part that specifically confuses me is the "new value" stuff
that is returned.  From what I can tell, the parse_ function simply
needs to return the new value of the config item.  So, I wrote the
sub as:

---CODE----

sub parse_userIgnoreList
{
   return $in{'ignore_users'};
}

---END-----

But nothing was saved.  I see where in config_save.cgi the
config_info.pl is checked, but when it comes to the foreign_call,
I don't really follow what is happening with the data that the
parse_ function returns.

> As long as your changes are well written, don't break any existing
> functionality, and are optional, I would be glad to include them in the
> module.

   I really appreciate your encouragement and openness.  Once I get
the saving thing figured out, how should I go about getting the
changes to you for examination?  Should I tgz the files involved
or provide patches or what?

Thanks again!

Mr Duck

Re: [webmin-devel] making config change to existing module, adding popup "select users" list

[Jamie C. <jca...@we...>]

On Fri, 2005-12-09 at 09:52, Mr Duck wrote:
> All,
> 
>    I am a perl programmer, and am making some modifications
> to the mailboxes/Read User Mail module, which I use to keep
> an eye on virus and SPAM activity for the company for which
> I work.
> 
>    Anyway, I've already implemented a few changes including
> configuration options for these changes, but there is one
> more than I want to add, and am not sure how to add the
> proper/correct config options to make it happen.
> 
>    Basically, I want to provide a listing of usernames that
> will _not_ be listed in the Read User Mail user list.  For example,
> there is no reason to show the uucp user or the games user
> or the users for the different daemons that this server runs.
> So, I want to include them in a list that will be checked
> when showing the users.

That's a good idea for a feature..

>    What I would like in the config is to have a text box and
> then a [ ... ] button that I can click which will pop up the
> user selection popup window, which will populate the textbox.
> 
>    I know how to add the textbox item to the config settings,
> and I know how to program the mailboxes_lib.pl file to ignore
> users in the list, but I don't know how to implement the
> system userlist popup button.

It would be good if the config.info format supported a multi-user
popup option type, but unfortunately it only supports a single-user
selection field at the moment.

The only way to do this is to implement your own custom config field
type, which is documented at http://www.webmin.com/modules-config.html
in the section on config type 15.

>    Is this clear?  Is there a way to do this from within a
> config option?
> 
>    Please ask questions if more information is needed.
> 
>    One other thing to ask:
> 
>    The things I'm adding basically allow the admin to change how
> many columns the usernames get listed in, if the admin wants the
> size of the mailbox to be listed below the username instead,
> and then the ignore list for users not to show.
> 
>    What is the likelihood that Jamie would be willing to
> (or want to) incorporate these changes into the module?

As long as your changes are well written, don't break any existing
functionality, and are optional, I would be glad to include them in the
module.

 - Jamie

[webmin-devel] making config change to existing module, adding popup "select users" list

[Mr D. <tl...@co...>]

All,

   I am a perl programmer, and am making some modifications
to the mailboxes/Read User Mail module, which I use to keep
an eye on virus and SPAM activity for the company for which
I work.

   Anyway, I've already implemented a few changes including
configuration options for these changes, but there is one
more than I want to add, and am not sure how to add the
proper/correct config options to make it happen.

   Basically, I want to provide a listing of usernames that
will _not_ be listed in the Read User Mail user list.  For example,
there is no reason to show the uucp user or the games user
or the users for the different daemons that this server runs.
So, I want to include them in a list that will be checked
when showing the users.

   What I would like in the config is to have a text box and
then a [ ... ] button that I can click which will pop up the
user selection popup window, which will populate the textbox.

   I know how to add the textbox item to the config settings,
and I know how to program the mailboxes_lib.pl file to ignore
users in the list, but I don't know how to implement the
system userlist popup button.

   Is this clear?  Is there a way to do this from within a
config option?

   Please ask questions if more information is needed.

   One other thing to ask:

   The things I'm adding basically allow the admin to change how
many columns the usernames get listed in, if the admin wants the
size of the mailbox to be listed below the username instead,
and then the ignore list for users not to show.

   What is the likelihood that Jamie would be willing to
(or want to) incorporate these changes into the module?

Thanks a bunch for your time and help!

Mr Duck

[webmin-devel] [FAQ] Webmin/Usermin/Virtualmin - On the fly updates

[Martin M. <mm...@me...>]

######################################################################

History:
--------
01.12.2005
Webmin-Version 1.250 released as stable
Usermin-Version 1.180 released as stable
Virtualmin-Development-Version 2.609 released

29.11.2005
Webmin-Development-Version 1.249 released
Usermin-Development-Version 1.179 released

03.05.2005
Virtualmin-Version 2.60 released as stable

######################################################################

Current Stable Release for Webmin is 1.250
http://webmin.mamemu.de/devel/tarballs/webmin-1.250.tar.gz
http://webmin.mamemu.de/devel/tarballs/webmin-1.250-1.noarch.rpm
http://webmin.mamemu.de/devel/tarballs/webmin-1.250-minimal.tar.gz

Current Development Release for Webmin is 1.250
http://webmin.mamemu.de/devel/tarballs/webmin-1.250.tar.gz

Current Stable Release for Usermin is 1.180
http://webmin.mamemu.de/devel/tarballs/usermin-1.180.tar.gz
http://webmin.mamemu.de/devel/tarballs/usermin-1.180-1.noarch.rpm

Current Development Release for Usermin is 1.180
http://webmin.mamemu.de/devel/tarballs/usermin-1.180.tar.gz

Current Stable Release for VirtualMin is 2.60
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.60.wbm.gz

Current Development Release for VirtualMin is 2.609
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.609.wbm.gz
	
######################################################################

Important notice:
There are three announcments for stable versions.

a) Maybe the first one comes with a "on the fly"-update.
b) Paying sourceforge-members who are subscribed to notifications
about webmin/usermin-file uploads.
c) The one and only official one comes from Jamie Cameron directly.

Virtualmin has gone Virtualmin Pro:
Jamie Cameron and Joe Cooper founded Virtualmin Inc.
Please visit http://www.virtualmin.com/ for details

If you are anoyed by these post you can filter this with procmail
scanning for

X-Webmin: update

in the header.


bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/		| Webbased Administration Tool for
http://webmin.mamemu.de/	| Unixoid Systems :-)
Webmin Translation Team
######################################################################

[webmin-devel] [FAQ] Webmin/Usermin - Translation - Monthly HOWTO

[<mm...@me...>]

######################################################################
Webmin/Usermin - Translation - Monthly HOWTO
Webmin Translation Team - Last changed: 15.11.2005
Sent with Usermin's "Scheduled Mail"-Module
######################################################################

History:
--------
15.11.2005
Webmin-Development-Version 1.247 released

28.10.2005
Virtualmin-Development-Version 2.608 released

18.10.2005
Webmin-Version 1.240 released as stable
Usermin-Version 1.170 released as stable

06.10.2005
Usermin-Development-Version 1.162 released

03.05.2005
Virtualmin-Version 2.60 released as stable

######################################################################

Current Stable Release for Webmin is 1.240
http://webmin.mamemu.de/devel/tarballs/webmin-1.240.tar.gz
http://webmin.mamemu.de/devel/tarballs/webmin-1.240-1.noarch.rpm
http://webmin.mamemu.de/devel/tarballs/webmin-1.240-minimal.tar.gz

Current Development Release for Webmin is 1.246
http://webmin.mamemu.de/devel/tarballs/webmin-1.246.tar.gz

Current Stable Release for Usermin is 1.170
http://webmin.mamemu.de/devel/tarballs/usermin-1.170.tar.gz
http://webmin.mamemu.de/devel/tarballs/usermin-1.170-1.noarch.rpm

Current Development Release for Usermin is 1.162
http://webmin.mamemu.de/devel/tarballs/usermin-1.162.tar.gz

Current Stable Release for VirtualMin is 2.60
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.60.wbm.gz

Current Development Release for VirtualMin is 2.608
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.608.wbm.gz
	
######################################################################

Administrative:
---------------

The Webmin Translation Team suggests, that you use the wbmtranslator
as the main tool for your translations you want to provide to the
Webmin Translation Team.
Stuff done with wbmtranslator will be processed at a higher level.

Current release: 0.6.0 (2005/05/19)
http://wbmtranslator.labs.libre-entreprise.org/wbmtranslator.wbm.gz

Virtualmin has gone Virtualmin Pro:
Jamie Cameron and Joe Cooper founded Virtualmin Inc.
Please visit: http://www.virtualmin.com/ for details

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

E-Mail-Address for sending in translations to Webmin has changed.
Please send in all stuff to

	tra...@we...

in the future.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

######################################################################
Original: http://webmin.mamemu.de/modules.html#newlang
######################################################################

TOC:

1.	Adding New Languages to Webmin
2.	Using wbmtranslator
3.	Is there a way to use localization when developing
	a new theme?
4.	Special Hint

######################################################################

1.	Adding New Languages to Webmin

New translations of the existing core Webmin modules are always
welcome. If you want to translate Webmin into a new language or update
one of the existing translations, follow these steps : 
Get the latest development version of Webmin so that you can see the
latest translations that have been done by other people. 

In the file lang_list.txt in the Webmin root directory, add a new line
for your language like :

lang=sw,titles=1,charset=iso-6666-6 Swahili

The "lang" part defines the short code for the language, and should
follow the ISO standard where possible. The "titles" part controls
whether Webmin should use letter images for displaying page titles in
the language, and should be set to 1 if your language uses european
characters. The optional "charset" part sets the character set that is
sent to the web browser when using the language, so that is can
automatically select the right font to use. 

Switch to your new language in the Webmin Configuration module under
the Language icon. 

In the directory lang under the Webmin root and in each of the lang
subdirectories under the module directories, create a new file called
sw (or whatever the short code for your language is) that is a
translation of the en file in the same directory. 

In each of the module.info files under the module directories, add a
new desc_sw= line that is a translation of the desc= line. 

In each of the module directories, create a new file called
config.info.sw which is a translation of config.info (if it exists). 

In the help subdirectory under each of the module directories (where
they exist), translate all of the something.html files into
something.sw.html. 

A table of currently translated languages is available so that you can
see how much has been done for each language and module so far. There
is also a list of other translators that you might want to contact
before doing your own translation work. 
You don't have to finish translating the entire of Webmin for your
translation to be useful. Many people just do a few modules at a time,
or skip the help pages initially. 

When your translation has made some progress, send a .tar.gz file of
all the translated files to the Webmin Translation Team at

          tra...@we...

so that they can include it in the main Webmin distribution. The best
way to tar up everything is with the command :

tar czf /tmp/translation.tar.gz \
       */lang/sw lang/sw */module.info \
       */config.info.sw */help/*.sw.html

######################################################################

2.	Using wbmtranslator

This is a module by Emmanuel Saracco which can be downloaded here:

http://labs.libre-entreprise.org/projects/wbmtranslator/

It consists of an easy to use webinterface in order to update
current translations or setup new languages. Last not least it
enables you to officially send in translations to the Webmin
Translation Team at

	tra...@we...

######################################################################

3.	Is there a way to use localization when developing
	a new theme?
	
Yes (by Jamie Cameron)
There is a way to do this - create a lang/ subdirectory under your
theme with the usual en, de and other files. Then in your theme CGIs
or .pl, use code like :

%mytext = &load_language("my-theme-directory");
print "<b>$mytext{'something'}</b> <p>\n";

######################################################################

4.	Special hint

/usr/libexec/webmin/lang/en

<original>
feedback_desc2=This feedback will be sent to the developer of Webmin,
not your system administrator, ISP or hosting company. Please write
your feedback in english, even if you are currently running Webmin in
another language.
</original>

You should add the following (after translating it into your
language).

<br>If you have a question or a request on the <u>Arabic
Transalation</u>, please send a feedback <u>only</u> to
<u>tra...@we...</u>.

Complete line:
feedback_desc2=This feedback will be sent to the developer of Webmin,
not your system administrator, ISP or hosting company. Please write
your feedback in english, even if you are currently running Webmin in
another language.<br>If you have a question or a request on the
<u>Arabic Transalation</u>, please send a feedback <u>only</u> to
<u>tra...@we...</u>.

And please do not forget to set proper HTML-Entities!
If you want to take care of the translations yourself you may strip
off tra...@we... and replace it with your own eMail-Adress.

bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/		| Webbased Administration Tool for
http://webmin.mamemu.de/	| Unixoid Systems :-)
Webmin Translation Team
######################################################################

[webmin-devel] [FAQ] Webmin/Usermin/Virtualmin - On the fly updates

[Martin M. <mm...@me...>]

######################################################################

History:
--------
15.11.2005
Webmin-Development-Version 1.247 released

28.10.2005
Virtualmin-Development-Version 2.608 released

18.10.2005
Webmin-Version 1.240 released as stable
Usermin-Version 1.170 released as stable

06.10.2005
Usermin-Development-Version 1.162 released

03.05.2005
Virtualmin-Version 2.60 released as stable

######################################################################

Current Stable Release for Webmin is 1.240
http://webmin.mamemu.de/devel/tarballs/webmin-1.240.tar.gz
http://webmin.mamemu.de/devel/tarballs/webmin-1.240-1.noarch.rpm
http://webmin.mamemu.de/devel/tarballs/webmin-1.240-minimal.tar.gz

Current Development Release for Webmin is 1.246
http://webmin.mamemu.de/devel/tarballs/webmin-1.246.tar.gz

Current Stable Release for Usermin is 1.170
http://webmin.mamemu.de/devel/tarballs/usermin-1.170.tar.gz
http://webmin.mamemu.de/devel/tarballs/usermin-1.170-1.noarch.rpm

Current Development Release for Usermin is 1.162
http://webmin.mamemu.de/devel/tarballs/usermin-1.162.tar.gz

Current Stable Release for VirtualMin is 2.60
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.60.wbm.gz

Current Development Release for VirtualMin is 2.608
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.608.wbm.gz
	
######################################################################

Important notice:
There are three announcments for stable versions.

a) Maybe the first one comes with a "on the fly"-update.
b) Paying sourceforge-members who are subscribed to notifications
about webmin/usermin-file uploads.
c) The one and only official one comes from Jamie Cameron directly.

Virtualmin has gone Virtualmin Pro:
Jamie Cameron and Joe Cooper founded Virtualmin Inc.
Please visit http://www.virtualmin.com/ for details

If you are anoyed by these post you can filter this with procmail
scanning for

X-Webmin: update

in the header.


bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/		| Webbased Administration Tool for
http://webmin.mamemu.de/	| Unixoid Systems :-)
Webmin Translation Team
######################################################################