webadmin-devel — The webmin development mailing list

Re: [webmin-devel] Make the Nework Configuration module IPv6 compliant

[Jamie C. <jca...@we...>]

On 25/Feb/2008 03:16 Sébastien DUCLOUX wrote ..
> Hello,
> 
> I'm new to the Webmin community and I'd like to ask you a few questions. 
> The company where I work,  B2i, would like to use Webmin to configure 
> network parameters on some machines. We've tried the "Network 
> Configuration" module and we like it. The only problem is , it is not 
> IPv6 compliant ! So we'd like to know whether a development making this 
> module IPv6 compliant is actually in progress or not .
> 
> If yes, we can help ! If not, we can develop it ourself, but before, we 
> want to ask you some questions to be sure that we have the "Webmin way 
> of thinking" ;-)
> 
>  First of all, do you think it is a better idea to make a different 
> module just for IPv6 and not modifiy the IPv4 one ? We've managed to 
> modify the IPv4 one to make it IPv6 compliant for debian OS, but to do 
> that, we had to modify common libraries (like debian-linux-lib.pl to 
> make the "check_ipaddress" method IPv6 compliant for example) :  what do 
> you think about it ?

Hi Sebastien,

At the moment, there is no work underway to make the module IPv6 compliant,
mainly because my home network is IPv4 only :-) But it would be an excellent
project, and I would be glad to include any patch that add v6 support in the
standard Webmin release.

The method I would suggest is updating the Network Configuration module to
add a new icon/page for IPv6 interfaces, which appears on systems that
support it. Alternately, you could add fields to the current list of interfaces
for IPv6 addresses, but that feels like it would only work if all interfaces
have both types of address.

By the way, don't modify the check_ipaddress function - there is already a separate
check_ipv6address that should be called as well in modules whose underlying servers
can handle v6 addresses.

 - Jamie

[webmin-devel] Make the Nework Configuration module IPv6 compliant

[Sébastien D. <seb...@b2...>]

Hello,

I'm new to the Webmin community and I'd like to ask you a few questions. 
The company where I work,  B2i, would like to use Webmin to configure 
network parameters on some machines. We've tried the "Network 
Configuration" module and we like it. The only problem is , it is not 
IPv6 compliant ! So we'd like to know whether a development making this 
module IPv6 compliant is actually in progress or not .

If yes, we can help ! If not, we can develop it ourself, but before, we 
want to ask you some questions to be sure that we have the "Webmin way 
of thinking" ;-)

 First of all, do you think it is a better idea to make a different 
module just for IPv6 and not modifiy the IPv4 one ? We've managed to 
modify the IPv4 one to make it IPv6 compliant for debian OS, but to do 
that, we had to modify common libraries (like debian-linux-lib.pl to 
make the "check_ipaddress" method IPv6 compliant for example) :  what do 
you think about it ?


Sincerely,


Sebastien DUCLOUX

Re: [webmin-devel] LDAP Users and Groups enhancements

[James S. <js...@cu...>]

On 2/24/08, Jamie Cameron <jca...@we...> wrote:
> I don't actually use any IDE - I just edit the Webmin .cgi and .pl files directly with vi. For debugging, I just use print statements :-)

If anyone knows how to attach ddd or gdb to a runnung perl process
(such as a cgi in webmin), I'd kinda like to know that. :-)

Or maybe there's a way to activate ddd from within the perl cgi???

Regards,
..jim

Re: [webmin-devel] LDAP Users and Groups enhancements

[Jamie C. <jca...@we...>]

I don't actually use any IDE - I just edit the Webmin .cgi and .pl files directly with vi. For debugging, I just use print statements :-)

 - Jamie

On 24/Feb/2008 17:29 Ivan Garcia wrote ..
> Ok, then I will proceed to develop them.
> 
> Do you recommend me any great opensource perl IDE to debug my enhancements?
> Which one do you use?
> 
> Best Regards.
> Ivan.
> 
> On Mon, Feb 25, 2008 at 5:35 AM, Jamie Cameron <jca...@we...> wrote:
> 
> > On 23/Feb/2008 22:54 Ivan Garcia wrote ..
> >
> > Hi everybody,
> >
> > My name is Ivan Garcia,spanish, I'm also developer of OpenSource
> > applications(like Subdownloader and Babiloo), mainly Python is my favorite
> > language but Perl I consider is a great choice for Shell scripts, config
> > files and in general managin Linux Systems, that's why I must say
> > congratulations for WebMin.
> >
> > Now my point is that I work for a company in Singapore that was using a
> > home-made Java software named Quro to manage Users/Groups/Computers in a
> > LDAP-Samba server(and branches). I was assigned few days ago to make
> > enhancements on this propietary Java software but after seeing the mess of
> > the outsourced code I decided to convince my bosses to use Webmin and
> > enhance the module LDAP Users and Groups to make it fit with the
> > requirements of our client. Due that Quro is not commercialized anymore and
> > we just need to pick up the best long-term solution for our client, we
> > decided to take the Webmin solution.
> >
> > Our servers are in Suse Linux Entreprise 9 (I've already test webmin on
> > our testing server, it works fine) this is the list of enhancements I need
> > to do for Webmin LDAP Users and Groups:
> >
> > 1- Add documentation on the webmin wiki to explain all the configuration
> > options.
> > 2- Add the help.cgi link in many of the module config fields.
> > 3- Enhance the *LDAP attributes *section in *Configuration For module LDAP
> > Users and Groups *in order to enrich the type of attributes (so far there
> > is only input text or textarea fields but no checking is done.) The reason
> > of this is for example to add attribute types like *email *so I can check
> > if the email has a good email format, or telephone numbers, etc, that can be
> > done specifying an regexp (or using some function that webmin have already)
> > 4- In the *Create New Ldap User / Edit user* allow to modify the  *acctFlags:
> > [         ] *attribute by using 1 html checkboxes per acctFlag.
> > 5- The same way we list all the Users and Groups, we would like to list
> > also the Computers (under ou=Computers as normal) and during the editing or
> > creation of new LDAP User, allow us to choose from which Computer will be
> > this user only allowed to access from.
> > 6- In *Configuration* we should allow the admin to specify the fields
> > allowed to Search, so far is restricted to Uid, RealName and few more. What
> > about searching an ANY attribute for?
> >
> > I hope you guys give me some feedback letting me know if some of this
> > features are already implemented or in process to be implemented that way I
> > don't need to waste efforts programming them. Also if you think some options
> > are not making sense or would not be good idea, let me know also.
> >
> > Hi Ivan,
> > Those sound like excellent ideas for features, and I'd be glad to include
> > them in the standard Webmin package if you implement them. As far as I know,
> > nobody else is working on them at the moment, so you should go ahead with
> > your project ..
> >
> >  - Jamie
> >
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > -
> > Forwarded by the Webmin development list at web...@we...
> > To remove yourself from this list, go to
> > http://lists.sourceforge.net/lists/listinfo/webadmin-devel
> >
> >

Re: [webmin-devel] LDAP Users and Groups enhancements

[Ivan G. <cap...@gm...>]

Ok, then I will proceed to develop them.

Do you recommend me any great opensource perl IDE to debug my enhancements?
Which one do you use?

Best Regards.
Ivan.

On Mon, Feb 25, 2008 at 5:35 AM, Jamie Cameron <jca...@we...> wrote:

> On 23/Feb/2008 22:54 Ivan Garcia wrote ..
>
> Hi everybody,
>
> My name is Ivan Garcia,spanish, I'm also developer of OpenSource
> applications(like Subdownloader and Babiloo), mainly Python is my favorite
> language but Perl I consider is a great choice for Shell scripts, config
> files and in general managin Linux Systems, that's why I must say
> congratulations for WebMin.
>
> Now my point is that I work for a company in Singapore that was using a
> home-made Java software named Quro to manage Users/Groups/Computers in a
> LDAP-Samba server(and branches). I was assigned few days ago to make
> enhancements on this propietary Java software but after seeing the mess of
> the outsourced code I decided to convince my bosses to use Webmin and
> enhance the module LDAP Users and Groups to make it fit with the
> requirements of our client. Due that Quro is not commercialized anymore and
> we just need to pick up the best long-term solution for our client, we
> decided to take the Webmin solution.
>
> Our servers are in Suse Linux Entreprise 9 (I've already test webmin on
> our testing server, it works fine) this is the list of enhancements I need
> to do for Webmin LDAP Users and Groups:
>
> 1- Add documentation on the webmin wiki to explain all the configuration
> options.
> 2- Add the help.cgi link in many of the module config fields.
> 3- Enhance the *LDAP attributes *section in *Configuration For module LDAP
> Users and Groups *in order to enrich the type of attributes (so far there
> is only input text or textarea fields but no checking is done.) The reason
> of this is for example to add attribute types like *email *so I can check
> if the email has a good email format, or telephone numbers, etc, that can be
> done specifying an regexp (or using some function that webmin have already)
> 4- In the *Create New Ldap User / Edit user* allow to modify the  *acctFlags:
> [         ] *attribute by using 1 html checkboxes per acctFlag.
> 5- The same way we list all the Users and Groups, we would like to list
> also the Computers (under ou=Computers as normal) and during the editing or
> creation of new LDAP User, allow us to choose from which Computer will be
> this user only allowed to access from.
> 6- In *Configuration* we should allow the admin to specify the fields
> allowed to Search, so far is restricted to Uid, RealName and few more. What
> about searching an ANY attribute for?
>
> I hope you guys give me some feedback letting me know if some of this
> features are already implemented or in process to be implemented that way I
> don't need to waste efforts programming them. Also if you think some options
> are not making sense or would not be good idea, let me know also.
>
> Hi Ivan,
> Those sound like excellent ideas for features, and I'd be glad to include
> them in the standard Webmin package if you implement them. As far as I know,
> nobody else is working on them at the moment, so you should go ahead with
> your project ..
>
>  - Jamie
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel
>
>

Re: [webmin-devel] LDAP Users and Groups enhancements

[Jamie C. <jca...@we...>]

On 23/Feb/2008 22:54 Ivan Garcia wrote ..
<blockquote type="cite">
Hi everybody, <br /><br />My name is Ivan Garcia,spanish, I'm also developer of OpenSource applications(like Subdownloader and Babiloo), mainly Python is my favorite language but Perl I consider is a great choice for Shell scripts, config files and in general managin Linux Systems, that's why I must say congratulations for WebMin.<br />
<br />Now my point is that I work for a company in Singapore that was using a home-made Java software named Quro to manage Users/Groups/Computers in a LDAP-Samba server(and branches). I was assigned few days ago to make enhancements on this propietary Java software but after seeing the mess of the outsourced code I decided to convince my bosses to use Webmin and enhance the module LDAP Users and Groups to make it fit with the requirements of our client. Due that Quro is not commercialized anymore and we just need to pick up the best long-term solution for our client, we decided to take the Webmin solution.<br />
<br />Our servers are in Suse Linux Entreprise 9 (I've already test webmin on our testing server, it works fine) this is the list of enhancements I need to do for Webmin LDAP Users and Groups:<br /><br />1- Add documentation on the webmin wiki to explain all the configuration options.<br />
2- Add the help.cgi link in many of the module config fields.<br />3- Enhance the <strong>LDAP attributes </strong>section in <strong>Configuration For module LDAP Users and Groups </strong>in order to enrich the type of attributes (so far there is only input text or textarea fields but no checking is done.) The reason of this is for example to add attribute types like <strong>email </strong>so I can check if the email has a good email format, or telephone numbers, etc, that can be done specifying an regexp (or using some function that webmin have already)<br />
4- In the <strong>Create New Ldap User / Edit user</strong> allow to modify the&nbsp; <tt>
<strong>acctFlags: [&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ] </strong></tt>attribute by using 1 html checkboxes per acctFlag.<br />5- The same way we list all the Users and Groups, we would like to list also the Computers (under ou=Computers as normal) and during the editing or creation of new LDAP User, allow us to choose from which Computer will be this user only allowed to access from.<br />
6- In <strong>Configuration</strong> we should allow the admin to specify the fields allowed to Search, so far is restricted to Uid, RealName and few more. What about searching an ANY attribute for?<br /><br />I hope you guys give me some feedback letting me know if some of this features are already implemented or in process to be implemented that way I don't need to waste efforts programming them. Also if you think some options are not making sense or would not be good idea, let me know also.<br />
</blockquote>Hi Ivan,<br />Those sound like excellent ideas for features, and I'd be glad to include them in the standard Webmin package if you implement them. As far as I know, nobody else is working on them at the moment, so you should go ahead with your project ..<br /><br />&nbsp;- Jamie<br /><br />

[webmin-devel] LDAP Users and Groups enhancements

[Ivan G. <cap...@gm...>]

Hi everybody,

My name is Ivan Garcia,spanish, I'm also developer of OpenSource
applications(like Subdownloader and Babiloo), mainly Python is my favorite
language but Perl I consider is a great choice for Shell scripts, config
files and in general managin Linux Systems, that's why I must say
congratulations for WebMin.

Now my point is that I work for a company in Singapore that was using a
home-made Java software named Quro to manage Users/Groups/Computers in a
LDAP-Samba server(and branches). I was assigned few days ago to make
enhancements on this propietary Java software but after seeing the mess of
the outsourced code I decided to convince my bosses to use Webmin and
enhance the module LDAP Users and Groups to make it fit with the
requirements of our client. Due that Quro is not commercialized anymore and
we just need to pick up the best long-term solution for our client, we
decided to take the Webmin solution.

Our servers are in Suse Linux Entreprise 9 (I've already test webmin on our
testing server, it works fine) this is the list of enhancements I need to do
for Webmin LDAP Users and Groups:

1- Add documentation on the webmin wiki to explain all the configuration
options.
2- Add the help.cgi link in many of the module config fields.
3- Enhance the *LDAP attributes *section in *Configuration For module LDAP
Users and Groups *in order to enrich the type of attributes (so far there is
only input text or textarea fields but no checking is done.) The reason of
this is for example to add attribute types like *email *so I can check if
the email has a good email format, or telephone numbers, etc, that can be
done specifying an regexp (or using some function that webmin have already)
4- In the *Create New Ldap User / Edit user* allow to modify the  *acctFlags:
[         ] *attribute by using 1 html checkboxes per acctFlag.
5- The same way we list all the Users and Groups, we would like to list also
the Computers (under ou=Computers as normal) and during the editing or
creation of new LDAP User, allow us to choose from which Computer will be
this user only allowed to access from.
6- In *Configuration* we should allow the admin to specify the fields
allowed to Search, so far is restricted to Uid, RealName and few more. What
about searching an ANY attribute for?

I hope you guys give me some feedback letting me know if some of this
features are already implemented or in process to be implemented that way I
don't need to waste efforts programming them. Also if you think some options
are not making sense or would not be good idea, let me know also.

Best Regards.
Ivan.

Re: [webmin-devel] Anonymous Account Activation

[Jamie C. <jca...@we...>]

On 07/Feb/2008 06:00 Bill Moyers wrote ..
> > If you are implementing this as Virtualmin plugin (with a
> > virtual_feature.pl file), you can have your own input fields added to the
> > mailbox user form by defining the mailbox_inputs function in
> > virtual_feature.pl . This is the recommended method, as it removes the
> > need to modify the core Virtualmin code, and so will continue to work even
> > after an upgrade.
> >
> > For details on writing plugins, go to
> > http://www.virtualmin.com/documentation/ and then to the plugin
> > developer's documentation.
> 
> Jamie, you're right. I didn't know about the mailbox_inputs function in
> the docs. Thanks, that solves that problem.
> 
> Also, we'd like to inject into the user creation email a variable
> containing a link to the activation page. Looking through the docs and the
> source, I don't see any way that plugins can change the substitution hash
> for template emails.
> 
> If such a thing doesn't exist, maybe there could be another function in
> the virtual_feature.pl api such as mailbox_email_substitutions which
> returns a hash of additional email substitution variables and is called by
> send_template_email. I can see how potentially other plugins might want to
> be able to do this as well, but you might not agree that it's important
> enough to warrant changing the core.
> 
> The only solution I can see without such a function is to have
> mailbox_save actually insert the link directly into the template email,
> but that's bad because there's no (I think) guarantee that the save will
> be called before the email is sent, and it's just an ugly solution.

There is actually a slightly hackish way you could do this - in the
mailbox_save function, you could set a key of your own in the user
hash parameter (the 1st) with code like :

$_[0]->{myplugin_something} = "whatever";

Then in the email template,  you can refer to ${MYPLUGIN_SOMETHING}
which will be replaced with whatever you set.

 - Jamie

Re: [webmin-devel] Anonymous Account Activation

[Bill M. <bm...@ud...>]

> If you are implementing this as Virtualmin plugin (with a
> virtual_feature.pl file), you can have your own input fields added to the
> mailbox user form by defining the mailbox_inputs function in
> virtual_feature.pl . This is the recommended method, as it removes the
> need to modify the core Virtualmin code, and so will continue to work even
> after an upgrade.
>
> For details on writing plugins, go to
> http://www.virtualmin.com/documentation/ and then to the plugin
> developer's documentation.

Jamie, you're right. I didn't know about the mailbox_inputs function in
the docs. Thanks, that solves that problem.

Also, we'd like to inject into the user creation email a variable
containing a link to the activation page. Looking through the docs and the
source, I don't see any way that plugins can change the substitution hash
for template emails.

If such a thing doesn't exist, maybe there could be another function in
the virtual_feature.pl api such as mailbox_email_substitutions which
returns a hash of additional email substitution variables and is called by
send_template_email. I can see how potentially other plugins might want to
be able to do this as well, but you might not agree that it's important
enough to warrant changing the core.

The only solution I can see without such a function is to have
mailbox_save actually insert the link directly into the template email,
but that's bad because there's no (I think) guarantee that the save will
be called before the email is sent, and it's just an ugly solution.

Re: [webmin-devel] Anonymous Account Activation

[Jamie C. <jca...@we...>]

Hi Bill,
If you are implementing this as Virtualmin plugin (with a virtual_feature.pl file), you can have your own input fields added to the mailbox user form by defining the mailbox_inputs function in virtual_feature.pl . This is the recommended method, as it removes the need to modify the core Virtualmin code, and so will continue to work even after an upgrade.

For details on writing plugins, go to http://www.virtualmin.com/documentation/ and then to the plugin developer's documentation.

 - Jamie

On 06/Feb/2008 07:58 Bill Moyers wrote ..
> Hi all, I have written a module to allow anonymous account activation or
> password recovery (generalizing it to Anonymous Password Change (APC)).
> The module generates a uuid and then allows anonymous access through that
> uuid to change account passwords. I want to submit it, but unfortunately I
> had to make some changes outside the module (i.e.
> virtual-server-lib-funcs.pl) to make it go.
> 
> We wanted the choice of using the module to be on a per user creation
> basis, so I had to add a checkbox to edit_user.cgi that sets a flag in the
> user hash. I also added some lines in create_user (in
> virtual-server-lib-func.pl) to check for the flag and call the module
> library to create a uuid. Then it adds the uuid to the hash. I also had to
> change send_template_email to check for the uuid in the hash and set a
> variable ${APCLINK} in the outgoing template email.
> 
> Does anyone have any ideas on how to separate this from virtualmin so it
> can just be a plugin? Although the code I wrote checks for the existence
> of the plugin so it could technically be distributed I doubt that it would
> warrant being incorporated in the virtualmin 'core'.
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel

Re: [webmin-devel] Anonymous Account Activation

[Bill M. <bm...@ud...>]

Hi all, I have written a module to allow anonymous account activation or
password recovery (generalizing it to Anonymous Password Change (APC)).
The module generates a uuid and then allows anonymous access through that
uuid to change account passwords. I want to submit it, but unfortunately I
had to make some changes outside the module (i.e.
virtual-server-lib-funcs.pl) to make it go.

We wanted the choice of using the module to be on a per user creation
basis, so I had to add a checkbox to edit_user.cgi that sets a flag in the
user hash. I also added some lines in create_user (in
virtual-server-lib-func.pl) to check for the flag and call the module
library to create a uuid. Then it adds the uuid to the hash. I also had to
change send_template_email to check for the uuid in the hash and set a
variable ${APCLINK} in the outgoing template email.

Does anyone have any ideas on how to separate this from virtualmin so it
can just be a plugin? Although the code I wrote checks for the existence
of the plugin so it could technically be distributed I doubt that it would
warrant being incorporated in the virtualmin 'core'.

Re: [webmin-devel] feature request, custom commands

[Joseph L. <jl...@hd...>]

Or just edit the "en" file under the 
/usr/libexec/webmin/CUSTOM-MODULE/lang/ folder.

Jamie Cameron wrote:
> On 02/Feb/2008 06:24 Luis Miguel R. wrote ..
>   
>> El Monday, 24 December del 2007 a las 09:46:26PM, Jamie Cameron escribió:
>>     
>>> On 24/Dec/2007 09:42 Luis Miguel R. wrote ..
>>>       
>>>> Hi all, I have a feature request for "Custom commands" module,
>>>> the only thing I miss is that I can not categorize this custom 
>>>> commands into sections and mayble a title section, this is all 
>>>> many need to create a "custom" webmin module for programs not 
>>>> supported directly by any actual webmin module, access rights can be
>>>> given based on sections or directly on custom commands (like now).
>>>>
>>>> Regards and sorry for my bad english.
>>>>         
>>> There is actually a way you could do something like this already, by
>>> cloning the Custom Commands module as follows :
>>>
>>> 1) Go to the Webmin Configuration module, and click on Webmin Modules.
>>> 2) Select the 'Clone' tab.
>>> 3) From the 'Module to clone' menu select 'Custom Commands'
>>> 4) In the 'Cloned module name' box, enter a category name as you suggested.
>>> 5) Change 'Reset configuration to default?' to 'Yes'.
>>> 6) Click 'Clone Module'.
>>>
>>> You can now go to this new module and create your own custom commands.
>>> This module can be assigned to Webmin users separately from the original
>>> 'Custom Commands' module, and can have the allowed commands independently
>>> configured.
>>>
>>>  - Jamie
>>>       
>> Hi all, your solution works great, the only "problem" I have is all
>> cloned "custon commands" modules show on top "Custon Commands", are
>> there a way to change this title?
>>
>> Regards.
>>     
>
> The only way is to create a file named /etc/webmin/custom*/custom-lang file , containing a line like :
>
> index_title=Your Custom Title
>
>  - Jamie
>   
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> ------------------------------------------------------------------------
>
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel
>   
> ------------------------------------------------------------------------
>
> No virus found in this incoming message.
> Checked by AVG Free Edition. 
> Version: 7.5.516 / Virus Database: 269.19.18/1255 - Release Date: 2/1/2008 9:59 AM
>   

Re: [webmin-devel] feature request, custom commands

[Jamie C. <jca...@we...>]

On 02/Feb/2008 06:24 Luis Miguel R. wrote ..
> El Monday, 24 December del 2007 a las 09:46:26PM, Jamie Cameron escribi=F3:
> > On 24/Dec/2007 09:42 Luis Miguel R. wrote ..
> > > Hi all, I have a feature request for "Custom commands" module,
> > > the only thing I miss is that I can not categorize this custom 
> > > commands into sections and mayble a title section, this is all 
> > > many need to create a "custom" webmin module for programs not 
> > > supported directly by any actual webmin module, access rights can be
> > > given based on sections or directly on custom commands (like now).
> > > 
> > > Regards and sorry for my bad english.
> > 
> > There is actually a way you could do something like this already, by
> > cloning the Custom Commands module as follows :
> > 
> > 1) Go to the Webmin Configuration module, and click on Webmin Modules.
> > 2) Select the 'Clone' tab.
> > 3) From the 'Module to clone' menu select 'Custom Commands'
> > 4) In the 'Cloned module name' box, enter a category name as you suggested.
> > 5) Change 'Reset configuration to default?' to 'Yes'.
> > 6) Click 'Clone Module'.
> > 
> > You can now go to this new module and create your own custom commands.
> > This module can be assigned to Webmin users separately from the original
> > 'Custom Commands' module, and can have the allowed commands independently
> > configured.
> > 
> >  - Jamie
> 
> Hi all, your solution works great, the only "problem" I have is all
> cloned "custon commands" modules show on top "Custon Commands", are
> there a way to change this title?
> 
> Regards.

The only way is to create a file named /etc/webmin/custom*/custom-lang file , containing a line like :

index_title=3DYour Custom Title

 - Jamie

Re: [webmin-devel] feature request, custom commands

[Luis M. R. <lui...@gm...>]

El Monday, 24 December del 2007 a las 09:46:26PM, Jamie Cameron escribió:
> On 24/Dec/2007 09:42 Luis Miguel R. wrote ..
> > Hi all, I have a feature request for "Custom commands" module,
> > the only thing I miss is that I can not categorize this custom 
> > commands into sections and mayble a title section, this is all 
> > many need to create a "custom" webmin module for programs not 
> > supported directly by any actual webmin module, access rights can be
> > given based on sections or directly on custom commands (like now).
> > 
> > Regards and sorry for my bad english.
> 
> There is actually a way you could do something like this already, by
> cloning the Custom Commands module as follows :
> 
> 1) Go to the Webmin Configuration module, and click on Webmin Modules.
> 2) Select the 'Clone' tab.
> 3) From the 'Module to clone' menu select 'Custom Commands'
> 4) In the 'Cloned module name' box, enter a category name as you suggested.
> 5) Change 'Reset configuration to default?' to 'Yes'.
> 6) Click 'Clone Module'.
> 
> You can now go to this new module and create your own custom commands.
> This module can be assigned to Webmin users separately from the original
> 'Custom Commands' module, and can have the allowed commands independently
> configured.
> 
>  - Jamie

Hi all, your solution works great, the only "problem" I have is all
cloned "custon commands" modules show on top "Custon Commands", are
there a way to change this title?

Regards.

Re: [webmin-devel] Patch for regular expression bug in Sarg module(view.cgi)

[Jamie C. <jca...@we...>]

Hi David,

Thanks for the patch - I will include this in the next Webmin release.

 - Jamie

On 31/Jan/2008 12:17 David Harrison wrote ..
> Hi,
> This is a tiny patch that takes on board Colm's correct advice about  
> the regular expression and adds an encapsulating div block around the  
> Sarg report data.
> I've never submitted a patch before so this maybe the completely wrong  
> way of going about doing it :-)
> 
> It changes no functionality but makes the job of theming Sarg reports  
> within Webmin a whole lot easier.
> 
> 
> David
> 
> 
> 
> 
> --- sarg/view.cgi    2008-02-01 08:46:40.000000000 +1300
> +++ sarg/view.cgi    2008-02-01 08:46:29.000000000 +1300
> @@ -24,11 +24,13 @@ if ($full =~ /\.(html|htm)$/i && !$confi
>          if ($data =~ /<TITLE>(.*)<\/TITLE>/i) {
>                  $title = $1;
>                  }
> -	$data =~ s/^[\000-\377]*<BODY.*>//i;
> +	$data =~ s/^[\000-\377]*<BODY.*?>//i;
>          $data =~ s/<\/BODY>[\000-\377]*$//i;
> 
>          &header($title || $text{'view_title'}, "");
> +	print "<div id=\"sarg-report\">\n";
>          print $data;
> +	print "</div>\n";
>          &footer("", $text{'index_return'});
>          }
>   else {
> 
> 
> 
> 
> 
> On 1/02/2008, at 8:17 AM, Colm Dougan wrote:
> 
> > On Jan 31, 2008 7:09 PM, David Harrison
> > <dav...@st...> wrote:
> >>
> >> Lines 27 & 28 of sarg/view.cgi do the dirty work and they are as
> >> follows:
> >> $data =~ s/^[\000-\377]*<BODY.*>//i;
> >> $data =~ s/<\/BODY>[\000-\377]*$//i;
> >
> > If i understand the problem correctly, I think making the .* after the
> > BODY non-greedy, by adding a question mark, will solve it, i.e. :
> >
> > $data =~ s/^[\000-\377]*<BODY.*?>//i;
> >
> > Colm
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > -
> > Forwarded by the Webmin development list at web...@we...
> > To remove yourself from this list, go to
> > http://lists.sourceforge.net/lists/listinfo/webadmin-devel
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel

Re: [webmin-devel] Patch for regular expression bug in Sarg module (view.cgi)

[David H. <dav...@st...>]

Hi,
This is a tiny patch that takes on board Colm's correct advice about  
the regular expression and adds an encapsulating div block around the  
Sarg report data.
I've never submitted a patch before so this maybe the completely wrong  
way of going about doing it :-)

It changes no functionality but makes the job of theming Sarg reports  
within Webmin a whole lot easier.


David




--- sarg/view.cgi    2008-02-01 08:46:40.000000000 +1300
+++ sarg/view.cgi    2008-02-01 08:46:29.000000000 +1300
@@ -24,11 +24,13 @@ if ($full =~ /\.(html|htm)$/i && !$confi
         if ($data =~ /<TITLE>(.*)<\/TITLE>/i) {
                 $title = $1;
                 }
-	$data =~ s/^[\000-\377]*<BODY.*>//i;
+	$data =~ s/^[\000-\377]*<BODY.*?>//i;
         $data =~ s/<\/BODY>[\000-\377]*$//i;

         &header($title || $text{'view_title'}, "");
+	print "<div id=\"sarg-report\">\n";
         print $data;
+	print "</div>\n";
         &footer("", $text{'index_return'});
         }
  else {





On 1/02/2008, at 8:17 AM, Colm Dougan wrote:

> On Jan 31, 2008 7:09 PM, David Harrison
> <dav...@st...> wrote:
>>
>> Lines 27 & 28 of sarg/view.cgi do the dirty work and they are as
>> follows:
>> $data =~ s/^[\000-\377]*<BODY.*>//i;
>> $data =~ s/<\/BODY>[\000-\377]*$//i;
>
> If i understand the problem correctly, I think making the .* after the
> BODY non-greedy, by adding a question mark, will solve it, i.e. :
>
> $data =~ s/^[\000-\377]*<BODY.*?>//i;
>
> Colm
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel

Re: [webmin-devel] Regular expression help to fix bug in Sarg module (view.cgi)

[Colm D. <col...@gm...>]

On Jan 31, 2008 7:09 PM, David Harrison
<dav...@st...> wrote:
>
> Lines 27 & 28 of sarg/view.cgi do the dirty work and they are as
> follows:
> $data =~ s/^[\000-\377]*<BODY.*>//i;
> $data =~ s/<\/BODY>[\000-\377]*$//i;

If i understand the problem correctly, I think making the .* after the
BODY non-greedy, by adding a question mark, will solve it, i.e. :

$data =~ s/^[\000-\377]*<BODY.*?>//i;

Colm

[webmin-devel] Regular expression help to fix bug in Sarg module (view.cgi)

[David H. <dav...@st...>]

Hi,
I am trying to improve the presentation of Sarg reports within Webmin  
but there is a regular expression bug in the Sarg module's view.cgi  
module that is causing me grief.

The Sarg module's view.cgi file reads an html Sarg report and strips  
out the content up to the end of the <body> tag.
The problem is it seems like the regular expression has been written  
with the expectation the the <body> tag of a Sarg report will be on a  
unique line to the rest of the report.

Consequently a Sarg report like the following displays great within  
Webmin:
<body class="body">
<center><table cellpadding=0 cellspacing=0>
<tr>

Whilst a report that doesn't have <body> on a distinct line will not:
<body class="body"><center><table cellpadding=0 cellspacing=0>
<tr>

This is because rather than removing everything up to the end of the  
body tag the regular expression is dropping the entire line :-(
This results in unpaired html tags and varying levels of screen chaos  
depending on the Webmin theme applied.

Lines 27 & 28 of sarg/view.cgi do the dirty work and they are as  
follows:
$data =~ s/^[\000-\377]*<BODY.*>//i;
$data =~ s/<\/BODY>[\000-\377]*$//i;

I've tried on numerous times to understand regular expressions to no  
avail.
Can someone out there suggest a way of tweaking line 27 of view.cgi so  
that it does not remove any report content that proceeds the <body>  
tag if it is on the same line?

Regards,


David Harrison

Re: [webmin-devel] Anonymous Account Activation

[Jamie C. <jca...@we...>]

Hi Bill,

Thanks for pointing this out - I will add additional validation
in the useradmin::modify_user function to prevent invalid user objects
like this from causing incorrect lines to be deleted.

 - Jamie

On 29/Jan/2008 10:39 Bill Moyers wrote ..
> Hi, I have been working on a module to do as described below. I am using
> the webmin passwd module method passwd::change_password to do the actual
> password change. I think I found either a bug or something that could use
> clarification. It seems that if you don't use the passwd::find_user method
> to get the user hash that is an argument to change_password it behaves
> unexpectedly.
> 
> For example, on our system if you try to change an ldap user's password it
> will fail to check ldap-useradmin for the user and default to useradmin
> (i.e. writing to /etc/shadow). I guess since it doesn't find the user it
> silently over-writes the first row of /etc/shadow which is often root.
> This happened in testing a few times and is obviously not good.
> 
> I think the reason is that find_user sets $user->{'mod'} whereas it looks
> like other components use $user->{'module'} to set which module the user
> is in. When I change that it works using user hashes from other functions.
> I don't know if this is considered a bug, but you might want to give a
> warning in the passwd module code so future module writers don't have all
> kinds of errors in their /etc/shadow.
> 
> > On 23/Jan/2008 14:18 Bill Moyers wrote ..
> >> Hello, we are looking to allow anonymous account activation for mailbox
> >> users. In other words, creating a mailbox user would send mail to the
> >> person's alternate address containing an activation url where they would
> >> choose a password. This is to avoid having to send a placeholder
> >> password
> >> over email. I could not find an existing module to do this in
> >> virtualmin.
> >> Does anyone know if such a module exists?
> >
> > There is no module like this currently, but there is one that allows users
> > to sign up for mailboxes (and pick passwords) without needing a Webmin
> > login.
> > See : http://www.webmin.com/cgi-bin/search_third.cgi?search=mailbox+signup
> >
> > Not exactly the same, but similar ..
> >
> >  - Jamie
> >
> 
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel

Re: [webmin-devel] Anonymous Account Activation

[Bill M. <bm...@ud...>]

Hi, I have been working on a module to do as described below. I am using
the webmin passwd module method passwd::change_password to do the actual
password change. I think I found either a bug or something that could use
clarification. It seems that if you don't use the passwd::find_user method
to get the user hash that is an argument to change_password it behaves
unexpectedly.

For example, on our system if you try to change an ldap user's password it
will fail to check ldap-useradmin for the user and default to useradmin
(i.e. writing to /etc/shadow). I guess since it doesn't find the user it
silently over-writes the first row of /etc/shadow which is often root.
This happened in testing a few times and is obviously not good.

I think the reason is that find_user sets $user->{'mod'} whereas it looks
like other components use $user->{'module'} to set which module the user
is in. When I change that it works using user hashes from other functions.
I don't know if this is considered a bug, but you might want to give a
warning in the passwd module code so future module writers don't have all
kinds of errors in their /etc/shadow.

> On 23/Jan/2008 14:18 Bill Moyers wrote ..
>> Hello, we are looking to allow anonymous account activation for mailbox
>> users. In other words, creating a mailbox user would send mail to the
>> person's alternate address containing an activation url where they would
>> choose a password. This is to avoid having to send a placeholder
>> password
>> over email. I could not find an existing module to do this in
>> virtualmin.
>> Does anyone know if such a module exists?
>
> There is no module like this currently, but there is one that allows users
> to sign up for mailboxes (and pick passwords) without needing a Webmin
> login.
> See : http://www.webmin.com/cgi-bin/search_third.cgi?search=mailbox+signup
>
> Not exactly the same, but similar ..
>
>  - Jamie
>

Re: [webmin-devel] DHCPD v3 user defined options problem

[Philippe T. <phi...@m4...>]

Hi Jamie & All

I made a patch which now understands properly that format with brackets.
The parsers does OK (for the moment, I check if the bracket is following a
"=" sign, and if yes I don't start a sub, instead I consider it as simple
text.
Then, I did some small regexp changes in edit_options and save_options to
properly display and save that type. I'm now testing it a little bit, and
I'll send you a patch in a few days when it'll be OK, at least in my testing
environnement.

Bye for now.

2008/1/27, Jamie Cameron <jca...@we...>:
>
> Hi Philippe,
>
> Thanks for pointing this out - the problem here is that Webmin doesn't
> understand this new DHCPd option format with the curly brackets, causing
> it's parser to go into an infinite loop.
>
> Do you plan to work on a patch to properly handle and display these types
> of options? If so, I'd be glad to include it in a future Webmin release..
>
>  - Jamie
>
> On 25/Jan/2008 06:07 Philippe Teissier wrote ..
>
> Hi,
>
> I needed to use option 122 (DOCSIS) in my DHCPD.conf and it appears that
> Webmin had some problem with DHCPD syntax to write it.  It hangs the parser,
> giving me an almost empty page instead of my subnets and groups.
>
> Here are the lines in the dhcpd.conf :
>
> option space docsis-ccc;
> option docsis-ccc.dhcp-server-1 code 1 = ip-address;
> option docsis-ccc.dhcp-server-2 code 2 = ip-address;
>
> option docsis-ccc.provision-server code 3 = { integer 8, string };  ##
> hangs
>
> option docsis-ccc.krb-realm-name code 6 = string;
> option docsis-ccc code 122 = encapsulate docsis-ccc; ## misunderstood
>
> Two of those line are misunderstood by Webmin dhcpd's module
>
> * The 4th line is the one which hangs the parser. It defines a record (int
> 8, string) as the type of the "provision server suboption". And webmin does
> not like it.
> For the moment, I just commented out this line as I do not user the
> provision server parameter.
> * The last line, with the encapsulate type, is also misunderstood, but
> does not hang the code. Instead, webmin will parse and silently forget
> encapsulate's parameter (here docsis-ccc). After a "client optiont" change
> in webmin, the dhcpd.conf will contain "option docsis-ccc code 122 =
> encapsulate;" and then DHCPD's parser will hang (cause this is a syntax
> error).
>
> (more about this option syntax by the end of this document
> http://www.linuxmanpages.com/man5/dhcp-options.5.php)
>
> I wrote a fast hack for that 2nd problem in order to prevent users from
> crashing dhcpd.
>
> [root@localhost dhcpd]# diff edit_options.cgi.Before_patch
> edit_options.cgi
> 168,169c168,176
> <               printf "<input name=dtype_$i size=10 value='%s'>\n",
> <                       $o->{'values'}->[4];
> ---
> >               if ($o->{'values'}->[4] eq "encapsulate") {
> >                   printf "<input name=dtype_$i size=10 value='%s'>\n",
> >                   $o->{'values'}->[4]. " ".$o->{'values'}->[5];
> >
> >               } else {
> >                   printf "<input name=dtype_$i size=10 value='%s'>\n",
> >                   $o->{'values'}->[4];
> >               }
> >
> [root@localhost dhcpd]# diff save_options.cgi.Before_patch
> save_options.cgi
> 116c116
> <               $in{"dtype_$i"} =~ /^[a-z0-9\.\-\_]+$/i ||
> ---
> >               $in{"dtype_$i"} =~ /^(encapsulate |)[a-z0-9\.\-\_]+$/i ||
>
>
> I didn't found anything about this bug in the tracking system. It's the
> 1st time I look at webmin's code, so I'll try to have a deeper look at it,
> and achieve a better patch with support of encapsulate, records, and even
> arrays which are also unsupported I can imagine.
>
> --
> Philippe Teissier
> phi...@m4...<http://reply_mail.cgi?new=1&to=philippe%2Eteissier%40m4tp%2Eorg>
>
>
>


-- 
Philippe Teissier
phi...@m4...

Re: [webmin-devel] DHCPD v3 user defined options problem

[Jamie C. <jca...@we...>]

<p>Hi Philippe,<br /><br />Thanks for pointing this out - the problem here is that Webmin doesn't understand this new DHCPd option format with the curly brackets, causing it's parser to go into an infinite loop.<br /><br />Do you plan to work on a patch to properly handle and display these types of options? If so, I'd be glad to include it in a future Webmin release..<br /><br />&nbsp;- Jamie<br /></p><p>
On 25/Jan/2008 06:07 Philippe Teissier wrote ..
</p><blockquote type="cite">
Hi,<br /><br />I needed to use option 122 (DOCSIS) in my DHCPD.conf and it appears that Webmin had some problem with DHCPD syntax to write it.&nbsp; It hangs the parser, giving me an almost empty page instead of my subnets and groups. <br />
<br />Here are the lines in the dhcpd.conf :<br /><br />option space docsis-ccc;<br />option docsis-ccc.dhcp-server-1 code 1 = ip-address;<br />option docsis-ccc.dhcp-server-2 code 2 = ip-address;<br /><br />option docsis-ccc.provision-server code 3 = { integer 8, string };&nbsp; ## hangs<br />
<br />option docsis-ccc.krb-realm-name code 6 = string;<br />option docsis-ccc code 122 = encapsulate docsis-ccc; ## misunderstood<br /><br />Two of those line are misunderstood by Webmin dhcpd's module<br /><br />* The 4th line is the one which hangs the parser. It defines a record (int 8, string) as the type of the &quot;provision server suboption&quot;. And webmin does not like it.<br />
For the moment, I just commented out this line as I do not user the provision server parameter.<br />* The last line, with the encapsulate type, is also misunderstood, but does not hang the code. Instead, webmin will parse and silently forget encapsulate's parameter (here docsis-ccc). After a &quot;client optiont&quot; change in webmin, the dhcpd.conf will contain &quot;option docsis-ccc code 122 = encapsulate;&quot; and then DHCPD's parser will hang (cause this is a syntax error).<br />
<br />(more about this option syntax by the end of this document <a href="http://www.linuxmanpages.com/man5/dhcp-options.5.php">http://www.linuxmanpages.com/man5/dhcp-options.5.php</a>)<br /><br />I wrote a fast hack for that 2nd problem in order to prevent users from crashing dhcpd.<br />
<br />[root@localhost dhcpd]# diff edit_options.cgi.Before_patch edit_options.cgi<br />168,169c168,176<br />&lt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; printf &quot;&lt;input name=dtype_$i size=10 value='%s'&gt;\n&quot;,<br />&lt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $o-&gt;{'values'}-&gt;[4];<br />
---<br />&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if ($o-&gt;{'values'}-&gt;[4] eq &quot;encapsulate&quot;) {<br />&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; printf &quot;&lt;input name=dtype_$i size=10 value='%s'&gt;\n&quot;,<br />&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $o-&gt;{'values'}-&gt;[4]. &quot; &quot;.$o-&gt;{'values'}-&gt;[5];<br />
&gt;<br />&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; } else {<br />&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; printf &quot;&lt;input name=dtype_$i size=10 value='%s'&gt;\n&quot;,<br />&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $o-&gt;{'values'}-&gt;[4];<br />&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br />
&gt; <br />[root@localhost dhcpd]# diff save_options.cgi.Before_patch save_options.cgi<br />116c116<br />&lt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $in{&quot;dtype_$i&quot;} =~ /^[a-z0-9\.\-\_]+$/i ||<br />---<br />&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $in{&quot;dtype_$i&quot;} =~ /^(encapsulate |)[a-z0-9\.\-\_]+$/i ||<br />
<br /><br />I didn't found anything about this bug in the tracking system. It's the 1st time I look at webmin's code, so I'll try to have a deeper look at it, and achieve a better patch with support of encapsulate, records, and even arrays which are also unsupported I can imagine.<br clear="all" />
<br />-- <br />Philippe Teissier<br /><a href="reply_mail.cgi?new=1&amp;to=philippe%2Eteissier%40m4tp%2Eorg">phi...@m4...</a>
</blockquote><br />

[webmin-devel] DHCPD v3 user defined options problem

[Philippe T. <phi...@gm...>]

Hi,

I needed to use option 122 (DOCSIS) in my DHCPD.conf and it appears that
Webmin had some problem with DHCPD syntax to write it.  It hangs the parser,
giving me an almost empty page instead of my subnets and groups.

Here are the lines in the dhcpd.conf :

option space docsis-ccc;
option docsis-ccc.dhcp-server-1 code 1 = ip-address;
option docsis-ccc.dhcp-server-2 code 2 = ip-address;

option docsis-ccc.provision-server code 3 = { integer 8, string };  ## hangs

option docsis-ccc.krb-realm-name code 6 = string;
option docsis-ccc code 122 = encapsulate docsis-ccc; ## misunderstood

Two of those line are misunderstood by Webmin dhcpd's module

* The 4th line is the one which hangs the parser. It defines a record (int
8, string) as the type of the "provision server suboption". And webmin does
not like it.
For the moment, I just commented out this line as I do not user the
provision server parameter.
* The last line, with the encapsulate type, is also misunderstood, but does
not hang the code. Instead, webmin will parse and silently forget
encapsulate's parameter (here docsis-ccc). After a "client optiont" change
in webmin, the dhcpd.conf will contain "option docsis-ccc code 122 =
encapsulate;" and then DHCPD's parser will hang (cause this is a syntax
error).

(more about this option syntax by the end of this document
http://www.linuxmanpages.com/man5/dhcp-options.5.php)

I wrote a fast hack for that 2nd problem in order to prevent users from
crashing dhcpd.

[root@localhost dhcpd]# diff edit_options.cgi.Before_patch edit_options.cgi
168,169c168,176
<               printf "<input name=dtype_$i size=10 value='%s'>\n",
<                       $o->{'values'}->[4];
---
>               if ($o->{'values'}->[4] eq "encapsulate") {
>                   printf "<input name=dtype_$i size=10 value='%s'>\n",
>                   $o->{'values'}->[4]. " ".$o->{'values'}->[5];
>
>               } else {
>                   printf "<input name=dtype_$i size=10 value='%s'>\n",
>                   $o->{'values'}->[4];
>               }
>
[root@localhost dhcpd]# diff save_options.cgi.Before_patch save_options.cgi
116c116
<               $in{"dtype_$i"} =~ /^[a-z0-9\.\-\_]+$/i ||
---
>               $in{"dtype_$i"} =~ /^(encapsulate |)[a-z0-9\.\-\_]+$/i ||


I didn't found anything about this bug in the tracking system. It's the 1st
time I look at webmin's code, so I'll try to have a deeper look at it, and
achieve a better patch with support of encapsulate, records, and even arrays
which are also unsupported I can imagine.

-- 
Philippe Teissier
phi...@m4...

Re: [webmin-devel] Anonymous Account Activation

[Jamie C. <jca...@we...>]

On 23/Jan/2008 14:18 Bill Moyers wrote ..
> Hello, we are looking to allow anonymous account activation for mailbox
> users. In other words, creating a mailbox user would send mail to the
> person's alternate address containing an activation url where they would
> choose a password. This is to avoid having to send a placeholder password
> over email. I could not find an existing module to do this in virtualmin.
> Does anyone know if such a module exists?

There is no module like this currently, but there is one that allows users
to sign up for mailboxes (and pick passwords) without needing a Webmin login.
See : http://www.webmin.com/cgi-bin/search_third.cgi?search=mailbox+signup

Not exactly the same, but similar ..

 - Jamie

[webmin-devel] Anonymous Account Activation

[Bill M. <bm...@ud...>]

Hello, we are looking to allow anonymous account activation for mailbox
users. In other words, creating a mailbox user would send mail to the
person's alternate address containing an activation url where they would
choose a password. This is to avoid having to send a placeholder password
over email. I could not find an existing module to do this in virtualmin.
Does anyone know if such a module exists?