Re: [WebERP-developers] SVN

[Bogdan S. <bog...@gm...>]

Not sure what you mean, I might have been a bit unclear...

there are scripts which have a new line after the end of the php tag. 
something like this:
++++++++

code....
?>

++++++end of file

instead of

++++++

code
?>
+++++++end of file

this is what I was talking about. However, I personally correct this 
only when I get to edit a file for other reasons, as they generally work 
as is. as I said, it is just some best practice, so I do it a bit by 
reflex. Of course, as you are "touching" a lot of files it could make 
sense....

hope it helps.




AESE wrote:
> Hi Bogdan,
>
> Should we remove them or move them to the line before the final "end of 
> script tag symbol"?
> for example, see TopItems.php (it's placed after all)
>
> Thanks,
> javier
>
>
> ----- Original Message ----- 
> From: "Bogdan Stanciu" <bog...@gm...>
> To: "webERP Developers" <web...@li...>
> Sent: Wednesday, November 04, 2009 1:21 PM
> Subject: Re: [WebERP-developers] SVN
>
>
> Javier,
>
>
> For your last question, it just BEST practice, as when you will expect
> it less, the extra line can cause errors. Especially in the cases when
> NOTHING should be sent after a commit of some sort. I wasted weeks of
> checking (on another project) because of this...
>
>
> regards,
>
> Bogdan
>
>
> AESE wrote:
>
>   
>> Hi Tim,
>>
>> The version number comment in the beginning of php scripts is auto
>> maintained or we should increment it before the commitment (not sure to 
>> have
>> read there was a sourceforge auto facility).
>>
>> I like this version label, is there a reason to not use it in 
>> "api_php.php"
>> and "FixedAssetRegister.php"?
>>
>> Also, the final "\not new line at end of the file" is a webERP rule or
>> recommended or a thing to avoid? (I will do it as you like)
>>
>> Thanks,
>> javier
>>
>>
>> ----- Original Message ----- 
>> From: "Tim Schofield" <tim...@go...>
>> To: "webERP Developers" <web...@li...>
>> Sent: Wednesday, November 04, 2009 12:11 PM
>> Subject: Re: [WebERP-developers] SVN
>>
>>
>> Ok, I believe that I have now have the trunk of svn correct. Can any
>> developers now start to use this instead of cvs. Unless there are any
>> objections I shall turn off the cvs facility tomorrow at about this
>> time (midday GMT). Next plan is to get the stable branch up to date.
>>
>> My request for help on maintaining this stable branch is still open.....
>>
>> Thanks
>> Tim
>>
>>
>> 2009/11/3 Tim Schofield <tim...@go...>:
>>
>>     
>>> Certainly will :)
>>>
>>>
>>> 2009/11/3 Bogdan Stanciu <bog...@gm...>:
>>>
>>>       
>>>> i was about to ask :-)) as i've seen tens of cvs updates with svn 
>>>> prefix.
>>>>
>>>> great! will you let us know when we could "switch" svn?
>>>>
>>>> thank you!
>>>>
>>>> Tim Schofield wrote:
>>>>
>>>>         
>>>>> Hi Javier,
>>>>>
>>>>> As I have already said I plan to move to svn this week - in fact I
>>>>> have already started it. I thought Nicholas and/or Murray were keeping
>>>>> svn updated with any cvs changes, but that seemed to stop for some
>>>>> reason. I am now bringing svn up to date with cvs and then we can turn
>>>>> cvs off.
>>>>>
>>>>> Thanks
>>>>> Tim
>>>>>
>>>>>
>>>>> 2009/11/3 AESE, S.L., Javier de Lorenzo-Cáceres. <in...@ci...>:
>>>>>
>>>>>
>>>>>           
>>>>>> Hi Phil, Tim, Nicholas and all the developers, coders and 
>>>>>> contributors,
>>>>>>
>>>>>> I didn't realize how great is the job that Nicholas and Murray did 
>>>>>> with
>>>>>> the
>>>>>> CVS to SVN move, many thanks and greetings. Also, Nicholas left us a
>>>>>> good
>>>>>> mail collection of how to work with the SVN and other matters, thanks
>>>>>> again. I don't see any reason to not begin to commit to the trunk but
>>>>>> if
>>>>>> we wait there will be. I have waited to commit, waited to get
>>>>>> confidence
>>>>>> with both SVN and WebERP. Instead to commit, I have noted the files I
>>>>>> would
>>>>>> like to change along with some narrative. For the minor changes as
>>>>>> htmlentities, htmlspacialchars, css, xhtml, typos, .pot and the like I
>>>>>> feel
>>>>>> confident to apply. For other changes as database field types I will
>>>>>> ask for
>>>>>> permission or consense.
>>>>>>
>>>>>> If we don't begin now, we will have to be prepared to loose one of the
>>>>>> following three: the great Nicholas work, some cvs history or the time
>>>>>> and
>>>>>> effort, i.e., if a file is changed more than once in the cvs, updating
>>>>>> the
>>>>>> svn trunk without loosing previous change(s) will not be as easy as an
>>>>>> "add"
>>>>>> and we will have to learn how to merge both histories.
>>>>>>
>>>>>> The method I am using to update the utf-8 branch with the cvs updates
>>>>>> and to
>>>>>> keep a notebook with the outstanding commits is all but comfortable. 
>>>>>> If
>>>>>> I
>>>>>> had started to commit to the trunk, those files would need trace to
>>>>>> keep an
>>>>>> eye if overwritten, which is more or less the same work. Of course, 
>>>>>> the
>>>>>> easy
>>>>>> way would be to work with the cvs but that's not the shape of my mind.
>>>>>>
>>>>>> Now that I'm confident with the svn I will begin to work with the
>>>>>> another
>>>>>> UTF-8 branch created by Murray. It has files history and it is a fresh
>>>>>> 3.11
>>>>>> ISO so all the changes to utf-8 will be recorded. Once finished, i 
>>>>>> will
>>>>>> delete my utf-8 branch to avoid possible confusion.
>>>>>>
>>>>>> The move to utf-8 has not resulted as difficult but to make things
>>>>>> well-done
>>>>>> all the reports should be reviewed (this is what we feared) and for 
>>>>>> the
>>>>>> same
>>>>>> reason that Tim changed Stream() by Output('filename', 'I') all
>>>>>> functions
>>>>>> should be changed and class.pdf.php removed; albeit that's not
>>>>>> absolutely
>>>>>> neccesary, it would only be better in my opinion. That's not 
>>>>>> difficult,
>>>>>> only
>>>>>> time-consuming for the quantity of reports and the fact that we don't
>>>>>> have a
>>>>>> sortered list and the 4 different pdf techniques. The functions to
>>>>>> change
>>>>>> are:
>>>>>>
>>>>>> Stream -> Output (done in 39 + 2 new)
>>>>>> selectFont -> SetFont (this has to be consensed)
>>>>>> newPage -> AddPage
>>>>>> line -> Line
>>>>>> addText -> Text
>>>>>> addInfo -> SetAuthor
>>>>>> addJpegFromFile -> Image
>>>>>> partEllipse -> ellipse
>>>>>> ellipse ->
>>>>>> addTextWrap ->
>>>>>>
>>>>>> At least, the TCPDF choice is a solid step, i think. Some says it's 
>>>>>> not
>>>>>> as
>>>>>> stable as FPDF. Unfortunately, we haven't got enough alpha testing to
>>>>>> tell,
>>>>>> maybe Dale will want to help. I believe TCPDF will have a solid
>>>>>> development.
>>>>>> By the way, I haven't taken a look for TCPDF updates.
>>>>>>
>>>>>> But the move to utf-8 is not the matter now; it's the move to svn.
>>>>>>
>>>>>> Thanks and regards,
>>>>>> javier
>>>>>> ------------------------------------------------------------------------------
>>>>>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>>>>>> is the only developer event you need to attend this year. Jumpstart
>>>>>> your
>>>>>> developing skills, take BlackBerry mobile applications to market and
>>>>>> stay
>>>>>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>>>>>> http://p.sf.net/sfu/devconference
>>>>>> _______________________________________________
>>>>>> Web-erp-developers mailing list
>>>>>> Web...@li...
>>>>>> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>             
>>>>> ------------------------------------------------------------------------------
>>>>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>>>>> is the only developer event you need to attend this year. Jumpstart 
>>>>> your
>>>>> developing skills, take BlackBerry mobile applications to market and
>>>>> stay
>>>>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>>>>> http://p.sf.net/sfu/devconference
>>>>> _______________________________________________
>>>>> Web-erp-developers mailing list
>>>>> Web...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>>>>>
>>>>>
>>>>>           
>>>> ------------------------------------------------------------------------------
>>>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>>>> is the only developer event you need to attend this year. Jumpstart your
>>>> developing skills, take BlackBerry mobile applications to market and 
>>>> stay
>>>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>>>> http://p.sf.net/sfu/devconference
>>>> _______________________________________________
>>>> Web-erp-developers mailing list
>>>> Web...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>>>>
>>>>
>>>>         
>> ------------------------------------------------------------------------------
>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 
>> 30-Day
>> trial. Simplify your report design, integration and deployment - and focus
>> on
>> what you do best, core application coding. Discover what's new with
>> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
>> _______________________________________________
>> Web-erp-developers mailing list
>> Web...@li...
>> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>>
>>
>> ------------------------------------------------------------------------------
>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 
>> 30-Day
>> trial. Simplify your report design, integration and deployment - and focus 
>> on
>> what you do best, core application coding. Discover what's new with
>> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
>> _______________________________________________
>> Web-erp-developers mailing list
>> Web...@li...
>> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>>
>>     
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus 
> on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers 
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>