|
From: AESE, S.L., J. de Lorenzo-C. <in...@ci...> - 2009-11-03 09:34:49
|
Hi Phil, Tim, Nicholas and all the developers, coders and contributors,
I didn't realize how great is the job that Nicholas and Murray did with the CVS to SVN move, many thanks and greetings. Also, Nicholas left us a good mail collection of how to work with the SVN and other matters, thanks again. I don't see any reason to not begin to commit to the trunk but if we wait there will be. I have waited to commit, waited to get confidence with both SVN and WebERP. Instead to commit, I have noted the files I would like to change along with some narrative. For the minor changes as htmlentities, htmlspacialchars, css, xhtml, typos, .pot and the like I feel confident to apply. For other changes as database field types I will ask for permission or consense.
If we don't begin now, we will have to be prepared to loose one of the following three: the great Nicholas work, some cvs history or the time and effort, i.e., if a file is changed more than once in the cvs, updating the svn trunk without loosing previous change(s) will not be as easy as an "add" and we will have to learn how to merge both histories.
The method I am using to update the utf-8 branch with the cvs updates and to keep a notebook with the outstanding commits is all but comfortable. If I had started to commit to the trunk, those files would need trace to keep an eye if overwritten, which is more or less the same work. Of course, the easy way would be to work with the cvs but that's not the shape of my mind.
Now that I'm confident with the svn I will begin to work with the another UTF-8 branch created by Murray. It has files history and it is a fresh 3.11 ISO so all the changes to utf-8 will be recorded. Once finished, i will delete my utf-8 branch to avoid possible confusion.
The move to utf-8 has not resulted as difficult but to make things well-done all the reports should be reviewed (this is what we feared) and for the same reason that Tim changed Stream() by Output('filename', 'I') all functions should be changed and class.pdf.php removed; albeit that's not absolutely neccesary, it would only be better in my opinion. That's not difficult, only time-consuming for the quantity of reports and the fact that we don't have a sortered list and the 4 different pdf techniques. The functions to change are:
Stream -> Output (done in 39 + 2 new)
selectFont -> SetFont (this has to be consensed)
newPage -> AddPage
line -> Line
addText -> Text
addInfo -> SetAuthor
addJpegFromFile -> Image
partEllipse -> ellipse
ellipse ->
addTextWrap ->
At least, the TCPDF choice is a solid step, i think. Some says it's not as stable as FPDF. Unfortunately, we haven't got enough alpha testing to tell, maybe Dale will want to help. I believe TCPDF will have a solid development. By the way, I haven't taken a look for TCPDF updates.
But the move to utf-8 is not the matter now; it's the move to svn.
Thanks and regards,
javier |